Whamcloud - gitweb
branch: b_new_cmd
authorericm <ericm>
Wed, 8 Nov 2006 20:28:16 +0000 (20:28 +0000)
committerericm <ericm>
Wed, 8 Nov 2006 20:28:16 +0000 (20:28 +0000)
fix null pointer reference in CERROR.

lustre/ptlrpc/gss/sec_gss.c

index a12e17b..5d4cd4b 100644 (file)
@@ -2075,15 +2075,13 @@ int gss_svc_handle_data(struct ptlrpc_request *req,
                 rc = -EINVAL;
         }
 
-        if (rc != 0)
-                goto error;
-
-        RETURN(SECSVC_OK);
+        if (rc == 0)
+                RETURN(SECSVC_OK);
 
-error:
         CERROR("svc %u failed: major 0x%08x: ctx %p(%u->%s)\n",
                gw->gw_svc, major, grctx->src_ctx, grctx->src_ctx->gsc_uid,
                libcfs_nid2str(req->rq_peer.nid));
+error:
         /*
          * we only notify client in case of NO_CONTEXT/BAD_SIG, which
          * might happen after server reboot, to allow recovery.