Whamcloud - gitweb
LU-17071 o2iblnd: IBLND_REJECT_EARLY condition causes Oops 02/52202/4
authorSerguei Smirnov <ssmirnov@whamcloud.com>
Thu, 31 Aug 2023 19:34:00 +0000 (12:34 -0700)
committerOleg Drokin <green@whamcloud.com>
Wed, 8 Nov 2023 22:02:34 +0000 (22:02 +0000)
The message printed when kiblnd_passive_connect recognizes
IBLND_REJECT_EARLY condition introduced by LU-16393 is trying
to derefence a NULL pointer in the parameter list. Fix this.

Test-parameters: trivial
Fixes: 673ff86a84a ("LU-16393 o2iblnd: add IBLND_REJECT_EARLY reject reason")
Signed-off-by: Serguei Smirnov <ssmirnov@whamcloud.com>
Change-Id: I711e5855383c140b9f7c35b27f48995f3f0e25ee
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/52202
Reviewed-by: Frank Sehr <fsehr@whamcloud.com>
Reviewed-by: Cyril Bordage <cbordage@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
lnet/klnds/o2iblnd/o2iblnd_cb.c

index 3fbc283..d0ce634 100644 (file)
@@ -2575,9 +2575,8 @@ kiblnd_passive_connect(struct rdma_cm_id *cmid, void *priv, int priv_nob)
        } else {
                if (ibdev->ibd_nnets == 0) {
                        rej.ibr_why = IBLND_REJECT_EARLY;
-                       CNETERR("Can't accept conn from %s on %s (%s:%d:%pI4h): net for nid %s not added yet\n",
+                       CNETERR("Can't accept conn from %s (%s:%d:%pI4h): net for nid %s not added yet\n",
                                libcfs_nid2str(nid),
-                               libcfs_nidstr(&net->ibn_ni->ni_nid),
                                ibdev->ibd_ifname, ibdev->ibd_nnets,
                                &ibdev->ibd_ifip,
                                libcfs_nid2str(reqmsg->ibm_dstnid));