LU-17010 lfsck: don't dump stack repeatedly

If there are transactions started with LFSCK in dry-run mode, don't
dump the stack repeatedly, as this can spam the console logs and
significantly hurt performance.

Test-Parameters: trivial testlist=sanity-lfsck
Fixes: 0c1ae1cb9c ("LU-13124 scrub: check for multiple linked file")
Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
Change-Id: I0b0d64911453dc8ab947e284656311b5d0300c1e
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/52356
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Hongchao Zhang <hongchao@whamcloud.com>
Reviewed-by: Lai Siyao <lai.siyao@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>

diff --git a/lustre/lfsck/lfsck_internal.h b/lustre/lfsck/lfsck_internal.h
index cffe2c7..7330b0d 100644 (file)
--- a/lustre/lfsck/lfsck_internal.h
+++ b/lustre/lfsck/lfsck_internal.h
@@ -1551,10 +1551,13 @@ lfsck_trans_create(const struct lu_env *env, struct dt_device *dev,
                   struct lfsck_instance *lfsck)
 {
        if (lfsck->li_bookmark_ram.lb_param & LPF_DRYRUN) {
+               static int count;
+
                CERROR("%s: transaction is being created in DRYRUN mode!\n",
                       lfsck_lfsck2name(lfsck));
 
-               dump_stack();
+               if (count++ < 3)
+                       dump_stack();
                return ERR_PTR(-EINVAL);
        }