Whamcloud - gitweb
LU-18016 kfilnd: avoid wrong call to kfilnd_ep_put_key 88/55688/2
authorVladimir Saveliev <vladimir.saveliev@hpe.com>
Wed, 10 Jul 2024 09:26:17 +0000 (12:26 +0300)
committerOleg Drokin <green@whamcloud.com>
Fri, 16 Aug 2024 23:53:00 +0000 (23:53 +0000)
kfilnd_tn_alloc(): do not call kfilnd_ep_put_key() if
kfilnd_ep_get_key() was not called

HPE-bug-id: LUS-12405
Test-Parameters: trivial
Signed-off-by: Vladimir Saveliev <vladimir.saveliev@hpe.com>
Change-Id: I6dc9f581b5632a9a220cc04f4b5735581b75f40a
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/55688
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Chris Horn <chris.horn@hpe.com>
Reviewed-by: Alexander Boyko <alexander.boyko@hpe.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lnet/klnds/kfilnd/kfilnd_tn.c

index 60fc54e..68ff4ee 100644 (file)
@@ -1700,7 +1700,8 @@ struct kfilnd_transaction *kfilnd_tn_alloc(struct kfilnd_dev *dev, int cpt,
        return tn;
 
 err_put_key:
-       kfilnd_ep_put_key(ep, key);
+       if (need_key)
+               kfilnd_ep_put_key(ep, key);
 err:
        return ERR_PTR(rc);
 }