Whamcloud - gitweb
LU-15988 osp: don't print nid on -ESTALE 49/55049/2
authorLai Siyao <lai.siyao@whamcloud.com>
Fri, 3 May 2024 00:27:04 +0000 (20:27 -0400)
committerOleg Drokin <green@whamcloud.com>
Wed, 29 May 2024 04:48:51 +0000 (04:48 +0000)
Osp_send_update_req() should not access import upon -ESTALE, because
this MDT may be in umount.

Signed-off-by: Lai Siyao <lai.siyao@whamcloud.com>
Change-Id: Ibd869e4e8da4f90ffd608a36d866264d5d552d0e
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/55049
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Jian Yu <yujian@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/osp/osp_trans.c

index ae39b81..decf38f 100644 (file)
@@ -1126,14 +1126,11 @@ static int osp_send_update_req(const struct lu_env *env,
        LASSERT(osp->opd_obd);
 
        if (ou && ou->ou_generation != our->our_generation) {
-               const struct lnet_processid *peer;
-
                rc = -ESTALE;
                osp_trans_callback(env, oth, rc);
-               peer = &osp->opd_obd->u.cli.cl_import->imp_connection->c_peer;
-               CDEBUG(D_HA, "%s: stale tx to %s: gen %llu != %llu: rc = %d\n",
-                      osp->opd_obd->obd_name, libcfs_nidstr(&peer->nid),
-                      osp->opd_update->ou_generation, our->our_generation, rc);
+               CDEBUG(D_HA, "%s: stale tx: gen %llu != %llu: rc = %d\n",
+                      osp->opd_obd->obd_name, ou->ou_generation,
+                      our->our_generation, rc);
                RETURN(rc);
        }