Whamcloud - gitweb
LU-16796 libcfs: Remove reference to LASSERT_ATOMIC_GT 89/51189/4
authorArshad Hussain <arshad.hussain@aeoncomputing.com>
Thu, 1 Jun 2023 07:33:01 +0000 (13:03 +0530)
committerOleg Drokin <green@whamcloud.com>
Sat, 8 Jul 2023 22:35:51 +0000 (22:35 +0000)
This patch removes all reference to LASSERT_ATOMIC_GT macro.

Signed-off-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Change-Id: I7978ceb495c3e03153843439109d48d47bba1e2a
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/51189
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
libcfs/include/libcfs/libcfs_private.h
lustre/ptlrpc/sec_null.c

index a3382ef..c4c90ed 100644 (file)
@@ -254,10 +254,6 @@ int libcfs_debug_mark_buffer(const char *text);
 #define LASSERT_ATOMIC_EQ(a, v)                                \
        LASSERTF(atomic_read(a) == v, "value: %d\n", atomic_read((a)));
 
-/** assert value of @a is great than @v */
-#define LASSERT_ATOMIC_GT(a, v)                                \
-       LASSERTF(atomic_read(a) > v, "value: %d\n", atomic_read((a)));
-
 /** assert value of @a is great than @v1 and little than @v2 */
 #define LASSERT_ATOMIC_GT_LT(a, v1, v2)                        \
 do {                                                           \
@@ -268,7 +264,6 @@ do {                                                           \
 #else /* !LASSERT_ATOMIC_ENABLED */
 
 #define LASSERT_ATOMIC_EQ(a, v)                 do {} while (0)
-#define LASSERT_ATOMIC_GT(a, v)                 do {} while (0)
 #define LASSERT_ATOMIC_GT_LT(a, v1, v2)         do {} while (0)
 
 #endif /* LASSERT_ATOMIC_ENABLED */
index 4fb3a09..f56c356 100644 (file)
@@ -332,7 +332,7 @@ int null_alloc_rs(struct ptlrpc_request *req, int msgsize)
 static
 void null_free_rs(struct ptlrpc_reply_state *rs)
 {
-       LASSERT_ATOMIC_GT(&rs->rs_svc_ctx->sc_refcount, 1);
+       LASSERT(atomic_read(&rs->rs_svc_ctx->sc_refcount) > 1);
        atomic_dec(&rs->rs_svc_ctx->sc_refcount);
 
        if (!rs->rs_prealloc)