LU-5862 changelog: Proper record remapping

Fixed changelog_remap_rec() to correctly remap records emitted
with jobid_var=disabled, i.e. delivered by new servers but with
no jobid field.

Updated sanity test 205 accordingly.

Signed-off-by: Henri Doreau <henri.doreau@cea.fr>
Change-Id: Ia151e9bfde2def8819913ee658bde6b71ef3ab18
Reviewed-on: http://review.whamcloud.com/12574
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Robert Read <robert.read@intel.com>

diff --git a/lustre/include/lustre/lustre_user.h b/lustre/include/lustre/lustre_user.h
index 28846c7..4b3fc93 100644 (file)
--- a/lustre/include/lustre/lustre_user.h
+++ b/lustre/include/lustre/lustre_user.h
@@ -928,39 +928,64 @@ static inline char *changelog_rec_sname(struct changelog_rec *rec)
        return cr_name + strlen(cr_name) + 1;
 }
 
-/* Remap a record to the desired format as specified by the crf flags.
- * The record must be big enough to contain the final remapped version. */
+/**
+ * Remap a record to the desired format as specified by the crf flags.
+ * The record must be big enough to contain the final remapped version.
+ * Superfluous extension fields are removed and missing ones are added
+ * and zeroed. The flags of the record are updated accordingly.
+ *
+ * The jobid and rename extensions can be added to a record, to match the
+ * format an application expects, typically. In this case, the newly added
+ * fields will be zeroed.
+ * The Jobid field can be removed, to guarantee compatibility with older
+ * clients that don't expect this field in the records they process.
+ *
+ * The following assumptions are being made:
+ *   - CLF_RENAME will not be removed
+ *   - CLF_JOBID will not be added without CLF_RENAME being added too
+ *
+ * @param[in,out]  rec         The record to remap.
+ * @param[in]      crf_wanted  Flags describing the desired extensions.
+ */
 static inline void changelog_remap_rec(struct changelog_rec *rec,
-                                      enum changelog_rec_flags crf)
+                                      enum changelog_rec_flags crf_wanted)
 {
-       char    *var_part;
-       size_t   var_size;
+       char *jid_mov;
+       char *rnm_mov;
 
-       crf &= CLF_SUPPORTED;
+       crf_wanted &= CLF_SUPPORTED;
 
-       if ((rec->cr_flags & CLF_SUPPORTED) == crf)
+       if ((rec->cr_flags & CLF_SUPPORTED) == crf_wanted)
                return;
 
-       if ((crf & CLF_JOBID) && rec->cr_flags & CLF_JOBID) {
-               var_part = (char *)changelog_rec_jobid(rec);
-               var_size = rec->cr_namelen + sizeof(struct changelog_ext_jobid);
-       } else {
-               var_part = changelog_rec_name(rec);
-               var_size = rec->cr_namelen;
-       }
+       /* First move the variable-length name field */
+       memmove((char *)rec + changelog_rec_offset(crf_wanted),
+               changelog_rec_name(rec), rec->cr_namelen);
+
+       /* Locations of jobid and rename extensions in the remapped record */
+       jid_mov = (char *)rec +
+                 changelog_rec_offset(crf_wanted & ~CLF_JOBID);
+       rnm_mov = (char *)rec +
+                 changelog_rec_offset(crf_wanted & ~(CLF_JOBID | CLF_RENAME));
+
+       /* Move the extension fields to the desired positions */
+       if ((crf_wanted & CLF_JOBID) && (rec->cr_flags & CLF_JOBID))
+               memmove(jid_mov, changelog_rec_jobid(rec),
+                       sizeof(struct changelog_ext_jobid));
 
-       memmove((char *)rec + changelog_rec_offset(crf & ~CLF_JOBID), var_part,
-               var_size);
+       if ((crf_wanted & CLF_RENAME) && (rec->cr_flags & CLF_RENAME))
+               memmove(rnm_mov, changelog_rec_rename(rec),
+                       sizeof(struct changelog_ext_rename));
 
-       if ((crf & CLF_RENAME) && !(rec->cr_flags & CLF_RENAME))
-               memset(changelog_rec_rename(rec), 0,
-                      sizeof(struct changelog_ext_rename));
+       /* Clear newly added fields */
+       if ((crf_wanted & CLF_JOBID) && !(rec->cr_flags & CLF_JOBID))
+               memset(jid_mov, 0, sizeof(struct changelog_ext_jobid));
 
-       if ((crf & CLF_JOBID) && !(rec->cr_flags & CLF_JOBID))
-               memset(changelog_rec_jobid(rec), 0,
-                      sizeof(struct changelog_ext_jobid));
+       if ((crf_wanted & CLF_RENAME) && !(rec->cr_flags & CLF_RENAME))
+               memset(rnm_mov, 0, sizeof(struct changelog_ext_rename));
 
-       rec->cr_flags = (rec->cr_flags & CLF_FLAGMASK) | crf;
+       /* Update the record's flags accordingly */
+       rec->cr_flags = (rec->cr_flags & CLF_FLAGMASK) | crf_wanted;
 }
 
 struct ioc_changelog {

diff --git a/lustre/tests/sanity.sh b/lustre/tests/sanity.sh
index 4dc8ecd..ef697d2 100644 (file)
--- a/lustre/tests/sanity.sh
+++ b/lustre/tests/sanity.sh
@@ -11369,6 +11369,15 @@ test_205() { # Job stats
                jobids=$($LFS changelog $MDT0 | tail -9 | grep -c "j=")
                [ $jobids -eq 9 ] ||
                        error "Wrong changelog jobid count $jobids != 9"
+
+               # LU-5862
+               JOBENV="disable"
+               jobstats_set $JOBENV
+               touch $DIR/$tfile
+               $LFS changelog $MDT0 | tail -1
+               jobids=$($LFS changelog $MDT0 | tail -1 | grep -c "j=")
+               [ $jobids -eq 0 ] ||
+                       error "Unexpected jobids when jobid_var=$JOBENV"
        fi
 
        # cleanup