Whamcloud - gitweb
LU-16899 gnilnd: Use libcfs_nidstr and fix typo 30/51330/3
authorShaun Tancheff <shaun.tancheff@hpe.com>
Sun, 18 Jun 2023 02:39:00 +0000 (09:39 +0700)
committerOleg Drokin <green@whamcloud.com>
Sat, 8 Jul 2023 22:36:23 +0000 (22:36 +0000)
CDEBUG() in kgnilnd_peer_notify() should use libcfs_nidstr()

kgnilnd_finish_connect() has a typo in lnet_notify() where
peer_nid was intended.

Test-Parameters: trivial
Fixes: 4a88236f40 ("LU-10391 lnet: change lnet_notify() to take struct lnet_nid")
Signed-off-by: Shaun Tancheff <shaun.tancheff@hpe.com>
Change-Id: If45a28b654e27aa34b655fefaea142dc740fa46f
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/51330
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Chris Horn <chris.horn@hpe.com>
Reviewed-by: Neil Brown <neilb@suse.de>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lnet/klnds/gnilnd/gnilnd.c
lnet/klnds/gnilnd/gnilnd_conn.c

index 62d578a..dbb8f0b 100644 (file)
@@ -602,7 +602,8 @@ kgnilnd_peer_notify(kgn_peer_t *peer, int error, int alive)
                                         &peer_nid);
 
                        CDEBUG(D_NET, "peer 0x%p->%s last_alive %lld (%llds ago)\n",
-                               peer, libcfs_nid2str(peer_nid), peer->gnp_last_alive,
+                               peer, libcfs_nidstr(&peer_nid),
+                               peer->gnp_last_alive,
                                ktime_get_seconds() - peer->gnp_last_alive);
 
                        lnet_notify(net->gnn_ni, &peer_nid, alive, true,
index f887762..5159248 100644 (file)
@@ -1952,7 +1952,7 @@ kgnilnd_finish_connect(kgn_dgram_t *dgram)
         * This is a Cray extension to the "standard" LND behavior.
         */
        lnet_nid4_to_nid(peer->gnp_nid, &peer_nid);
-       lnet_notify(peer->gnp_net->gnn_ni, &peed_nid, true, true,
+       lnet_notify(peer->gnp_net->gnn_ni, &peer_nid, true, true,
                    ktime_get_seconds());
 
        /* drop our 'hold' ref */