Whamcloud - gitweb
LU-17743 o2iblnd: fix privileged port check in passive_connect 66/55266/2
authorSerguei Smirnov <ssmirnov@whamcloud.com>
Thu, 30 May 2024 18:14:09 +0000 (11:14 -0700)
committerOleg Drokin <green@whamcloud.com>
Wed, 5 Jun 2024 04:45:51 +0000 (04:45 +0000)
Check that the port is in "privileged" range only if
kib_require_priv_port is set

Test-Parameters: trivial testlist=sanity-lnet
Fixes: 9b18afa ("LU-17743 ko2iblnd: move to struct lnet_nid")
Signed-off-by: Serguei Smirnov <ssmirnov@whamcloud.com>
Change-Id: I3ed9c174d983be68aecc4b8e12aaae7c096d26e8
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/55266
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Chris Horn <chris.horn@hpe.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
lnet/klnds/o2iblnd/o2iblnd_cb.c

index b05eb12..95d48f7 100644 (file)
@@ -2582,11 +2582,12 @@ kiblnd_passive_connect(struct rdma_cm_id *cmid, void *priv, int priv_nob)
                default:
                        break;
                }
-       }
-       if (port >= PROT_SOCK) {
-               CERROR("peer_ni's port (%pISc:%hu) is not privileged\n",
-                      &cmid->route.addr.dst_addr, port);
-               goto failed;
+
+               if (port >= PROT_SOCK) {
+                       CERROR("peer_ni's port (%pISc:%hu) is not privileged\n",
+                              &cmid->route.addr.dst_addr, port);
+                       goto failed;
+               }
        }
 
        if (priv_nob < offsetof(struct kib_msg, ibm_type)) {