Whamcloud - gitweb
LU-17000 lnet: don't assign unused return codes 08/53608/4
authorArshad Hussain <arshad.hussain@aeoncomputing.com>
Mon, 8 Jan 2024 09:02:24 +0000 (14:32 +0530)
committerOleg Drokin <green@whamcloud.com>
Sun, 4 Feb 2024 08:30:38 +0000 (08:30 +0000)
In lnet_peer_discovery() return from lnet_peer_ping_failed()
and lnet_peer_push_failed() is unused and return value of
former get quashed without getting used.

Remove rc assignment and cast function to void to make it
clear the return code can be ignored.

Test-Parameters: trivial
CoverityID: 412758 ("Unused Value")
CoverityID: 412759 ("Unused Value")
Signed-off-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Change-Id: I02d5e883fc02814d5dbe307b78f028703023db52
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/53608
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Chris Horn <chris.horn@hpe.com>
Reviewed-by: Timothy Day <timday@amazon.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
lnet/lnet/peer.c

index 4811fb0..540f7a7 100644 (file)
@@ -4146,9 +4146,9 @@ static int lnet_peer_discovery(void *arg)
                lnet_net_unlock(LNET_LOCK_EX);
                spin_lock(&lp->lp_lock);
                if (lp->lp_state & LNET_PEER_PING_FAILED)
-                       rc = lnet_peer_ping_failed(lp);
+                       (void)lnet_peer_ping_failed(lp);
                if (lp->lp_state & LNET_PEER_PUSH_FAILED)
-                       rc = lnet_peer_push_failed(lp);
+                       (void)lnet_peer_push_failed(lp);
                spin_unlock(&lp->lp_lock);
                lnet_net_lock(LNET_LOCK_EX);
                lnet_peer_discovery_complete(lp, -ESHUTDOWN);