Whamcloud - gitweb
git://git.whamcloud.com
/
fs
/
lustre-release.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3e9818c
)
- added a comment on a Darwin quirk.
author
isaac
<isaac>
Fri, 12 Sep 2008 14:11:32 +0000
(14:11 +0000)
committer
isaac
<isaac>
Fri, 12 Sep 2008 14:11:32 +0000
(14:11 +0000)
lnet/klnds/socklnd/socklnd_cb.c
patch
|
blob
|
history
diff --git
a/lnet/klnds/socklnd/socklnd_cb.c
b/lnet/klnds/socklnd/socklnd_cb.c
index
efec018
..
63ce0a8
100644
(file)
--- a/
lnet/klnds/socklnd/socklnd_cb.c
+++ b/
lnet/klnds/socklnd/socklnd_cb.c
@@
-761,10
+761,9
@@
ksocknal_queue_tx_locked (ksock_tx_t *tx, ksock_conn_t *conn)
tx->tx_conn = conn;
ksocknal_conn_addref(conn); /* +1 ref for tx */
- /*
- * NB Darwin: SOCK_WMEM_QUEUED()->sock_getsockopt() will take
- * a blockable lock(socket lock), so SOCK_WMEM_QUEUED can't be
- * put in spinlock.
+ /*
+ * FIXME: SOCK_WMEM_QUEUED and SOCK_ERROR could block in __DARWIN8__
+ * but they're used inside spinlocks a lot.
*/
bufnob = SOCK_WMEM_QUEUED(conn->ksnc_sock);
spin_lock_bh (&sched->kss_lock);