Whamcloud - gitweb
LU-8066 osp: migrate from proc to sysfs 77/32377/10
authorJames Simmons <uja.ornl@yahoo.com>
Wed, 11 Jul 2018 17:27:11 +0000 (13:27 -0400)
committerOleg Drokin <green@whamcloud.com>
Tue, 24 Jul 2018 16:00:16 +0000 (16:00 +0000)
Move the osp module from using proc for most single value files
to sysfs. Create the default attrs for dt_devices which can be
used for other server side devices.

Change-Id: I51fef51287585b38a1aff80d8edf986583c54a14
Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-on: https://review.whamcloud.com/32377
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Alex Zhuravlev <bzzz@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: John L. Hammond <jhammond@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/include/dt_object.h
lustre/include/obd.h
lustre/obdclass/dt_object.c
lustre/obdclass/lprocfs_status.c
lustre/osp/lproc_osp.c
lustre/osp/osp_dev.c
lustre/osp/osp_internal.h

index 6699d0f..88efa86 100644 (file)
@@ -1785,6 +1785,14 @@ struct dt_device {
        struct list_head                   dd_txn_callbacks;
        unsigned int                       dd_record_fid_accessed:1,
                                           dd_rdonly:1;
+
+       /* sysfs and debugfs handling */
+       struct dentry                     *dd_debugfs_entry;
+
+       const struct attribute           **dd_def_attrs;
+       struct kobject                     dd_kobj;
+       struct kobj_type                   dd_ktype;
+       struct completion                  dd_kobj_unregister;
 };
 
 int  dt_device_init(struct dt_device *dev, struct lu_device_type *t);
@@ -2820,6 +2828,9 @@ static inline struct dt_thread_info *dt_info(const struct lu_env *env)
 
 int dt_global_init(void);
 void dt_global_fini(void);
+int dt_tunables_init(struct dt_device *dt, struct obd_type *type,
+                    const char *name, struct lprocfs_vars *list);
+int dt_tunables_fini(struct dt_device *dt);
 
 # ifdef CONFIG_PROC_FS
 int lprocfs_dt_blksize_seq_show(struct seq_file *m, void *v);
index 80e4d72..ac69e6e 100644 (file)
@@ -711,8 +711,7 @@ struct obd_device {
        struct proc_dir_entry   *obd_proc_exports_entry;
        struct dentry                   *obd_svc_debugfs_entry;
        struct lprocfs_stats    *obd_svc_stats;
-       struct attribute_group           obd_attrs_group;
-       struct attribute               **obd_attrs;
+       const struct attribute         **obd_attrs;
        struct lprocfs_vars     *obd_vars;
        atomic_t                obd_evict_inprogress;
        wait_queue_head_t       obd_evict_inprogress_waitq;
index 6a8b50c..5a8241a 100644 (file)
@@ -40,7 +40,7 @@
 #define DEBUG_SUBSYSTEM S_CLASS
 
 #include <linux/list.h>
-#include <obd.h>
+#include <obd_class.h>
 #include <dt_object.h>
 /* fid_be_to_cpu() */
 #include <lustre_fid.h>
@@ -1096,3 +1096,220 @@ int lprocfs_dt_filesfree_seq_show(struct seq_file *m, void *v)
 EXPORT_SYMBOL(lprocfs_dt_filesfree_seq_show);
 
 #endif /* CONFIG_PROC_FS */
+
+static ssize_t uuid_show(struct kobject *kobj, struct attribute *attr,
+                        char *buf)
+{
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct lu_device *lu = dt2lu_dev(dt);
+
+       if (!lu->ld_obd)
+               return -ENODEV;
+
+       return sprintf(buf, "%s\n", lu->ld_obd->obd_uuid.uuid);
+}
+LUSTRE_RO_ATTR(uuid);
+
+static ssize_t blocksize_show(struct kobject *kobj, struct attribute *attr,
+                             char *buf)
+{
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct obd_statfs osfs;
+       int rc;
+
+       rc = dt_statfs(NULL, dt, &osfs);
+       if (rc)
+               return rc;
+
+       return sprintf(buf, "%u\n", (unsigned) osfs.os_bsize);
+}
+LUSTRE_RO_ATTR(blocksize);
+
+static ssize_t kbytestotal_show(struct kobject *kobj, struct attribute *attr,
+                               char *buf)
+{
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct obd_statfs osfs;
+       u32 blk_size;
+       u64 result;
+       int rc;
+
+       rc = dt_statfs(NULL, dt, &osfs);
+       if (rc)
+               return rc;
+
+       blk_size = osfs.os_bsize >> 10;
+       result = osfs.os_blocks;
+
+       while (blk_size >>= 1)
+               result <<= 1;
+
+       return sprintf(buf, "%llu\n", result);
+}
+LUSTRE_RO_ATTR(kbytestotal);
+
+static ssize_t kbytesfree_show(struct kobject *kobj, struct attribute *attr,
+                              char *buf)
+{
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct obd_statfs osfs;
+       u32 blk_size;
+       u64 result;
+       int rc;
+
+       rc = dt_statfs(NULL, dt, &osfs);
+       if (rc)
+               return rc;
+
+       blk_size = osfs.os_bsize >> 10;
+       result = osfs.os_bfree;
+
+       while (blk_size >>= 1)
+               result <<= 1;
+
+       return sprintf(buf, "%llu\n", result);
+}
+LUSTRE_RO_ATTR(kbytesfree);
+
+static ssize_t kbytesavail_show(struct kobject *kobj, struct attribute *attr,
+                               char *buf)
+{
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct obd_statfs osfs;
+       u32 blk_size;
+       u64 result;
+       int rc;
+
+       rc = dt_statfs(NULL, dt, &osfs);
+       if (rc)
+               return rc;
+
+       blk_size = osfs.os_bsize >> 10;
+       result = osfs.os_bavail;
+
+       while (blk_size >>= 1)
+               result <<= 1;
+
+       return sprintf(buf, "%llu\n", result);
+}
+LUSTRE_RO_ATTR(kbytesavail);
+
+static ssize_t filestotal_show(struct kobject *kobj, struct attribute *attr,
+                              char *buf)
+{
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct obd_statfs osfs;
+       int rc;
+
+       rc = dt_statfs(NULL, dt, &osfs);
+       if (rc)
+               return rc;
+
+       return sprintf(buf, "%llu\n", osfs.os_files);
+}
+LUSTRE_RO_ATTR(filestotal);
+
+static ssize_t filesfree_show(struct kobject *kobj, struct attribute *attr,
+                             char *buf)
+{
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct obd_statfs osfs;
+       int rc;
+
+       rc = dt_statfs(NULL, dt, &osfs);
+       if (rc)
+               return rc;
+
+       return sprintf(buf, "%llu\n", osfs.os_ffree);
+}
+LUSTRE_RO_ATTR(filesfree);
+
+static const struct attribute *dt_def_attrs[] = {
+       &lustre_attr_uuid.attr,
+       &lustre_attr_blocksize.attr,
+       &lustre_attr_kbytestotal.attr,
+       &lustre_attr_kbytesfree.attr,
+       &lustre_attr_kbytesavail.attr,
+       &lustre_attr_filestotal.attr,
+       &lustre_attr_filesfree.attr,
+       NULL,
+};
+
+static void dt_sysfs_release(struct kobject *kobj)
+{
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+
+       complete(&dt->dd_kobj_unregister);
+}
+
+int dt_tunables_fini(struct dt_device *dt)
+{
+       if (!dt)
+               return -EINVAL;
+
+       if (!IS_ERR_OR_NULL(dt->dd_debugfs_entry))
+               ldebugfs_remove(&dt->dd_debugfs_entry);
+
+       if (dt->dd_def_attrs)
+               sysfs_remove_files(&dt->dd_kobj, dt->dd_def_attrs);
+
+       kobject_put(&dt->dd_kobj);
+       wait_for_completion(&dt->dd_kobj_unregister);
+
+       return 0;
+}
+EXPORT_SYMBOL(dt_tunables_fini);
+
+int dt_tunables_init(struct dt_device *dt, struct obd_type *type,
+                    const char *name, struct lprocfs_vars *list)
+{
+       int rc;
+
+       dt->dd_ktype.sysfs_ops = &lustre_sysfs_ops;
+       dt->dd_ktype.release = dt_sysfs_release;
+
+       init_completion(&dt->dd_kobj_unregister);
+       rc = kobject_init_and_add(&dt->dd_kobj, &dt->dd_ktype, type->typ_kobj,
+                                 "%s", name);
+       if (rc)
+               return rc;
+
+       dt->dd_def_attrs = dt_def_attrs;
+
+       rc = sysfs_create_files(&dt->dd_kobj, dt->dd_def_attrs);
+       if (rc) {
+               kobject_put(&dt->dd_kobj);
+               return rc;
+       }
+
+       /* No need to register debugfs if no enteries. This allows us to
+        * choose between using dt_device or obd_device for debugfs.
+        */
+       if (!list)
+               return rc;
+
+       dt->dd_debugfs_entry = ldebugfs_register(name,
+                                                type->typ_debugfs_entry,
+                                                list, dt);
+       if (IS_ERR_OR_NULL(dt->dd_debugfs_entry)) {
+               rc = dt->dd_debugfs_entry ? PTR_ERR(dt->dd_debugfs_entry)
+                                         : -ENOMEM;
+               CERROR("%s: error %d setting up debugfs\n",
+                      name, rc);
+               dt->dd_debugfs_entry = NULL;
+               sysfs_remove_files(&dt->dd_kobj, dt->dd_def_attrs);
+               kobject_put(&dt->dd_kobj);
+               return rc;
+       }
+
+       return rc;
+}
+EXPORT_SYMBOL(dt_tunables_init);
index fbe115a..2ff79e6 100644 (file)
@@ -1184,12 +1184,12 @@ int lprocfs_connect_flags_seq_show(struct seq_file *m, void *data)
 }
 EXPORT_SYMBOL(lprocfs_connect_flags_seq_show);
 
-static struct attribute *obd_def_uuid_attrs[] = {
+static const struct attribute *obd_def_uuid_attrs[] = {
        &lustre_attr_uuid.attr,
        NULL,
 };
 
-static struct attribute *obd_def_attrs[] = {
+static const struct attribute *obd_def_attrs[] = {
        &lustre_attr_blocksize.attr,
        &lustre_attr_kbytestotal.attr,
        &lustre_attr_kbytesfree.attr,
@@ -1222,8 +1222,6 @@ int lprocfs_obd_setup(struct obd_device *obd, bool uuid_only)
 
        obd->obd_ktype.sysfs_ops = &lustre_sysfs_ops;
        obd->obd_ktype.release = obd_sysfs_release;
-       if (obd->obd_attrs)
-               obd->obd_ktype.default_attrs = obd->obd_attrs;
 
        obd->obd_kset.kobj.parent = obd->obd_type->typ_kobj;
        obd->obd_kset.kobj.ktype = &obd->obd_ktype;
@@ -1233,11 +1231,11 @@ int lprocfs_obd_setup(struct obd_device *obd, bool uuid_only)
                return rc;
 
        if (uuid_only)
-               obd->obd_attrs_group.attrs = obd_def_uuid_attrs;
+               obd->obd_attrs = obd_def_uuid_attrs;
        else
-               obd->obd_attrs_group.attrs = obd_def_attrs;
+               obd->obd_attrs = obd_def_attrs;
 
-       rc = sysfs_create_group(&obd->obd_kset.kobj, &obd->obd_attrs_group);
+       rc = sysfs_create_files(&obd->obd_kset.kobj, obd->obd_attrs);
        if (rc) {
                kset_unregister(&obd->obd_kset);
                return rc;
@@ -1254,7 +1252,10 @@ int lprocfs_obd_setup(struct obd_device *obd, bool uuid_only)
                CERROR("error %d setting up debugfs for %s\n",
                       rc, obd->obd_name);
                obd->obd_debugfs_entry = NULL;
-               lprocfs_obd_cleanup(obd);
+
+               sysfs_remove_files(&obd->obd_kset.kobj, obd->obd_attrs);
+               obd->obd_attrs = NULL;
+               kset_unregister(&obd->obd_kset);
                return rc;
        }
 
@@ -1268,7 +1269,12 @@ int lprocfs_obd_setup(struct obd_device *obd, bool uuid_only)
                rc = PTR_ERR(obd->obd_proc_entry);
                CERROR("error %d setting up lprocfs for %s\n",rc,obd->obd_name);
                obd->obd_proc_entry = NULL;
-               lprocfs_obd_cleanup(obd);
+
+               ldebugfs_remove(&obd->obd_debugfs_entry);
+               sysfs_remove_files(&obd->obd_kset.kobj, obd->obd_attrs);
+               obd->obd_attrs = NULL;
+               kset_unregister(&obd->obd_kset);
+               return rc;
        }
 already_registered:
        return rc;
@@ -1294,10 +1300,17 @@ int lprocfs_obd_cleanup(struct obd_device *obd)
        if (!IS_ERR_OR_NULL(obd->obd_debugfs_entry))
                ldebugfs_remove(&obd->obd_debugfs_entry);
 
-       sysfs_remove_group(&obd->obd_kset.kobj, &obd->obd_attrs_group);
+       /* obd device never allocated a kset */
+       if (!obd->obd_kset.kobj.state_initialized)
+               return 0;
+
+       if (obd->obd_attrs) {
+               sysfs_remove_files(&obd->obd_kset.kobj, obd->obd_attrs);
+               obd->obd_attrs = NULL;
+       }
+
        kset_unregister(&obd->obd_kset);
        wait_for_completion(&obd->obd_kobj_unregister);
-
        return 0;
 }
 EXPORT_SYMBOL(lprocfs_obd_cleanup);
index 03a03db..98ec193 100644 (file)
@@ -40,7 +40,6 @@
 
 #include "osp_internal.h"
 
-#ifdef CONFIG_PROC_FS
 /**
  * Show OSP active status
  *
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_active_seq_show(struct seq_file *m, void *data)
+static ssize_t active_show(struct kobject *kobj, struct attribute *attr,
+                          char *buf)
 {
-       struct obd_device       *dev = m->private;
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct lu_device *lu = dt2lu_dev(dt);
+       struct obd_device *obd = lu->ld_obd;
+       int rc;
 
-       LPROCFS_CLIMP_CHECK(dev);
-       seq_printf(m, "%d\n", !dev->u.cli.cl_import->imp_deactive);
-       LPROCFS_CLIMP_EXIT(dev);
-       return 0;
+       LPROCFS_CLIMP_CHECK(obd);
+       rc = sprintf(buf, "%d\n", !obd->u.cli.cl_import->imp_deactive);
+       LPROCFS_CLIMP_EXIT(obd);
+       return rc;
 }
 
 /**
@@ -69,31 +73,32 @@ static int osp_active_seq_show(struct seq_file *m, void *data)
  * \retval             \a count on success
  * \retval             negative number on error
  */
-static ssize_t
-osp_active_seq_write(struct file *file, const char __user *buffer,
-                       size_t count, loff_t *off)
+static ssize_t active_store(struct kobject *kobj, struct attribute *attr,
+                           const char *buffer, size_t count)
 {
-       struct seq_file *m = file->private_data;
-       struct obd_device *dev = m->private;
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct lu_device *lu = dt2lu_dev(dt);
+       struct obd_device *obd = lu->ld_obd;
        bool val;
        int rc;
 
-       rc = kstrtobool_from_user(buffer, count, &val);
+       rc = kstrtobool(buffer, &val);
        if (rc)
                return rc;
 
-       LPROCFS_CLIMP_CHECK(dev);
+       LPROCFS_CLIMP_CHECK(obd);
        /* opposite senses */
-       if (dev->u.cli.cl_import->imp_deactive == val)
-               rc = ptlrpc_set_import_active(dev->u.cli.cl_import, val);
+       if (obd->u.cli.cl_import->imp_deactive == val)
+               rc = ptlrpc_set_import_active(obd->u.cli.cl_import, val);
        else
-               CDEBUG(D_CONFIG, "activate %d: ignoring repeat request\n",
-                      val);
+               CDEBUG(D_CONFIG, "activate %u: ignoring repeat request\n",
+                      (unsigned int)val);
 
-       LPROCFS_CLIMP_EXIT(dev);
+       LPROCFS_CLIMP_EXIT(obd);
        return count;
 }
-LPROC_SEQ_FOPS(osp_active);
+LUSTRE_RW_ATTR(active);
 
 /**
  * Show number of RPCs in flight
@@ -103,18 +108,17 @@ LPROC_SEQ_FOPS(osp_active);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_sync_rpcs_in_flight_seq_show(struct seq_file *m, void *data)
+static ssize_t sync_in_flight_show(struct kobject *kobj,
+                                  struct attribute *attr,
+                                  char *buf)
 {
-       struct obd_device       *dev = m->private;
-       struct osp_device       *osp = lu2osp_dev(dev->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
 
-       if (osp == NULL)
-               return -EINVAL;
-
-       seq_printf(m, "%u\n", atomic_read(&osp->opd_sync_rpcs_in_flight));
-       return 0;
+       return sprintf(buf, "%u\n", atomic_read(&osp->opd_sync_rpcs_in_flight));
 }
-LPROC_SEQ_FOPS_RO(osp_sync_rpcs_in_flight);
+LUSTRE_RO_ATTR(sync_in_flight);
 
 /**
  * Show number of RPCs in processing (including uncommitted by OST)
@@ -124,18 +128,17 @@ LPROC_SEQ_FOPS_RO(osp_sync_rpcs_in_flight);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_sync_rpcs_in_progress_seq_show(struct seq_file *m, void *data)
+static ssize_t sync_in_progress_show(struct kobject *kobj,
+                                    struct attribute *attr,
+                                    char *buf)
 {
-       struct obd_device       *dev = m->private;
-       struct osp_device       *osp = lu2osp_dev(dev->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
 
-       if (osp == NULL)
-               return -EINVAL;
-
-       seq_printf(m, "%u\n", atomic_read(&osp->opd_sync_rpcs_in_progress));
-       return 0;
+       return sprintf(buf, "%u\n", atomic_read(&osp->opd_sync_rpcs_in_progress));
 }
-LPROC_SEQ_FOPS_RO(osp_sync_rpcs_in_progress);
+LUSTRE_RO_ATTR(sync_in_progress);
 
 /**
  * Show number of changes to sync
@@ -145,16 +148,15 @@ LPROC_SEQ_FOPS_RO(osp_sync_rpcs_in_progress);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_sync_changes_seq_show(struct seq_file *m, void *data)
+static ssize_t sync_changes_show(struct kobject *kobj,
+                                struct attribute *attr,
+                                char *buf)
 {
-       struct obd_device       *dev = m->private;
-       struct osp_device       *osp = lu2osp_dev(dev->obd_lu_dev);
-
-       if (osp == NULL)
-               return -EINVAL;
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
 
-       seq_printf(m, "%u\n", atomic_read(&osp->opd_sync_changes));
-       return 0;
+       return sprintf(buf, "%u\n", atomic_read(&osp->opd_sync_changes));
 }
 
 /**
@@ -167,15 +169,14 @@ static int osp_sync_changes_seq_show(struct seq_file *m, void *data)
  * \retval             \a count on success
  * \retval             negative number on error
  */
-static ssize_t osp_sync_changes_seq_write(struct file *file,
-                                        const char __user *buffer,
-                                        size_t count, loff_t *off)
+static ssize_t sync_changes_store(struct kobject *kobj, struct attribute *attr,
+                                 const char *buffer, size_t count)
 {
-       struct seq_file         *m      = file->private_data;
-       struct obd_device       *dev    = m->private;
-       struct osp_device       *osp    = lu2osp_dev(dev->obd_lu_dev);
-       struct lu_env            env;
-       int                      rc;
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
+       struct lu_env env;
+       int rc;
 
        rc = lu_env_init(&env, LCT_LOCAL);
        if (rc != 0)
@@ -186,7 +187,7 @@ static ssize_t osp_sync_changes_seq_write(struct file *file,
 
        return rc == 0 ? count : rc;
 }
-LPROC_SEQ_FOPS(osp_sync_changes);
+LUSTRE_RW_ATTR(sync_changes);
 
 /**
  * Show maximum number of RPCs in flight allowed
@@ -196,16 +197,15 @@ LPROC_SEQ_FOPS(osp_sync_changes);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_max_rpcs_in_flight_seq_show(struct seq_file *m, void *data)
+static ssize_t max_rpcs_in_flight_show(struct kobject *kobj,
+                                      struct attribute *attr,
+                                      char *buf)
 {
-       struct obd_device       *dev = m->private;
-       struct osp_device       *osp = lu2osp_dev(dev->obd_lu_dev);
-
-       if (osp == NULL)
-               return -EINVAL;
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
 
-       seq_printf(m, "%u\n", osp->opd_sync_max_rpcs_in_flight);
-       return 0;
+       return sprintf(buf, "%u\n", osp->opd_sync_max_rpcs_in_flight);
 }
 
 /**
@@ -218,20 +218,18 @@ static int osp_max_rpcs_in_flight_seq_show(struct seq_file *m, void *data)
  * \retval             \a count on success
  * \retval             negative number on error
  */
-static ssize_t
-osp_max_rpcs_in_flight_seq_write(struct file *file, const char __user *buffer,
-                               size_t count, loff_t *off)
+static ssize_t max_rpcs_in_flight_store(struct kobject *kobj,
+                                       struct attribute *attr,
+                                       const char *buffer,
+                                       size_t count)
 {
-       struct seq_file *m = file->private_data;
-       struct obd_device *dev = m->private;
-       struct osp_device *osp = lu2osp_dev(dev->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
        unsigned int val;
        int rc;
 
-       if (osp == NULL)
-               return -EINVAL;
-
-       rc = kstrtouint_from_user(buffer, count, 0, &val);
+       rc = kstrtouint(buffer, 0, &val);
        if (rc)
                return rc;
 
@@ -241,7 +239,7 @@ osp_max_rpcs_in_flight_seq_write(struct file *file, const char __user *buffer,
        osp->opd_sync_max_rpcs_in_flight = val;
        return count;
 }
-LPROC_SEQ_FOPS(osp_max_rpcs_in_flight);
+LUSTRE_RW_ATTR(max_rpcs_in_flight);
 
 /**
  * Show maximum number of RPCs in processing allowed
@@ -251,16 +249,15 @@ LPROC_SEQ_FOPS(osp_max_rpcs_in_flight);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_max_rpcs_in_progress_seq_show(struct seq_file *m, void *data)
+static ssize_t max_rpcs_in_progress_show(struct kobject *kobj,
+                                        struct attribute *attr,
+                                        char *buf)
 {
-       struct obd_device       *dev = m->private;
-       struct osp_device       *osp = lu2osp_dev(dev->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
 
-       if (osp == NULL)
-               return -EINVAL;
-
-       seq_printf(m, "%u\n", osp->opd_sync_max_rpcs_in_progress);
-       return 0;
+       return sprintf(buf, "%u\n", osp->opd_sync_max_rpcs_in_progress);
 }
 
 /**
@@ -273,20 +270,18 @@ static int osp_max_rpcs_in_progress_seq_show(struct seq_file *m, void *data)
  * \retval             \a count on success
  * \retval             negative number on error
  */
-static ssize_t
-osp_max_rpcs_in_progress_seq_write(struct file *file, const char __user *buffer,
-                                  size_t count, loff_t *off)
+static ssize_t max_rpcs_in_progress_store(struct kobject *kobj,
+                                         struct attribute *attr,
+                                         const char *buffer,
+                                         size_t count)
 {
-       struct seq_file *m = file->private_data;
-       struct obd_device *dev = m->private;
-       struct osp_device *osp = lu2osp_dev(dev->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
        unsigned int val;
        int rc;
 
-       if (osp == NULL)
-               return -EINVAL;
-
-       rc = kstrtouint_from_user(buffer, count, 0, &val);
+       rc = kstrtouint(buffer, 0, &val);
        if (rc)
                return rc;
 
@@ -297,7 +292,7 @@ osp_max_rpcs_in_progress_seq_write(struct file *file, const char __user *buffer,
 
        return count;
 }
-LPROC_SEQ_FOPS(osp_max_rpcs_in_progress);
+LUSTRE_RW_ATTR(max_rpcs_in_progress);
 
 /**
  * Show number of objects to precreate next time
@@ -307,16 +302,18 @@ LPROC_SEQ_FOPS(osp_max_rpcs_in_progress);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_create_count_seq_show(struct seq_file *m, void *data)
+static ssize_t create_count_show(struct kobject *kobj,
+                                struct attribute *attr,
+                                char *buf)
 {
-       struct obd_device *obd = m->private;
-       struct osp_device *osp = lu2osp_dev(obd->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
 
-       if (osp == NULL || osp->opd_pre == NULL)
-               return 0;
+       if (!osp->opd_pre)
+               return -EINVAL;
 
-       seq_printf(m, "%d\n", osp->opd_pre_create_count);
-       return 0;
+       return sprintf(buf, "%d\n", osp->opd_pre_create_count);
 }
 
 /**
@@ -329,20 +326,20 @@ static int osp_create_count_seq_show(struct seq_file *m, void *data)
  * \retval             \a count on success
  * \retval             negative number on error
  */
-static ssize_t
-osp_create_count_seq_write(struct file *file, const char __user *buffer,
-                               size_t count, loff_t *off)
+static ssize_t create_count_store(struct kobject *kobj, struct attribute *attr,
+                                 const char *buffer, size_t count)
 {
-       struct seq_file *m = file->private_data;
-       struct obd_device *obd = m->private;
-       struct osp_device *osp = lu2osp_dev(obd->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
        unsigned int val;
        int rc, i;
 
-       if (osp == NULL || osp->opd_pre == NULL)
-               return 0;
+       if (!osp->opd_pre)
+               return -EINVAL;
+
 
-       rc = kstrtouint_from_user(buffer, count, 0, &val);
+       rc = kstrtouint(buffer, 0, &val);
        if (rc)
                return rc;
 
@@ -367,7 +364,7 @@ osp_create_count_seq_write(struct file *file, const char __user *buffer,
 
        return count;
 }
-LPROC_SEQ_FOPS(osp_create_count);
+LUSTRE_RW_ATTR(create_count);
 
 /**
  * Show maximum number of objects to precreate
@@ -377,16 +374,18 @@ LPROC_SEQ_FOPS(osp_create_count);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_max_create_count_seq_show(struct seq_file *m, void *data)
+static ssize_t max_create_count_show(struct kobject *kobj,
+                                    struct attribute *attr,
+                                    char *buf)
 {
-       struct obd_device *obd = m->private;
-       struct osp_device *osp = lu2osp_dev(obd->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
 
-       if (osp == NULL || osp->opd_pre == NULL)
-               return 0;
+       if (!osp->opd_pre)
+               return -EINVAL;
 
-       seq_printf(m, "%d\n", osp->opd_pre_max_create_count);
-       return 0;
+       return sprintf(buf, "%d\n", osp->opd_pre_max_create_count);
 }
 
 /**
@@ -399,20 +398,20 @@ static int osp_max_create_count_seq_show(struct seq_file *m, void *data)
  * \retval             \a count on success
  * \retval             negative number on error
  */
-static ssize_t
-osp_max_create_count_seq_write(struct file *file, const char __user *buffer,
-                               size_t count, loff_t *off)
+static ssize_t max_create_count_store(struct kobject *kobj,
+                                     struct attribute *attr,
+                                     const char *buffer, size_t count)
 {
-       struct seq_file *m = file->private_data;
-       struct obd_device *obd = m->private;
-       struct osp_device *osp = lu2osp_dev(obd->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
        unsigned int val;
        int rc;
 
-       if (osp == NULL || osp->opd_pre == NULL)
-               return 0;
+       if (!osp->opd_pre)
+               return -EINVAL;
 
-       rc = kstrtouint_from_user(buffer, count, 0, &val);
+       rc = kstrtouint(buffer, 0, &val);
        if (rc)
                return rc;
 
@@ -428,7 +427,7 @@ osp_max_create_count_seq_write(struct file *file, const char __user *buffer,
 
        return count;
 }
-LPROC_SEQ_FOPS(osp_max_create_count);
+LUSTRE_RW_ATTR(max_create_count);
 
 /**
  * Show last id to assign in creation
@@ -438,15 +437,18 @@ LPROC_SEQ_FOPS(osp_max_create_count);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_prealloc_next_id_seq_show(struct seq_file *m, void *data)
+static ssize_t prealloc_next_id_show(struct kobject *kobj,
+                                    struct attribute *attr,
+                                    char *buf)
 {
-       struct obd_device *obd = m->private;
-       struct osp_device *osp = lu2osp_dev(obd->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
        struct lu_fid *fid;
-       __u64 id;
+       u64 id;
 
-       if (osp == NULL || osp->opd_pre == NULL)
-               return 0;
+       if (!osp->opd_pre)
+               return -EINVAL;
 
        fid = &osp->opd_pre_used_fid;
        if (fid_is_idif(fid)) {
@@ -457,10 +459,9 @@ static int osp_prealloc_next_id_seq_show(struct seq_file *m, void *data)
                        1 : fid_oid(fid) + 1;
        }
 
-       seq_printf(m, "%llu\n", id);
-       return 0;
+       return sprintf(buf, "%llu\n", id);
 }
-LPROC_SEQ_FOPS_RO(osp_prealloc_next_id);
+LUSTRE_RO_ATTR(prealloc_next_id);
 
 /**
  * Show last created id OST reported
@@ -470,24 +471,28 @@ LPROC_SEQ_FOPS_RO(osp_prealloc_next_id);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_prealloc_last_id_seq_show(struct seq_file *m, void *data)
+
+static ssize_t prealloc_last_id_show(struct kobject *kobj,
+                                    struct attribute *attr,
+                                    char *buf)
 {
-       struct obd_device *obd = m->private;
-       struct osp_device *osp = lu2osp_dev(obd->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
        struct lu_fid *fid;
-       __u64 id;
+       u64 id;
+
+       if (!osp->opd_pre)
+               return -EINVAL;
 
-       if (osp == NULL || osp->opd_pre == NULL)
-               return 0;
        fid = &osp->opd_pre_last_created_fid;
        id = fid_is_idif(fid) ?
                         fid_idif_id(fid_seq(fid), fid_oid(fid), fid_ver(fid)) :
                         fid_oid(fid);
 
-       seq_printf(m, "%llu\n", id);
-       return 0;
+       return sprintf(buf, "%llu\n", id);
 }
-LPROC_SEQ_FOPS_RO(osp_prealloc_last_id);
+LUSTRE_RO_ATTR(prealloc_last_id);
 
 /**
  * Show next FID sequence to precreate
@@ -497,22 +502,23 @@ LPROC_SEQ_FOPS_RO(osp_prealloc_last_id);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_prealloc_next_seq_seq_show(struct seq_file *m, void *data)
+static ssize_t prealloc_next_seq_show(struct kobject *kobj,
+                                     struct attribute *attr,
+                                     char *buf)
 {
-       struct obd_device *obd = m->private;
-       struct osp_device *osp = lu2osp_dev(obd->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
        struct lu_fid *fid;
 
-       if (osp == NULL || osp->opd_pre == NULL)
-               return 0;
+       if (!osp->opd_pre)
+               return -EINVAL;
 
        fid = &osp->opd_pre_used_fid;
-       seq_printf(m, "%#llx\n", fid_is_idif(fid) ?
-                  fid_seq(fid) & (~0xffff) : fid_seq(fid));
-
-       return 0;
+       return sprintf(buf, "%#llx\n", fid_is_idif(fid) ?
+                      fid_seq(fid) & (~0xffff) : fid_seq(fid));
 }
-LPROC_SEQ_FOPS_RO(osp_prealloc_next_seq);
+LUSTRE_RO_ATTR(prealloc_next_seq);
 
 /**
  * Show last created FID sequence OST reported
@@ -522,22 +528,23 @@ LPROC_SEQ_FOPS_RO(osp_prealloc_next_seq);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_prealloc_last_seq_seq_show(struct seq_file *m, void *data)
+static ssize_t prealloc_last_seq_show(struct kobject *kobj,
+                                     struct attribute *attr,
+                                     char *buf)
 {
-       struct obd_device *obd = m->private;
-       struct osp_device *osp = lu2osp_dev(obd->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
        struct lu_fid *fid;
 
-       if (osp == NULL || osp->opd_pre == NULL)
-               return 0;
+       if (!osp->opd_pre)
+               return -EINVAL;
 
        fid = &osp->opd_pre_last_created_fid;
-       seq_printf(m, "%#llx\n", fid_is_idif(fid) ?
-                  fid_seq(fid) & (~0xffff) : fid_seq(fid));
-
-       return 0;
+       return sprintf(buf, "%#llx\n", fid_is_idif(fid) ?
+                      fid_seq(fid) & (~0xffff) : fid_seq(fid));
 }
-LPROC_SEQ_FOPS_RO(osp_prealloc_last_seq);
+LUSTRE_RO_ATTR(prealloc_last_seq);
 
 /**
  * Show the number of ids reserved by declare
@@ -547,18 +554,20 @@ LPROC_SEQ_FOPS_RO(osp_prealloc_last_seq);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_prealloc_reserved_seq_show(struct seq_file *m, void *data)
+static ssize_t prealloc_reserved_show(struct kobject *kobj,
+                                     struct attribute *attr,
+                                     char *buf)
 {
-       struct obd_device *obd = m->private;
-       struct osp_device *osp = lu2osp_dev(obd->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
 
-       if (osp == NULL || osp->opd_pre == NULL)
-               return 0;
+       if (!osp->opd_pre)
+               return -EINVAL;
 
-       seq_printf(m, "%llu\n", osp->opd_pre_reserved);
-       return 0;
+       return sprintf(buf, "%llu\n", osp->opd_pre_reserved);
 }
-LPROC_SEQ_FOPS_RO(osp_prealloc_reserved);
+LUSTRE_RO_ATTR(prealloc_reserved);
 
 /**
  * Show interval (in seconds) to update statfs data
@@ -568,16 +577,15 @@ LPROC_SEQ_FOPS_RO(osp_prealloc_reserved);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_maxage_seq_show(struct seq_file *m, void *data)
+static ssize_t maxage_show(struct kobject *kobj,
+                          struct attribute *attr,
+                          char *buf)
 {
-       struct obd_device       *dev = m->private;
-       struct osp_device       *osp = lu2osp_dev(dev->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
 
-       if (osp == NULL)
-               return -EINVAL;
-
-       seq_printf(m, "%lld\n", osp->opd_statfs_maxage);
-       return 0;
+       return sprintf(buf, "%lld\n", osp->opd_statfs_maxage);
 }
 
 /**
@@ -590,20 +598,16 @@ static int osp_maxage_seq_show(struct seq_file *m, void *data)
  * \retval             \a count on success
  * \retval             negative number on error
  */
-static ssize_t
-osp_maxage_seq_write(struct file *file, const char __user *buffer,
-                       size_t count, loff_t *off)
+static ssize_t maxage_store(struct kobject *kobj, struct attribute *attr,
+                           const char *buffer, size_t count)
 {
-       struct seq_file *m = file->private_data;
-       struct obd_device *dev = m->private;
-       struct osp_device *osp = lu2osp_dev(dev->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
        unsigned int val;
        int rc;
 
-       if (osp == NULL)
-               return -EINVAL;
-
-       rc = kstrtouint_from_user(buffer, count, 0, &val);
+       rc = kstrtouint(buffer, 0, &val);
        if (rc)
                return rc;
 
@@ -614,7 +618,7 @@ osp_maxage_seq_write(struct file *file, const char __user *buffer,
 
        return count;
 }
-LPROC_SEQ_FOPS(osp_maxage);
+LUSTRE_RW_ATTR(maxage);
 
 /**
  * Show current precreation status: output 0 means success, otherwise negative
@@ -625,18 +629,20 @@ LPROC_SEQ_FOPS(osp_maxage);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_pre_status_seq_show(struct seq_file *m, void *data)
+static ssize_t prealloc_status_show(struct kobject *kobj,
+                                   struct attribute *attr,
+                                   char *buf)
 {
-       struct obd_device       *dev = m->private;
-       struct osp_device       *osp = lu2osp_dev(dev->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
 
-       if (osp == NULL || osp->opd_pre == NULL)
+       if (!osp->opd_pre)
                return -EINVAL;
 
-       seq_printf(m, "%d\n", osp->opd_pre_status);
-       return 0;
+       return sprintf(buf, "%d\n", osp->opd_pre_status);
 }
-LPROC_SEQ_FOPS_RO(osp_pre_status);
+LUSTRE_RO_ATTR(prealloc_status);
 
 /**
  * Show the number of RPCs in processing (including uncommitted by OST) plus
@@ -653,20 +659,19 @@ LPROC_SEQ_FOPS_RO(osp_pre_status);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_destroys_in_flight_seq_show(struct seq_file *m, void *data)
+static ssize_t destroys_in_flight_show(struct kobject *kobj,
+                                      struct attribute *attr,
+                                      char *buf)
 {
-       struct obd_device *dev = m->private;
-       struct osp_device *osp = lu2osp_dev(dev->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
 
-       if (osp == NULL)
-               return -EINVAL;
-
-       seq_printf(m, "%u\n",
-                  atomic_read(&osp->opd_sync_rpcs_in_progress) +
-                  atomic_read(&osp->opd_sync_changes));
-       return 0;
+       return sprintf(buf, "%u\n",
+                      atomic_read(&osp->opd_sync_rpcs_in_progress) +
+                      atomic_read(&osp->opd_sync_changes));
 }
-LPROC_SEQ_FOPS_RO(osp_destroys_in_flight);
+LUSTRE_RO_ATTR(destroys_in_flight);
 
 /**
  * Show changes synced from previous mount
@@ -676,18 +681,17 @@ LPROC_SEQ_FOPS_RO(osp_destroys_in_flight);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int osp_old_sync_processed_seq_show(struct seq_file *m, void *data)
+static ssize_t old_sync_processed_show(struct kobject *kobj,
+                                      struct attribute *attr,
+                                      char *buf)
 {
-       struct obd_device       *dev = m->private;
-       struct osp_device       *osp = lu2osp_dev(dev->obd_lu_dev);
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct osp_device *osp = dt2osp_dev(dt);
 
-       if (osp == NULL)
-               return -EINVAL;
-
-       seq_printf(m, "%d\n", osp->opd_sync_prev_done);
-       return 0;
+       return sprintf(buf, "%d\n", osp->opd_sync_prev_done);
 }
-LPROC_SEQ_FOPS_RO(osp_old_sync_processed);
+LUSTRE_RO_ATTR(old_sync_processed);
 
 /**
  * Show maximum number of RPCs in flight
@@ -697,15 +701,18 @@ LPROC_SEQ_FOPS_RO(osp_old_sync_processed);
  * \retval             0 on success
  * \retval             negative number on error
  */
-static int
-osp_lfsck_max_rpcs_in_flight_seq_show(struct seq_file *m, void *data)
+static ssize_t lfsck_max_rpcs_in_flight_show(struct kobject *kobj,
+                                            struct attribute *attr,
+                                            char *buf)
 {
-       struct obd_device *dev = m->private;
-       __u32 max;
-
-       max = obd_get_max_rpcs_in_flight(&dev->u.cli);
-       seq_printf(m, "%u\n", max);
-       return 0;
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct lu_device *lu = dt2lu_dev(dt);
+       struct obd_device *obd = lu->ld_obd;
+       u32 max;
+
+       max = obd_get_max_rpcs_in_flight(&obd->u.cli);
+       return sprintf(buf, "%u\n", max);
 }
 
 /**
@@ -718,35 +725,52 @@ osp_lfsck_max_rpcs_in_flight_seq_show(struct seq_file *m, void *data)
  * \retval             \a count on success
  * \retval             negative number on error
  */
-static ssize_t
-osp_lfsck_max_rpcs_in_flight_seq_write(struct file *file,
-                                      const char __user *buffer,
-                                      size_t count, loff_t *off)
+static ssize_t lfsck_max_rpcs_in_flight_store(struct kobject *kobj,
+                                             struct attribute *attr,
+                                             const char *buffer,
+                                             size_t count)
 {
-       struct seq_file   *m = file->private_data;
-       struct obd_device *dev = m->private;
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct lu_device *lu = dt2lu_dev(dt);
+       struct obd_device *obd = lu->ld_obd;
        unsigned int val;
        int rc;
 
-       rc = kstrtouint_from_user(buffer, count, 0, &val);
-       if (!rc)
-               rc = obd_set_max_rpcs_in_flight(&dev->u.cli, val);
-       else
-               count = rc;
+       rc = kstrtouint(buffer, 0, &val);
+       if (rc)
+               return rc;
 
-       return count;
+       rc = obd_set_max_rpcs_in_flight(&obd->u.cli, val);
+       return rc ? rc : count;
 }
-LPROC_SEQ_FOPS(osp_lfsck_max_rpcs_in_flight);
+LUSTRE_RW_ATTR(lfsck_max_rpcs_in_flight);
 
-LPROC_SEQ_FOPS_WR_ONLY(osp, ping);
-LPROC_SEQ_FOPS_RO_TYPE(osp, connect_flags);
-LPROC_SEQ_FOPS_RO_TYPE(osp, server_uuid);
-LPROC_SEQ_FOPS_RO_TYPE(osp, conn_uuid);
+ssize_t ping_show(struct kobject *kobj, struct attribute *attr,
+                 char *buffer)
+{
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct lu_device *lu = dt2lu_dev(dt);
+       struct obd_device *obd = lu->ld_obd;
+       int rc;
+
+       LPROCFS_CLIMP_CHECK(obd);
+       rc = ptlrpc_obd_ping(obd);
+       LPROCFS_CLIMP_EXIT(obd);
+
+       return rc;
+}
+LUSTRE_RO_ATTR(ping);
 
-LPROC_SEQ_FOPS_RO_TYPE(osp, timeouts);
+LDEBUGFS_SEQ_FOPS_RO_TYPE(osp, connect_flags);
+LDEBUGFS_SEQ_FOPS_RO_TYPE(osp, server_uuid);
+LDEBUGFS_SEQ_FOPS_RO_TYPE(osp, conn_uuid);
+
+LDEBUGFS_SEQ_FOPS_RO_TYPE(osp, timeouts);
 
 LPROC_SEQ_FOPS_RW_TYPE(osp, import);
-LPROC_SEQ_FOPS_RO_TYPE(osp, state);
+LDEBUGFS_SEQ_FOPS_RO_TYPE(osp, state);
 
 /**
  * Show high watermark (in megabytes). If available free space at OST is grater
@@ -807,7 +831,7 @@ osp_reserved_mb_high_seq_write(struct file *file, const char __user *buffer,
 
        return count;
 }
-LPROC_SEQ_FOPS(osp_reserved_mb_high);
+LDEBUGFS_SEQ_FOPS(osp_reserved_mb_high);
 
 /**
  * Show low watermark (in megabytes). If available free space at OST is less
@@ -866,150 +890,102 @@ osp_reserved_mb_low_seq_write(struct file *file, const char __user *buffer,
 
        return count;
 }
-LPROC_SEQ_FOPS(osp_reserved_mb_low);
+LDEBUGFS_SEQ_FOPS(osp_reserved_mb_low);
 
-static ssize_t
-lprocfs_force_sync_seq_write(struct file *file, const char __user *buffer,
-                            size_t count, loff_t *off)
+static ssize_t force_sync_store(struct kobject *kobj, struct attribute *attr,
+                               const char *buffer, size_t count)
 {
-       struct seq_file   *m = file->private_data;
-       struct obd_device *dev = m->private;
-       struct dt_device  *dt = lu2dt_dev(dev->obd_lu_dev);
-       struct lu_env      env;
-       int                rc;
+       struct dt_device *dt = container_of(kobj, struct dt_device,
+                                           dd_kobj);
+       struct lu_env env;
+       int rc;
 
        rc = lu_env_init(&env, LCT_LOCAL);
        if (rc)
                return rc;
+
        rc = dt_sync(&env, dt);
        lu_env_fini(&env);
 
        return rc == 0 ? count : rc;
 }
-LPROC_SEQ_FOPS_WR_ONLY(osp, force_sync);
+LUSTRE_WO_ATTR(force_sync);
 
 static struct lprocfs_vars lprocfs_osp_obd_vars[] = {
-       { .name =       "ping",
-         .fops =       &osp_ping_fops,
-         .proc_mode =  0222                            },
        { .name =       "connect_flags",
          .fops =       &osp_connect_flags_fops         },
        { .name =       "ost_server_uuid",
          .fops =       &osp_server_uuid_fops           },
        { .name =       "ost_conn_uuid",
          .fops =       &osp_conn_uuid_fops             },
-       { .name =       "active",
-         .fops =       &osp_active_fops                },
-       { .name =       "max_rpcs_in_flight",
-         .fops =       &osp_max_rpcs_in_flight_fops    },
-       { .name =       "max_rpcs_in_progress",
-         .fops =       &osp_max_rpcs_in_progress_fops  },
-       { .name =       "create_count",
-         .fops =       &osp_create_count_fops          },
-       { .name =       "max_create_count",
-         .fops =       &osp_max_create_count_fops      },
-       { .name =       "prealloc_next_id",
-         .fops =       &osp_prealloc_next_id_fops      },
-       { .name =       "prealloc_next_seq",
-         .fops =       &osp_prealloc_next_seq_fops     },
-       { .name =       "prealloc_last_id",
-         .fops =       &osp_prealloc_last_id_fops      },
-       { .name =       "prealloc_last_seq",
-         .fops =       &osp_prealloc_last_seq_fops     },
-       { .name =       "prealloc_reserved",
-         .fops =       &osp_prealloc_reserved_fops     },
        { .name =       "timeouts",
          .fops =       &osp_timeouts_fops              },
        { .name =       "import",
          .fops =       &osp_import_fops                },
        { .name =       "state",
          .fops =       &osp_state_fops                 },
-       { .name =       "maxage",
-         .fops =       &osp_maxage_fops                },
-       { .name =       "prealloc_status",
-         .fops =       &osp_pre_status_fops            },
-       { .name =       "sync_changes",
-         .fops =       &osp_sync_changes_fops          },
-       { .name =       "sync_in_flight",
-         .fops =       &osp_sync_rpcs_in_flight_fops   },
-       { .name =       "sync_in_progress",
-         .fops =       &osp_sync_rpcs_in_progress_fops },
-       { .name =       "old_sync_processed",
-         .fops =       &osp_old_sync_processed_fops    },
        { .name =       "reserved_mb_high",
          .fops =       &osp_reserved_mb_high_fops      },
        { .name =       "reserved_mb_low",
          .fops =       &osp_reserved_mb_low_fops       },
-       { .name =       "force_sync",
-         .fops =       &osp_force_sync_fops    },
-
-       /* for compatibility reasons */
-       { .name =       "destroys_in_flight",
-         .fops =       &osp_destroys_in_flight_fops            },
-       { .name =       "lfsck_max_rpcs_in_flight",
-         .fops =       &osp_lfsck_max_rpcs_in_flight_fops      },
        { NULL }
 };
 
 static struct lprocfs_vars lprocfs_osp_md_vars[] = {
-       { .name =       "ping",
-         .fops =       &osp_ping_fops,
-         .proc_mode =  0222                            },
        { .name =       "connect_flags",
          .fops =       &osp_connect_flags_fops         },
        { .name =       "mdt_server_uuid",
          .fops =       &osp_server_uuid_fops           },
        { .name =       "mdt_conn_uuid",
          .fops =       &osp_conn_uuid_fops             },
-       { .name =       "active",
-         .fops =       &osp_active_fops                },
-       { .name =       "max_rpcs_in_flight",
-         .fops =       &osp_max_rpcs_in_flight_fops    },
-       { .name =       "max_rpcs_in_progress",
-         .fops =       &osp_max_rpcs_in_progress_fops  },
        { .name =       "timeouts",
          .fops =       &osp_timeouts_fops              },
        { .name =       "import",
          .fops =       &osp_import_fops                },
        { .name =       "state",
          .fops =       &osp_state_fops                 },
-       { .name =       "maxage",
-         .fops =       &osp_maxage_fops                },
-       { .name =       "prealloc_status",
-         .fops =       &osp_pre_status_fops            },
-
-       /* for compatibility reasons */
-       { .name =       "destroys_in_flight",
-         .fops =       &osp_destroys_in_flight_fops            },
-       { .name =       "lfsck_max_rpcs_in_flight",
-         .fops =       &osp_lfsck_max_rpcs_in_flight_fops      },
        { NULL }
 };
 
-LPROC_SEQ_FOPS_RO_TYPE(osp, dt_blksize);
-LPROC_SEQ_FOPS_RO_TYPE(osp, dt_kbytestotal);
-LPROC_SEQ_FOPS_RO_TYPE(osp, dt_kbytesfree);
-LPROC_SEQ_FOPS_RO_TYPE(osp, dt_kbytesavail);
-LPROC_SEQ_FOPS_RO_TYPE(osp, dt_filestotal);
-LPROC_SEQ_FOPS_RO_TYPE(osp, dt_filesfree);
-
-static struct lprocfs_vars lprocfs_osp_osd_vars[] = {
-       { .name =       "blocksize",
-         .fops =       &osp_dt_blksize_fops            },
-       { .name =       "kbytestotal",
-         .fops =       &osp_dt_kbytestotal_fops        },
-       { .name =       "kbytesfree",
-         .fops =       &osp_dt_kbytesfree_fops         },
-       { .name =       "kbytesavail",
-         .fops =       &osp_dt_kbytesavail_fops        },
-       { .name =       "filestotal",
-         .fops =       &osp_dt_filestotal_fops         },
-       { .name =       "filesfree",
-         .fops =       &osp_dt_filesfree_fops          },
-       { NULL }
+static struct attribute *osp_obd_attrs[] = {
+       /* First two for compatiability reasons */
+       &lustre_attr_lfsck_max_rpcs_in_flight.attr,
+       &lustre_attr_destroys_in_flight.attr,
+       &lustre_attr_active.attr,
+       &lustre_attr_max_rpcs_in_flight.attr,
+       &lustre_attr_max_rpcs_in_progress.attr,
+       &lustre_attr_maxage.attr,
+       &lustre_attr_ping.attr,
+       &lustre_attr_prealloc_status.attr,
+       &lustre_attr_prealloc_next_id.attr,
+       &lustre_attr_prealloc_last_id.attr,
+       &lustre_attr_prealloc_next_seq.attr,
+       &lustre_attr_prealloc_last_seq.attr,
+       &lustre_attr_prealloc_reserved.attr,
+       &lustre_attr_sync_in_flight.attr,
+       &lustre_attr_sync_in_progress.attr,
+       &lustre_attr_sync_changes.attr,
+       &lustre_attr_force_sync.attr,
+       &lustre_attr_old_sync_processed.attr,
+       &lustre_attr_create_count.attr,
+       &lustre_attr_max_create_count.attr,
+       NULL,
+};
+
+static struct attribute *osp_md_attrs[] = {
+       /* First two for compatiability reasons */
+       &lustre_attr_lfsck_max_rpcs_in_flight.attr,
+       &lustre_attr_destroys_in_flight.attr,
+       &lustre_attr_active.attr,
+       &lustre_attr_max_rpcs_in_flight.attr,
+       &lustre_attr_max_rpcs_in_progress.attr,
+       &lustre_attr_maxage.attr,
+       &lustre_attr_ping.attr,
+       &lustre_attr_prealloc_status.attr,
+       NULL,
 };
 
-void osp_lprocfs_fini(struct osp_device *osp)
+void osp_tunables_fini(struct osp_device *osp)
 {
        struct obd_device *obd = osp->opd_obd;
        struct kobject *osc;
@@ -1024,35 +1000,53 @@ void osp_lprocfs_fini(struct osp_device *osp)
                ldebugfs_remove(&osp->opd_debugfs);
 
        ptlrpc_lprocfs_unregister_obd(obd);
-       if (osp->opd_symlink)
-               lprocfs_remove(&osp->opd_symlink);
+
+       if (!IS_ERR_OR_NULL(obd->obd_debugfs_entry))
+               ldebugfs_remove(&obd->obd_debugfs_entry);
+
+       dt_tunables_fini(&osp->opd_dt_dev);
 }
 
 /**
- * Initialize OSP lprocfs
+ * Initialize OSP sysfs / debugfs
  *
  * param[in] osp       OSP device
  */
-void osp_lprocfs_init(struct osp_device *osp)
+void osp_tunables_init(struct osp_device *osp)
 {
        struct obd_device *obd = osp->opd_obd;
-       struct proc_dir_entry *osc_proc_dir = NULL;
-       struct obd_type *type;
        struct kobject *osc;
        int rc;
 
-       if (osp->opd_connect_mdt)
+       if (osp->opd_connect_mdt) {
+               osp->opd_dt_dev.dd_ktype.default_attrs = osp_md_attrs;
                obd->obd_vars = lprocfs_osp_md_vars;
-       else
+       } else {
+               osp->opd_dt_dev.dd_ktype.default_attrs = osp_obd_attrs;
                obd->obd_vars = lprocfs_osp_obd_vars;
-       if (lprocfs_obd_setup(obd, true) != 0)
-               return;
+       }
 
-       rc = lprocfs_add_vars(obd->obd_proc_entry, lprocfs_osp_osd_vars,
-                             &osp->opd_dt_dev);
+       rc = dt_tunables_init(&osp->opd_dt_dev, obd->obd_type, obd->obd_name,
+                             NULL);
        if (rc) {
-               CERROR("%s: can't register in lprocfs, rc %d\n",
+               CERROR("%s: failed to setup DT tunables: %d\n",
+                      obd->obd_name, rc);
+               return;
+       }
+
+       /* Since we register the obd device with ptlrpc / sptlrpc we
+        * have to register debugfs with obd_device
+        */
+       obd->obd_debugfs_entry = ldebugfs_register(obd->obd_name,
+                                                  obd->obd_type->typ_debugfs_entry,
+                                                  obd->obd_vars, obd);
+       if (IS_ERR_OR_NULL(obd->obd_debugfs_entry)) {
+               rc = obd->obd_debugfs_entry ? PTR_ERR(obd->obd_debugfs_entry)
+                                           : -ENOMEM;
+               CERROR("%s: error %d setting up debugfs\n",
                       obd->obd_name, rc);
+               obd->obd_debugfs_entry = NULL;
+               dt_tunables_fini(&osp->opd_dt_dev);
                return;
        }
 
@@ -1068,7 +1062,7 @@ void osp_lprocfs_init(struct osp_device *osp)
         */
        osc = kset_find_obj(lustre_kset, "osc");
        if (osc) {
-               rc = sysfs_create_link(osc, &obd->obd_kset.kobj,
+               rc = sysfs_create_link(osc, &osp->opd_dt_dev.dd_kobj,
                                       obd->obd_name);
                kobject_put(osc);
        }
@@ -1078,26 +1072,4 @@ void osp_lprocfs_init(struct osp_device *osp)
        if (!osp->opd_debugfs)
                CERROR("%s: failed to create OSC debugfs symlink\n",
                       obd->obd_name);
-
-       /* If the real OSC is present which is the case for setups
-        * with both server and clients on the same node then use
-        * the OSC's proc root */
-       type = class_search_type(LUSTRE_OSC_NAME);
-       if (type != NULL && type->typ_procroot != NULL)
-               osc_proc_dir = type->typ_procroot;
-       else
-               osc_proc_dir = obd->obd_type->typ_procsym;
-
-       if (osc_proc_dir == NULL)
-               return;
-
-       /* for compatibility we link old procfs's OSC entries to osp ones */
-       osp->opd_symlink = lprocfs_add_symlink(obd->obd_name, osc_proc_dir,
-                                              "../osp/%s", obd->obd_name);
-       if (osp->opd_symlink == NULL)
-               CERROR("cannot create OSC symlink for /proc/fs/lustre/osp/%s\n",
-                      obd->obd_name);
 }
-
-#endif /* CONFIG_PROC_FS */
-
index 33f03a4..b0dfd64 100644 (file)
@@ -636,9 +636,11 @@ static int osp_shutdown(const struct lu_env *env, struct osp_device *d)
 static int osp_process_config(const struct lu_env *env,
                              struct lu_device *dev, struct lustre_cfg *lcfg)
 {
-       struct osp_device               *d = lu2osp_dev(dev);
-       struct obd_device               *obd = d->opd_obd;
-       int                              rc;
+       struct osp_device *d = lu2osp_dev(dev);
+       struct dt_device *dt = lu2dt_dev(dev);
+       struct obd_device *obd = d->opd_obd;
+       ssize_t count;
+       int rc;
 
        ENTRY;
 
@@ -654,22 +656,20 @@ static int osp_process_config(const struct lu_env *env,
                rc = osp_shutdown(env, d);
                break;
        case LCFG_PARAM:
-               LASSERT(obd);
-               rc = class_process_proc_param(d->opd_connect_mdt ?
-                                             PARAM_OSP : PARAM_OSC,
-                                             obd->obd_vars, lcfg, obd);
-               if (rc > 0)
-                       rc = 0;
-               if (rc == -ENOSYS) {
-                       /* class_process_proc_param() haven't found matching
-                        * parameter and returned ENOSYS so that layer(s)
+               count = class_modify_config(lcfg, d->opd_connect_mdt ?
+                                                 PARAM_OSP : PARAM_OSC,
+                                           &dt->dd_kobj);
+               if (count < 0) {
+                       /* class_modify_config() haven't found matching
+                        * parameter and returned an error so that layer(s)
                         * below could use that. But OSP is the bottom, so
-                        * just ignore it */
+                        * just ignore it
+                        */
                        CERROR("%s: unknown param %s\n",
                               (char *)lustre_cfg_string(lcfg, 0),
                               (char *)lustre_cfg_string(lcfg, 1));
-                       rc = 0;
                }
+               rc = 0;
                break;
        default:
                CERROR("%s: unknown command %u\n",
@@ -1160,7 +1160,7 @@ static int osp_init0(const struct lu_env *env, struct osp_device *osp,
                GOTO(out_ref, rc);
        }
 
-       osp_lprocfs_init(osp);
+       osp_tunables_init(osp);
 
        rc = obd_fid_init(osp->opd_obd, NULL, osp->opd_connect_mdt ?
                          LUSTRE_SEQ_METADATA : LUSTRE_SEQ_DATA);
@@ -1232,7 +1232,7 @@ out_last_used:
 out_fid:
        obd_fid_fini(osp->opd_obd);
 out_proc:
-       osp_lprocfs_fini(osp);
+       osp_tunables_fini(osp);
        client_obd_cleanup(obd);
 out_ref:
        ptlrpcd_decref();
@@ -1347,7 +1347,7 @@ static struct lu_device *osp_device_fini(const struct lu_env *env,
        }
 
        LASSERT(osp->opd_obd);
-       osp_lprocfs_fini(osp);
+       osp_tunables_fini(osp);
 
        if (osp->opd_connect_mdt) {
                struct client_obd *cli = &osp->opd_obd->u.cli;
index a842528..9b052e8 100644 (file)
@@ -172,8 +172,6 @@ struct osp_device {
        struct obd_uuid                  opd_cluuid;
        struct obd_connect_data         *opd_connect_data;
        int                              opd_connects;
-       struct proc_dir_entry           *opd_proc_entry;
-       struct lprocfs_stats            *opd_stats;
        /* connection status. */
        unsigned int                     opd_new_connection:1,
                                         opd_got_disconnected:1,
@@ -249,7 +247,6 @@ struct osp_device {
        /* how often to update statfs data */
        time64_t                         opd_statfs_maxage;
 
-       struct proc_dir_entry           *opd_symlink;
        struct dentry                   *opd_debugfs;
 
        /* If the caller wants to do some idempotent async operations on
@@ -805,8 +802,8 @@ int osp_write_last_oid_seq_files(struct lu_env *env, struct osp_device *osp,
 int osp_init_pre_fid(struct osp_device *osp);
 
 /* lproc_osp.c */
-void osp_lprocfs_init(struct osp_device *osp);
-void osp_lprocfs_fini(struct osp_device *osp);
+void osp_tunables_init(struct osp_device *osp);
+void osp_tunables_fini(struct osp_device *osp);
 
 /* osp_sync.c */
 int osp_sync_declare_add(const struct lu_env *env, struct osp_object *o,