LU-7025 lfsck: Invalid return value assignment

In lfsck_layout_scan_stripes(), the following code section:
                if (lso == NULL) {
                        struct lu_attr *attr = &info->lti_la;

                        rc = dt_attr_get(env, parent, attr);
                        if (rc != 0) {
                                rc = PTR_ERR(lso);
                                goto next;
                        }
                        ...
                }
When dt_attr_get() returns failure, we should NOT assign the
"rc" as "PTR_ERR(lso)", instead, just use the current "rc".

Signed-off-by: Fan Yong <fan.yong@intel.com>
Change-Id: I8237e1f79588b54c73398f20bd833e81787bf4a6
Reviewed-on: http://review.whamcloud.com/16042
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>

diff --git a/lustre/lfsck/lfsck_layout.c b/lustre/lfsck/lfsck_layout.c
index 5dcd285..5d3c510 100644 (file)
--- a/lustre/lfsck/lfsck_layout.c
+++ b/lustre/lfsck/lfsck_layout.c
@@ -4274,10 +4274,8 @@ static int lfsck_layout_scan_stripes(const struct lu_env *env,
                        struct lu_attr *attr = &info->lti_la;
 
                        rc = dt_attr_get(env, parent, attr);
-                       if (rc != 0) {
-                               rc = PTR_ERR(lso);
+                       if (rc != 0)
                                goto next;
-                       }
 
                        lso = lfsck_assistant_object_init(env,
                                lfsck_dto2fid(parent), attr,