Whamcloud - gitweb
LU-14174 lfs: llapi_mirror_find() signed return 57/41757/7
authorMikhail Pershin <mpershin@whamcloud.com>
Fri, 4 Dec 2020 12:06:37 +0000 (15:06 +0300)
committerOleg Drokin <green@whamcloud.com>
Wed, 27 Oct 2021 00:36:49 +0000 (00:36 +0000)
Check return codes from llapi_mirror_find() as signed value
to don't count errors as valid mirror ids

Signed-off-by: Mikhail Pershin <mpershin@whamcloud.com>
Change-Id: I9754eaa063c9a2d07d8b815a86e7597922201f9c
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-on: https://review.whamcloud.com/41757
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: John L. Hammond <jhammond@whamcloud.com>
lustre/include/lustre/lustreapi.h
lustre/utils/liblustreapi_layout.c

index 427cf6a..2cf1669 100644 (file)
@@ -683,9 +683,8 @@ struct llapi_layout;
 int llapi_mirror_truncate(int fd, unsigned int id, off_t length);
 ssize_t llapi_mirror_write(int fd, unsigned int id, const void *buf,
                           size_t count, off_t pos);
-uint32_t llapi_mirror_find(struct llapi_layout *layout,
-                          uint64_t file_start, uint64_t file_end,
-                          uint64_t *endp);
+int llapi_mirror_find(struct llapi_layout *layout, uint64_t file_start,
+                     uint64_t file_end, uint64_t *endp);
 int llapi_layout_get_last_init_comp(struct llapi_layout *layout);
 int llapi_layout_mirror_inherit(struct llapi_layout *f_layout,
                                struct llapi_layout *m_layout);
index f4d6587..f107d27 100644 (file)
@@ -2856,9 +2856,8 @@ error:
 }
 
 /* locate @layout to a valid component covering file [file_start, file_end) */
-uint32_t llapi_mirror_find(struct llapi_layout *layout,
-                          uint64_t file_start, uint64_t file_end,
-                          uint64_t *endp)
+int llapi_mirror_find(struct llapi_layout *layout, uint64_t file_start,
+                     uint64_t file_end, uint64_t *endp)
 {
        uint32_t mirror_id = 0;
        int rc;