Whamcloud - gitweb
LU-17000 obdclass: Add NULL check for parms under class_exp2cliimp 30/55030/3
authorArshad Hussain <arshad.hussain@aeoncomputing.com>
Tue, 7 May 2024 05:29:03 +0000 (01:29 -0400)
committerOleg Drokin <green@whamcloud.com>
Wed, 29 May 2024 04:48:41 +0000 (04:48 +0000)
This patch adds NULL pointer check for parameters
passed under class_exp2cliimp()

Test-Parameters: trivial
CoverityID: 424699 ("Dereference before null check")
Signed-off-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Change-Id: Ie7d96c10086959a3f31b290d56621261da480a36
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/55030
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Shaun Tancheff <shaun.tancheff@hpe.com>
Reviewed-by: Timothy Day <timday@amazon.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
lustre/obdclass/genops.c

index 0e46ae7..413d134 100644 (file)
@@ -860,11 +860,16 @@ EXPORT_SYMBOL(class_exp2obd);
 
 struct obd_import *class_exp2cliimp(struct obd_export *exp)
 {
-       struct obd_device *obd = exp->exp_obd;
+       struct obd_device *obd;
+
+       if (!exp || !exp->exp_obd)
+               goto out;
+
+       obd = exp->exp_obd;
 
-       if (obd == NULL)
-               return NULL;
        return obd->u.cli.cl_import;
+out:
+       return NULL;
 }
 EXPORT_SYMBOL(class_exp2cliimp);