Yes, we should in fact MOD_DEC_USE_COUNT there.

diff --git a/lustre/mds/handler.c b/lustre/mds/handler.c
index 6bd5e0c..37735de 100644 (file)
--- a/lustre/mds/handler.c
+++ b/lustre/mds/handler.c
@@ -303,7 +303,7 @@ static int mds_connect(struct lustre_handle *conn, struct obd_device *obd,
                         if (!list_empty(&exp->exp_conn_chain)) {
                                 CERROR("existing uuid/export, list not empty!\n");
                                 spin_unlock(&obd->obd_dev_lock);
-                                /* XXX should we MOD_DEC_USE_COUNT; here? */
+                                MOD_DEC_USE_COUNT;
                                 RETURN(-EALREADY);
                         }
                         conn->addr = (__u64) (unsigned long)exp;