Whamcloud - gitweb
LU-17831 llite: remove refcount assert 54/55054/2
authorPatrick Farrell <paf0187@gmail.com>
Wed, 8 May 2024 14:36:55 +0000 (10:36 -0400)
committerOleg Drokin <green@whamcloud.com>
Mon, 2 Dec 2024 05:45:36 +0000 (05:45 +0000)
This refcount assert costs us a few % in page freeing and
it comes immediately after a dec_and_test.

Signed-off-by: Patrick Farrell <patrick.farrell@oracle.com>
Change-Id: I8de3369cbbaf484e1e0fce27ae3e62cad1ae5282
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/55054
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/obdclass/cl_page.c

index 9cda63a..89eaa60 100644 (file)
@@ -468,7 +468,6 @@ void cl_batch_put(const struct lu_env *env, struct cl_page *page,
                        PASSERT(env, page, page->cp_owner == NULL);
                }
 
-               LASSERT(refcount_read(&page->cp_ref) == 0);
                PASSERT(env, page, list_empty(&page->cp_batch));
                /* Page is no longer reachable by other threads. Tear it down */
                cl_page_free(env, page, fbatch);