Whamcloud - gitweb
LU-17213 llite: check sdio before freeing it 57/52757/2
authorPatrick Farrell <pfarrell@whamcloud.com>
Thu, 19 Oct 2023 14:30:57 +0000 (10:30 -0400)
committerOleg Drokin <green@whamcloud.com>
Wed, 8 Nov 2023 22:08:33 +0000 (22:08 +0000)
We check something in the sdio after freeing it.  Oops.

Test-Parameters: trivial
Signed-off-by: Patrick Farrell <pfarrell@whamcloud.com>
Change-Id: I1eae4bfe5fd83e5d8763266b1a7b3c5cb3118158
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/52757
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Alex Zhuravlev <bzzz@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
lustre/llite/rw26.c

index 791feb0..142a693 100644 (file)
@@ -620,8 +620,8 @@ ll_direct_IO_impl(struct kiocb *iocb, struct iov_iter *iter, int rw)
                        if (unlikely(result <= 0)) {
                                cl_sync_io_note(env, &sdio->csd_sync, result);
                                if (sync_submit) {
-                                       cl_sub_dio_free(sdio);
                                        LASSERT(sdio->csd_creator_free);
+                                       cl_sub_dio_free(sdio);
                                }
                                GOTO(out, result);
                        }