Whamcloud - gitweb
LU-5418 libcfs: only define noop_*_fn when readline is used 52/11252/4
authorFrank Zago <fzago@cray.com>
Mon, 28 Jul 2014 16:56:46 +0000 (11:56 -0500)
committerOleg Drokin <oleg.drokin@intel.com>
Fri, 15 Aug 2014 15:24:19 +0000 (15:24 +0000)
This fixes a compilation break introduced by change 7629b7.
When readline devel is not found on the system,
the code using readline is not used, including
noop_int_fn() and noop_void_fn().
This generates a couple warning about these
function being unused, which breaks the build.

Change-Id: I75b292cd6ad3b04fdd03adcf1886011e23620e8b
Signed-off-by: frank zago <fzago@cray.com>
Reviewed-on: http://review.whamcloud.com/11252
Tested-by: Jenkins
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Patrick Farrell <paf@cray.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
libcfs/libcfs/util/parser.c

index 3ac8d18..35f765f 100644 (file)
@@ -283,8 +283,10 @@ int execute_line(char * line)
         return rc;
 }
 
+#ifdef HAVE_LIBREADLINE
 static void noop_int_fn(int unused) { }
 static void noop_void_fn(void) { }
+#endif
 
 /* just in case you're ever in an airplane and discover you
  * forgot to install readline-dev. :) */