Whamcloud - gitweb
LU-16555 obdclass: print more special chars for jobid 98/49998/4
authorLei Feng <flei@whamcloud.com>
Wed, 15 Feb 2023 03:56:36 +0000 (11:56 +0800)
committerOleg Drokin <green@whamcloud.com>
Thu, 23 Feb 2023 06:34:38 +0000 (06:34 +0000)
Print more YAML compatible special chars for jobid.
Currently they are any of ".@-_:/".

Test-Parameters: trivial
Fixes: 338381574b ("LU-11407 tgt: cleanup job_stats output printing")
Signed-off-by: Lei Feng <flei@whamcloud.com>
Change-Id: Ic3272b73c95b76ad3171cc7a368a18f804b9aa3e
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/49998
Reviewed-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
lustre/obdclass/lprocfs_jobstats.c

index 757099f..ea23327 100644 (file)
@@ -455,8 +455,7 @@ static int lprocfs_jobstats_seq_show(struct seq_file *p, void *v)
        for (c = job->js_jobid, end = job->js_jobid + sizeof(job->js_jobid);
             c < end && *c != '\0';
             c++, joblen++) {
-               if (!isalnum(*c) &&
-                   *c != '.' && *c != '@' && *c != '-' && *c != '_') {
+               if (!isalnum(*c) && strchr(".@-_:/", *c) == NULL) {
                        quote = "\"";
                        snprintf(escaped + joblen, sizeof(escaped), "\\x%02X",
                                 (unsigned char)*c);