Whamcloud - gitweb
Branch b1_6
authorjohann <johann>
Tue, 7 Oct 2008 15:07:06 +0000 (15:07 +0000)
committerjohann <johann>
Tue, 7 Oct 2008 15:07:06 +0000 (15:07 +0000)
b=17026
i=shadow
i=oleg

Description: (ptllnd_peer.c:557:kptllnd_peer_check_sends()) ASSERTION(!in_interrupt()) failed
Details: fix stack overflow in the distributed lock manager by defering export
         eviction after a failed ast to the elt thread instead of handling
         it in the dlm interpret routine.

lustre/ChangeLog
lustre/ldlm/ldlm_lockd.c
lustre/mds/mds_reint.c

index 7e06d24..a0bd3d0 100644 (file)
@@ -144,6 +144,13 @@ Bugzilla   : 14095
 Description: Add lustre_start utility to start or stop multiple Lustre servers
              from a CSV file.
 
+Severity   : normal
+Bugzilla   : 17026
+Description: (ptllnd_peer.c:557:kptllnd_peer_check_sends()) ASSERTION(!in_interrupt()) failed
+Details    : fix stack overflow in the distributed lock manager by defering export
+            eviction after a failed ast to the elt thread instead of handling
+            it in the dlm interpret routine.
+
 --------------------------------------------------------------------------
 
 2008-08-31 Sun Microsystems, Inc.
index 7dfbbd1..a6cc1a2 100644 (file)
@@ -465,7 +465,14 @@ static void ldlm_failed_ast(struct ldlm_lock *lock, int rc,
 
         if (obd_dump_on_timeout)
                 libcfs_debug_dumplog();
+#ifdef __KERNEL__
+        spin_lock_bh(&waiting_locks_spinlock);
+        list_add(&lock->l_pending_chain, &expired_lock_thread.elt_expired_locks);
+        cfs_waitq_signal(&expired_lock_thread.elt_waitq);
+        spin_unlock_bh(&waiting_locks_spinlock);
+#else
         class_fail_export(lock->l_export);
+#endif
 }
 
 static int ldlm_handle_ast_error(struct ldlm_lock *lock,
index 2dc0381..ab8330d 100644 (file)
@@ -2393,7 +2393,8 @@ no_unlink:
 
         GOTO(cleanup, rc);
 cleanup:
-        rc = mds_finish_transno(mds, de_tgtdir ? de_tgtdir->d_inode : NULL,
+        rc = mds_finish_transno(mds, de_tgtdir && !IS_ERR(de_tgtdir) ?
+                                                      de_tgtdir->d_inode : NULL,
                                 handle, req, rc, 0, 0);
 
         switch (cleanup_phase) {