For the native Linux client testing I turn on lu_ref
debugging. When turned on the following errors occur:
[ 2885.946815] Call Trace:
[ 2885.951240] dump_stack+0x68/0x9b
[ 2885.956523] ___might_sleep+0x205/0x260
[ 2885.962245] lu_ref_add+0x25/0x40 [obdclass]
[ 2885.968442] vvp_pgcache_current+0x101/0x1a0 [lustre]
[ 2885.975370] seq_read+0x1ab/0x3c0
and
[ 7042.102529] dump_stack+0x68/0x9b
[ 7042.107328] ___might_sleep+0x205/0x260
[ 7042.112647] lu_ref_add+0x25/0x40 [obdclass]
[ 7042.118385] mdc_lock_upcall+0x154/0x4d0 [mdc]
[ 7042.124275] mdc_enqueue_send+0x508/0x580 [mdc]
[ 7042.130225] ? mdc_lock_lvb_update+0x280/0x280 [mdc]
This is easily fixed with introducing a lu_object_ref_add_atomic()
function.
Test-Parameters: trivial
Change-Id: Ife7d255079a836570661f669c1e9c7c0ce6de4aa
Signed-off-by: James Simmons <jsimmons@infradead.org>
Reviewed-on: https://review.whamcloud.com/44969
Reviewed-by: Patrick Farrell <pfarrell@whamcloud.com>
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Alex Zhuravlev <bzzz@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
return o->lo_header->loh_attr & S_IFMT;
}
return o->lo_header->loh_attr & S_IFMT;
}
+static inline void lu_object_ref_add_atomic(struct lu_object *o,
+ const char *scope,
+ const void *source)
+{
+ lu_ref_add_atomic(&o->lo_header->loh_reference, scope, source);
+}
+
static inline void lu_object_ref_add(struct lu_object *o,
const char *scope,
const void *source)
static inline void lu_object_ref_add(struct lu_object *o,
const char *scope,
const void *source)
continue;
priv->vsp_clob = lu2cl(lu_obj);
continue;
priv->vsp_clob = lu2cl(lu_obj);
- lu_object_ref_add(lu_obj, "dump", current);
+ lu_object_ref_add_atomic(lu_obj, "dump", current);
priv->vsp_page_index = 0;
}
priv->vsp_page_index = 0;
}
/* lock reference taken by ldlm_handle2lock_long() is
* owned by osc_lock and released in osc_lock_detach()
*/
/* lock reference taken by ldlm_handle2lock_long() is
* owned by osc_lock and released in osc_lock_detach()
*/
- lu_ref_add(&dlmlock->l_reference, "osc_lock", oscl);
+ lu_ref_add_atomic(&dlmlock->l_reference, "osc_lock", oscl);
oscl->ols_has_ref = 1;
LASSERT(oscl->ols_dlmlock == NULL);
oscl->ols_has_ref = 1;
LASSERT(oscl->ols_dlmlock == NULL);