- Can c ever be NULL in ptlrpc_put_connection? I don't know, but I want to
find out.
struct obd_export * export;
export = kmem_cache_alloc(export_cachep, GFP_KERNEL);
struct obd_export * export;
export = kmem_cache_alloc(export_cachep, GFP_KERNEL);
CERROR("no memory! (minor %d)\n", obddev->obd_minor);
return NULL;
}
CERROR("no memory! (minor %d)\n", obddev->obd_minor);
return NULL;
}
list_del(&exp->exp_conn_chain);
if (exp->exp_connection) {
spin_unlock(&exp->exp_connection->c_lock);
list_del(&exp->exp_conn_chain);
if (exp->exp_connection) {
spin_unlock(&exp->exp_connection->c_lock);
- ptlrpc_put_connection(exp->exp_connection);
+ //ptlrpc_put_connection(exp->exp_connection);
}
kmem_cache_free(export_cachep, exp);
}
kmem_cache_free(export_cachep, exp);
conn->addr = (__u64) (unsigned long)export;
conn->cookie = export->exp_cookie;
conn->addr = (__u64) (unsigned long)export;
conn->cookie = export->exp_cookie;
CDEBUG(D_IOCTL, "connect: addr %Lx cookie %Lx\n",
(long long)conn->addr, (long long)conn->cookie);
return 0;
CDEBUG(D_IOCTL, "connect: addr %Lx cookie %Lx\n",
(long long)conn->addr, (long long)conn->cookie);
return 0;
for (i = 0; i < obddev->obd_multi_count; i++) {
int rc;
for (i = 0; i < obddev->obd_multi_count; i++) {
int rc;
- struct obd_device *obd = class_conn2obd(&obddev->obd_multi_conn[i]);
+ struct obd_device *obd =
+ class_conn2obd(&obddev->obd_multi_conn[i]);
if (!obd) {
CERROR("no such device [i %d]\n", i);
if (!obd) {
CERROR("no such device [i %d]\n", i);
+ if (c == NULL) {
+ CERROR("NULL connection\n");
+ RETURN(0);
+ }
+
CDEBUG(D_INFO, "connection=%p refcount %d\n",
c, atomic_read(&c->c_refcount) - 1);
if (atomic_dec_and_test(&c->c_refcount)) {
CDEBUG(D_INFO, "connection=%p refcount %d\n",
c, atomic_read(&c->c_refcount) - 1);
if (atomic_dec_and_test(&c->c_refcount)) {