summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
4af4f48)
Under sanity-flr.sh/203 variable 'old_id' and
'new_id' is defined incorrectly as 'oldid' and
'newid'. This was exposed using shellcheck.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In lustre/tests/sanity-flr.sh line 3258:
[[ x$oldid = x$newid ]] ||
^-- SC2154: oldid is referenced but not assigned (did you mean 'old_id'?).
^-- SC2154: newid is referenced but not assigned (did you mean 'new_id'?).
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Test-Parameters: trivial testlist=sanity-flr
Signed-off-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Change-Id: I37949035f50dfdd33e5181ad888f68fcb204c385
Reviewed-on: https://review.whamcloud.com/46690
Tested-by: jenkins <devops@whamcloud.com>
Reviewed-by: James Nunez <jnunez@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
local new_id=$($LFS getstripe --mirror-id=2 -I $tf)
count=$($LFS getstripe --mirror-id=2 -c $tf) ||
error "getstripe count of mirror 2"
local new_id=$($LFS getstripe --mirror-id=2 -I $tf)
count=$($LFS getstripe --mirror-id=2 -c $tf) ||
error "getstripe count of mirror 2"
- [[ x$oldid = x$newid ]] ||
+ [[ x$old_id = x$new_id ]] ||
error "mirror 2 changed ID from $old_id to $new_id"
[[ x$count = x1 ]] || error "mirror 2 stripe count $count is not 1"
error "mirror 2 changed ID from $old_id to $new_id"
[[ x$count = x1 ]] || error "mirror 2 stripe count $count is not 1"