Pre 2.10.1 MDTs will crash when they receive a listxattr (MDS_GETXATTR
with OBD_MD_FLXATTRLS) RPC for an orphan or dead object. So for
clients connected to these older MDTs, try to avoid sending listxattr
RPCs by making the bulk getxattr (MDS_GETXATTR with OBD_MD_FLXATTRALL)
more likely to succeed and thereby reducing the chances of falling
back to listxattr.
Lustre-change: https://review.whamcloud.com/31990
Lustre-commit:
a95b85efdc97136d0fbf6959acf62919319901ed
Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: Ia96323c47c91a44495b73be2d95705298c7f7ac9
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Minh Diep <minh.diep@intel.com>
Reviewed-on: https://review.whamcloud.com/32251
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
struct ldlm_intent *lit;
int rc, count = 0;
struct list_head cancels = LIST_HEAD_INIT(cancels);
struct ldlm_intent *lit;
int rc, count = 0;
struct list_head cancels = LIST_HEAD_INIT(cancels);
lit = req_capsule_client_get(&req->rq_pill, &RMF_LDLM_INTENT);
lit->opc = IT_GETXATTR;
lit = req_capsule_client_get(&req->rq_pill, &RMF_LDLM_INTENT);
lit->opc = IT_GETXATTR;
+#if LUSTRE_VERSION_CODE < OBD_OCD_VERSION(3, 0, 53, 0)
+ /* If the supplied buffer is too small then the server will
+ * return -ERANGE and llite will fallback to using non cached
+ * xattr operations. On servers before 2.10.1 a (non-cached)
+ * listxattr RPC for an orphan or dead file causes an oops. So
+ * let's try to avoid sending too small a buffer to too old a
+ * server. This is effectively undoing the memory conservation
+ * of LU-9417 when it would be *more* likely to crash the
+ * server. See LU-9856. */
+ if (exp->exp_connect_data.ocd_version < OBD_OCD_VERSION(2, 10, 1, 0))
+ min_buf_size = exp->exp_connect_data.ocd_max_easize;
+#endif
+
/* pack the intended request */
mdc_pack_body(req, &op_data->op_fid1, op_data->op_valid,
/* pack the intended request */
mdc_pack_body(req, &op_data->op_fid1, op_data->op_valid,
- GA_DEFAULT_EA_NAME_LEN * GA_DEFAULT_EA_NUM,
+ max_t(u32, min_buf_size,
+ GA_DEFAULT_EA_NAME_LEN * GA_DEFAULT_EA_NUM),
-1, 0);
req_capsule_set_size(&req->rq_pill, &RMF_EADATA, RCL_SERVER,
-1, 0);
req_capsule_set_size(&req->rq_pill, &RMF_EADATA, RCL_SERVER,
- GA_DEFAULT_EA_NAME_LEN * GA_DEFAULT_EA_NUM);
+ max_t(u32, min_buf_size,
+ GA_DEFAULT_EA_NAME_LEN * GA_DEFAULT_EA_NUM));
req_capsule_set_size(&req->rq_pill, &RMF_EAVALS, RCL_SERVER,
req_capsule_set_size(&req->rq_pill, &RMF_EAVALS, RCL_SERVER,
- GA_DEFAULT_EA_VAL_LEN * GA_DEFAULT_EA_NUM);
+ max_t(u32, min_buf_size,
+ GA_DEFAULT_EA_VAL_LEN * GA_DEFAULT_EA_NUM));
req_capsule_set_size(&req->rq_pill, &RMF_EAVALS_LENS, RCL_SERVER,
req_capsule_set_size(&req->rq_pill, &RMF_EAVALS_LENS, RCL_SERVER,
- sizeof(__u32) * GA_DEFAULT_EA_NUM);
+ max_t(u32, min_buf_size,
+ sizeof(__u32) * GA_DEFAULT_EA_NUM));
req_capsule_set_size(&req->rq_pill, &RMF_ACL, RCL_SERVER, 0);
req_capsule_set_size(&req->rq_pill, &RMF_ACL, RCL_SERVER, 0);