Whamcloud - gitweb
LU-17379 ptlrpc: fix check for callback discard 37/53937/2
authorMikhail Pershin <mpershin@whamcloud.com>
Tue, 6 Feb 2024 09:36:40 +0000 (12:36 +0300)
committerOleg Drokin <green@whamcloud.com>
Fri, 23 Feb 2024 07:16:46 +0000 (07:16 +0000)
commita6886dba0ed8a622c9831cd33d310d933492c72d
treed29c2028a23b7ebd7908d73fd97673abd9932e78
parentadc60b8922bd582f591f4f04e5626fd2c9e03f9b
LU-17379 ptlrpc: fix check for callback discard

In ptlrpc_unregister_reply() decision about need to
discard request-out callback is done too early, before
LNetMDUnlink() invokes reply callback. Therefore at the
monent of discard check rq_reply_unlinked is not set yet
and discard is skipped always.

Patch removes discard check from __ptlrpc_cli_wait_unlink()
and does that after LNetMDUnlink() call right inside
ptlrpc_unregister_reply().
That makes __ptlrpc_cli_wait_unlink() unused, so it was
removed and only ptlrpc_cli_wait_unlink() remains

Fixes: babf0232273 ("LU-13368 lnet: discard the callback")
Signed-off-by: Mikhail Pershin <mpershin@whamcloud.com>
Change-Id: I6448cafa8a0b81d7ba0172ad1709e75e592d4924
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/53937
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Serguei Smirnov <ssmirnov@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/include/lustre_net.h
lustre/ptlrpc/client.c