Whamcloud - gitweb
LU-12199 lnet: Ensure md is detached when msg is not committed 85/34885/8
authorChris Horn <hornc@cray.com>
Thu, 18 Apr 2019 03:49:18 +0000 (22:49 -0500)
committerAmir Shehata <ashehata@whamcloud.com>
Fri, 7 Jun 2019 18:09:28 +0000 (18:09 +0000)
commitb65f3a1767ae82c7f629320187b33eb8670da537
tree835d9a7047710077590a16a37db558fa409edd87
parentdd16a31bf4ae874a69cc7dc5fe1f3197993630ae
LU-12199 lnet: Ensure md is detached when msg is not committed

It's possible for lnet_is_health_check() to return "true" when the
message has not hit the network. In this situation the message is
freed without detaching the MD. As a result, requests do not receive
their unlink events and these requests are stuck forever.

A little cleanup is included here:
 - The value of lnet_is_health_check() is only used in one place, so
   we don't need to save the result of it in a variable.
 - We don't need separate logic to detach the md when the send was
   successful. We'll fall through to the finalizing code after
   incrementing the health counters

Test-Parameters: forbuildonly
Cray-bug-id: LUS-7239
Signed-off-by: Chris Horn <hornc@cray.com>
Change-Id: I6301d491090b862d016eed3aac8afd7be8685e57
Reviewed-on: https://review.whamcloud.com/34885
Reviewed-by: Olaf Weber <olaf.weber@hpe.com>
Tested-by: Maloo <maloo@whamcloud.com>
Tested-by: Jenkins
Reviewed-by: Amir Shehata <ashehata@whamcloud.com>
lnet/lnet/lib-msg.c