Whamcloud - gitweb
LU-8685 kernel: jbd2: fix incorrect unlock on j_list_lock 50/23050/2
authorBruno Faccini <bruno.faccini@intel.com>
Mon, 10 Oct 2016 13:10:47 +0000 (15:10 +0200)
committerOleg Drokin <oleg.drokin@intel.com>
Tue, 25 Oct 2016 02:24:02 +0000 (02:24 +0000)
commit77e28905d9bc508b668f0db701f7df55ff97a3d1
tree8a1b9f3f730624a50c4cd22a3c99a43da2e5791f
parent9c4b9ba2a32343bb8fae774db4edd7cf2ef9e852
LU-8685 kernel: jbd2: fix incorrect unlock on j_list_lock

This patch has been back-ported to avoid kernel Oopses/BUG()s
due to j_list_lock found unlocked when expected to be locked!

In jbd2_journal_get_create_access(),
when 'jh->b_transaction == transaction' (asserted by below)

  J_ASSERT_JH(jh, (jh->b_transaction == transaction || ...

'journal->j_list_lock' will be incorrectly unlocked, since
the the lock is aquired only at the end of if / else-if
statements (missing the else case).

This bug has been introduced by an earlier change named
"jbd2: minimize region locked by j_list_lock in
journal_get_create_access()".

Signed-off-by: Taesoo Kim <tsgatesv@gmail.com>
Signed-off-by: Bruno Faccini <bruno.faccini@intel.com>
Change-Id: Ifb8b038333e523caa1b274f53f49317182895de5
Reviewed-on: http://review.whamcloud.com/23050
Tested-by: Jenkins
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: Niu Yawei <yawei.niu@intel.com>
Reviewed-by: Wang Shilong <wshilong@ddn.com>
lustre/kernel_patches/patches/jbd2-fix-j_list_lock-unlock-3.10-rhel7.patch [new file with mode: 0644]
lustre/kernel_patches/series/3.10-rhel7.series