Whamcloud - gitweb
LU-12199 lnet: Ensure md is detached when msg is not committed 38/36038/3
authorChris Horn <hornc@cray.com>
Thu, 18 Apr 2019 03:49:18 +0000 (22:49 -0500)
committerOleg Drokin <green@whamcloud.com>
Fri, 4 Oct 2019 20:30:57 +0000 (20:30 +0000)
commitd5a05a56fa29259b28dcc766af391ee0f3a357fd
treecdca260b25e83e95e7958ca71adcb50f4d1d7135
parent0963d01e04e10ec09b6db045fe4110bf954d2b57
LU-12199 lnet: Ensure md is detached when msg is not committed

It's possible for lnet_is_health_check() to return "true" when the
message has not hit the network. In this situation the message is
freed without detaching the MD. As a result, requests do not receive
their unlink events and these requests are stuck forever.

A little cleanup is included here:
 - The value of lnet_is_health_check() is only used in one place, so
   we don't need to save the result of it in a variable.
 - We don't need separate logic to detach the md when the send was
   successful. We'll fall through to the finalizing code after
   incrementing the health counters

Lustre-change: https://review.whamcloud.com/34885
Lustre-commit: b65f3a1767ae82c7f629320187b33eb8670da537

Cray-bug-id: LUS-7239
Signed-off-by: Chris Horn <hornc@cray.com>
Change-Id: I6301d491090b862d016eed3aac8afd7be8685e57
Reviewed-by: Olaf Weber <olaf.weber@hpe.com>
Reviewed-by: Amir Shehata <ashehata@whamcloud.com>
Signed-off-by: Minh Diep <mdiep@whamcloud.com>
Reviewed-on: https://review.whamcloud.com/36038
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lnet/lnet/lib-msg.c