Whamcloud - gitweb
LU-5476 llite: Fix integer overflow in ll_fid2path 12/11412/2
authorOleg Drokin <oleg.drokin@intel.com>
Tue, 12 Aug 2014 13:20:14 +0000 (09:20 -0400)
committerOleg Drokin <oleg.drokin@intel.com>
Thu, 14 Aug 2014 17:30:29 +0000 (17:30 +0000)
commitd01834323af7a14d2d4959d9bea58073e3bb16ea
tree4c73badd060c92856b661c98117838063acb8a83
parent94d923de400fc1c6a50b67a55ce700251f93ab05
LU-5476 llite: Fix integer overflow in ll_fid2path

Reported by Dan Carpenter <dan.carpenter@oracle.com>

outsize = sizeof(*gfout) + gfin->gf_pathlen;

Where outsize is int and gf_pathlen is u32 from userspace
can lead to integer overflowwhere outsize is some small number
less than sizeof(*gfout)

Add a check for pathlen to be of sensical size.

Change-Id: I90d6ca290d115eabd9b68c7512c65f7e1fccc752
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Reviewed-on: http://review.whamcloud.com/11412
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Tested-by: Jenkins
Tested-by: Maloo <hpdd-maloo@intel.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
lustre/llite/file.c