Whamcloud - gitweb
LU-6142 lov: style cleanups in lov_set_osc_active() 82/39382/3
authorMr NeilBrown <neilb@suse.de>
Wed, 15 Jul 2020 05:42:23 +0000 (15:42 +1000)
committerOleg Drokin <green@whamcloud.com>
Fri, 26 Feb 2021 21:41:55 +0000 (21:41 +0000)
commitcab152600ebe8a00524edbe28b314a7cebde545a
treedbccb741f21c2aadae7901978d702fef312db653
parent33265fe88ba59148609dc0706c84e4fb7fde43aa
LU-6142 lov: style cleanups in lov_set_osc_active()

1/ don't pre-declare the function as it is not used before it
   is defined.
2/ " TEST ? 1 : 0" is identical to "TEST", so remove the "? 1 : 0".
3/ When the 'then' part of an 'if' ends with a GOTO, there is
   not point having an 'else', particularly if there is also
   code in the block following the "if".  The 'else' code and
   the following code should be together.

4/ other minor changes, and conversion of spaces to tabs.

Test-Parameters: trivial
Signed-off-by: Mr NeilBrown <neilb@suse.de>
Change-Id: I00cb8b1efe25c0ad9adc76ba21cca003aed203e2
Reviewed-on: https://review.whamcloud.com/39382
Tested-by: jenkins <devops@whamcloud.com>
Reviewed-by: Arshad Hussain <arshad.hussain@aeoncomputing.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Lai Siyao <lai.siyao@whamcloud.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/lov/lov_obd.c