Whamcloud - gitweb
LU-3517 llite: don't check for O_CREAT in it_create_mode
authorJohn L. Hammond <john.hammond@intel.com>
Mon, 1 Jul 2013 17:26:15 +0000 (12:26 -0500)
committerOleg Drokin <oleg.drokin@intel.com>
Thu, 8 Aug 2013 06:05:22 +0000 (02:05 -0400)
commitb0dfe821382a03fcdc74697be471de91e682743b
treeddef422830b2ec82fa307ceb47b35c87c71f6c86
parent256c96d2cbe817908f64a896b455105bb4f206a2
LU-3517 llite: don't check for O_CREAT in it_create_mode

ll_lookup_it() checks for O_CREAT in struct lookup_intent's
it_create_mode member which is nonsensical, as it_create_mode is used
for file mode bits (S_IFREG, S_IRUSR, ...). Fix this by just checking
for IT_CREATE in it_op and do the same in llu_lookup_it(). This will
not affect the behavior of either function, since if O_CREATE (0100)
is actually set in o_create_mode then IT_CREATE must have been set in
it_op. In ll_atomic_open() check for O_CREAT in the open_flags
parameter rather than testing mode.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Change-Id: I301964222ec043e6f0cc3b000678fe3c881a2381
Reviewed-on: http://review.whamcloud.com/6786
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: Peng Tao <bergwolf@gmail.com>
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
lustre/liblustre/namei.c
lustre/llite/namei.c