Whamcloud - gitweb
LU-1199 build: Change various %defines to %globals
As a general rule, "%define" should not be used inside
of %{ } blocks. %define is locally scoped. While it
appears to work with constructs like this:
%{!?foo: %define foo bar}
that is only because of an rpm quirk that fails to
free non-global scope variables immediately. Later use
of parameterized macros in the file can trigger cleanup
of the local variables, and "foo" will be once again
undefined.
The solution is to use %global like so:
%{!?foo: %global foo bar}
Signed-off-by: Christopher J. Morrone <morrone2@llnl.gov>
Change-Id: Ie18b0b86324334330b726bf69249d97e47e9350e
Reviewed-on: http://review.whamcloud.com/3420
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Keith Mannthey <keith.mannthey@intel.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>