Whamcloud - gitweb
LU-16671 osc: fix unstable pages for short IO 51/50451/13
authorPatrick Farrell <pfarrell@whamcloud.com>
Tue, 28 Mar 2023 15:02:40 +0000 (11:02 -0400)
committerOleg Drokin <green@whamcloud.com>
Sat, 23 Sep 2023 06:04:14 +0000 (06:04 +0000)
commit4ba4976f525e957ef4c3ca7981bea01f72109ed6
treeb85ca86696180dbc2e692358ccf18cd84cc68895
parentd9df39505530c5f224427103290b60828c11e81c
LU-16671 osc: fix unstable pages for short IO

Unstable pages was written with theoretical support for
short IO (ie, no bulk, data-in-rpc, LU-1757), but since the
short IO code wasn't merged until years later, they were
probably never tested together.  And when you do, it
crashes.

In truth, short IO has no separate pages to be tracked,
which is why this is crashing.  This means that small write
RPCs won't be tracked in unstable pages, but that's a very
minor limitation and unlikely to cause trouble.  (and since
RPC allocations are not 'pages', they're just malloc'ed,
there's no good way to track them anyway)

Fixes: 70f092a ("LU-1757 brw: add short io osc/ost transfer.")
Signed-off-by: Patrick Farrell <pfarrell@whamcloud.com>
Change-Id: I34b09f8324424c3ff0b0c09c86f01c938b643e37
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/50451
Tested-by: jenkins <devops@whamcloud.com>
Tested-by: Maloo <maloo@whamcloud.com>
Reviewed-by: Andreas Dilger <adilger@whamcloud.com>
Reviewed-by: Qian Yingjin <qian@ddn.com>
Reviewed-by: Shaun Tancheff <shaun.tancheff@hpe.com>
Reviewed-by: Oleg Drokin <green@whamcloud.com>
lustre/osc/osc_page.c