Whamcloud - gitweb
LU-3032 ptlrpc: race in pinger (use-after-free situation)
authorDmitry Eremin <dmitry.eremin@intel.com>
Fri, 12 Apr 2013 13:10:15 +0000 (17:10 +0400)
committerOleg Drokin <oleg.drokin@intel.com>
Thu, 6 Jun 2013 03:23:35 +0000 (23:23 -0400)
commitc7ceca414f388d894f9299b2e87eaa791ea6dd87
tree08c8b71ba2ceb763da49cd2f89c6ef1b23ca9a15
parent0c594c8b51a8433d8f4dd498e68dc2d9ee158611
LU-3032 ptlrpc: race in pinger (use-after-free situation)

The race is result of use-after-free situation:

~ ptlrpc_stop_pinger()          ~ ptlrpc_pinger_main()
---------------------------------------------------------------
thread_set_flags(SVC_STOPPING)
cfs_waitq_signal(pinger_thread) ...
...                             thread_set_flags(SVC_STOPPED)
l_wait_event(thread_is_stopped)
OBD_FREE_PTR(pinger_thread)
...                             cfs_waitq_signal(pinger_thread)
---------------------------------------------------------------

The memory used by pinger_thread might have been freed and
reallocated to something else, when ptlrpc_pinger_main()
used it in cvs_waitq_signal().

Signed-off-by: Li Wei <wei.g.li@intel.com>
Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Change-Id: I3516c7ece2b2e1e4e0b2e47acb0583c174a3e631
Reviewed-on: http://review.whamcloud.com/6040
Tested-by: Hudson
Tested-by: Maloo <whamcloud.maloo@gmail.com>
Reviewed-by: Faccini Bruno <bruno.faccini@intel.com>
Reviewed-by: Mike Pershin <mike.pershin@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
lustre/ptlrpc/pinger.c