X-Git-Url: https://git.whamcloud.com/?a=blobdiff_plain;f=lustre%2Fosp%2Fosp_precreate.c;h=11dd60ccb525fb45ad54ea938acf10ce0fdae97c;hb=11db1a551172f596d1d284e8496530f9ce24ac81;hp=0a0f9f0b39be5f02e325d0dd318520cc1b54191c;hpb=57070c9a3ab4c5c17bb06c942fc0d4a2e5519e1b;p=fs%2Flustre-release.git

diff --git a/lustre/osp/osp_precreate.c b/lustre/osp/osp_precreate.c
index 0a0f9f0..11dd60c 100644
--- a/lustre/osp/osp_precreate.c
+++ b/lustre/osp/osp_precreate.c
@@ -27,7 +27,7 @@
  * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2012, Intel Corporation.
+ * Copyright (c) 2012, 2013, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
@@ -42,9 +42,6 @@
  * Author: Di Wang <di.wang@intel.com>
  */
 
-#ifndef EXPORT_SYMTAB
-# define EXPORT_SYMTAB
-#endif
 #define DEBUG_SUBSYSTEM S_MDS
 
 #include "osp_internal.h"
@@ -212,11 +209,11 @@ static inline int osp_objs_precreated(const struct lu_env *env,
 		struct ost_id *oi2 = &osp_env_info(env)->osi_oi2;
 
 		LASSERT(fid_is_idif(fid1) && fid_is_idif(fid2));
-		ostid_idif_pack(fid1, oi1);
-		ostid_idif_pack(fid2, oi2);
-		LASSERT(oi1->oi_id >= oi2->oi_id);
+		fid_to_ostid(fid1, oi1);
+		fid_to_ostid(fid2, oi2);
+		LASSERT(ostid_id(oi1) >= ostid_id(oi2));
 
-		return oi1->oi_id - oi2->oi_id;
+		return ostid_id(oi1) - ostid_id(oi2);
 	}
 
 	return fid_oid(fid1) - fid_oid(fid2);
@@ -381,16 +378,16 @@ static int osp_precreate_fids(const struct lu_env *env, struct osp_device *osp,
 
 		spin_lock(&osp->opd_pre_lock);
 		last_fid = &osp->opd_pre_last_created_fid;
-		ostid_idif_pack(last_fid, oi);
-		end = min(oi->oi_id + *grow, IDIF_MAX_OID);
-		*grow = end - oi->oi_id;
-		oi->oi_id += *grow;
+		fid_to_ostid(last_fid, oi);
+		end = min(ostid_id(oi) + *grow, IDIF_MAX_OID);
+		*grow = end - ostid_id(oi);
+		ostid_set_id(oi, ostid_id(oi) + *grow);
 		spin_unlock(&osp->opd_pre_lock);
 
 		if (*grow == 0)
 			return 1;
 
-		ostid_idif_unpack(oi, fid, osp->opd_index);
+		ostid_to_fid(fid, oi, osp->opd_index);
 		return 0;
 	}
 
@@ -454,6 +451,7 @@ static int osp_precreate_send(const struct lu_env *env, struct osp_device *d)
 	body = req_capsule_client_get(&req->rq_pill, &RMF_OST_BODY);
 	LASSERT(body);
 
+	*fid = d->opd_pre_last_created_fid;
 	rc = osp_precreate_fids(env, d, fid, &grow);
 	if (rc == 1) {
 		/* Current seq has been used up*/
@@ -472,7 +470,7 @@ static int osp_precreate_send(const struct lu_env *env, struct osp_device *d)
 		fid->f_seq = 0;
 	}
 
-	ostid_fid_pack(fid, &body->oa.o_oi);
+	fid_to_ostid(fid, &body->oa.o_oi);
 	body->oa.o_valid = OBD_MD_FLGROUP;
 
 	ptlrpc_request_set_replen(req);
@@ -489,14 +487,11 @@ static int osp_precreate_send(const struct lu_env *env, struct osp_device *d)
 	if (body == NULL)
 		GOTO(out_req, rc = -EPROTO);
 
-	fid_ostid_unpack(fid, &body->oa.o_oi, d->opd_index);
+	ostid_to_fid(fid, &body->oa.o_oi, d->opd_index);
 	LASSERTF(lu_fid_diff(fid, &d->opd_pre_used_fid) > 0,
 		 "reply fid "DFID" pre used fid "DFID"\n", PFID(fid),
 		 PFID(&d->opd_pre_used_fid));
 
-	CDEBUG(D_HA, "%s: new last_created "DFID"\n", d->opd_obd->obd_name,
-	       PFID(fid));
-
 	diff = lu_fid_diff(fid, &d->opd_pre_last_created_fid);
 
 	spin_lock(&d->opd_pre_lock);
@@ -515,8 +510,9 @@ static int osp_precreate_send(const struct lu_env *env, struct osp_device *d)
 	d->opd_pre_last_created_fid = *fid;
 	spin_unlock(&d->opd_pre_lock);
 
-	CDEBUG(D_OTHER, "current precreated pool: "DFID"-"DFID"\n",
-	       PFID(&d->opd_pre_used_fid), PFID(&d->opd_pre_last_created_fid));
+	CDEBUG(D_HA, "%s: current precreated pool: "DFID"-"DFID"\n",
+	       d->opd_obd->obd_name, PFID(&d->opd_pre_used_fid),
+	       PFID(&d->opd_pre_last_created_fid));
 out_req:
 	/* now we can wakeup all users awaiting for objects */
 	osp_pre_update_status(d, rc);
@@ -526,11 +522,12 @@ out_req:
 	RETURN(rc);
 }
 
-static int osp_get_lastfid_from_ost(struct osp_device *d)
+static int osp_get_lastfid_from_ost(const struct lu_env *env,
+				    struct osp_device *d)
 {
 	struct ptlrpc_request	*req = NULL;
 	struct obd_import	*imp;
-	struct lu_fid		*last_fid = &d->opd_last_used_fid;
+	struct lu_fid		*last_fid;
 	char			*tmp;
 	int			rc;
 	ENTRY;
@@ -542,11 +539,11 @@ static int osp_get_lastfid_from_ost(struct osp_device *d)
 	if (req == NULL)
 		RETURN(-ENOMEM);
 
-	req_capsule_set_size(&req->rq_pill, &RMF_SETINFO_KEY,
-			     RCL_CLIENT, sizeof(KEY_LAST_FID));
+	req_capsule_set_size(&req->rq_pill, &RMF_SETINFO_KEY, RCL_CLIENT,
+			     sizeof(KEY_LAST_FID));
 
-	req_capsule_set_size(&req->rq_pill, &RMF_SETINFO_VAL,
-			     RCL_CLIENT, sizeof(*last_fid));
+	req_capsule_set_size(&req->rq_pill, &RMF_SETINFO_VAL, RCL_CLIENT,
+			     sizeof(struct lu_fid));
 
 	rc = ptlrpc_request_pack(req, LUSTRE_OST_VERSION, OST_GET_INFO);
 	if (rc) {
@@ -558,9 +555,8 @@ static int osp_get_lastfid_from_ost(struct osp_device *d)
 	memcpy(tmp, KEY_LAST_FID, sizeof(KEY_LAST_FID));
 
 	req->rq_no_delay = req->rq_no_resend = 1;
-	fid_cpu_to_le(last_fid, last_fid);
 	tmp = req_capsule_client_get(&req->rq_pill, &RMF_SETINFO_VAL);
-	memcpy(tmp, last_fid, sizeof(*last_fid));
+	fid_cpu_to_le((struct lu_fid *)tmp, &d->opd_last_used_fid);
 	ptlrpc_request_set_replen(req);
 
 	rc = ptlrpc_queue_wait(req);
@@ -575,7 +571,12 @@ static int osp_get_lastfid_from_ost(struct osp_device *d)
 	}
 
 	last_fid = req_capsule_server_get(&req->rq_pill, &RMF_FID);
-	if (last_fid == NULL || !fid_is_sane(last_fid)) {
+	if (last_fid == NULL) {
+		CERROR("%s: Got last_fid failed.\n", d->opd_obd->obd_name);
+		GOTO(out, rc = -EPROTO);
+	}
+
+	if (!fid_is_sane(last_fid)) {
 		CERROR("%s: Got insane last_fid "DFID"\n",
 		       d->opd_obd->obd_name, PFID(last_fid));
 		GOTO(out, rc = -EPROTO);
@@ -586,7 +587,7 @@ static int osp_get_lastfid_from_ost(struct osp_device *d)
 	if (fid_oid(last_fid) > 0)
 		d->opd_last_used_fid = *last_fid;
 
-	CDEBUG(D_HA, "%s: Got insane last_fid "DFID"\n", d->opd_obd->obd_name,
+	CDEBUG(D_HA, "%s: Got last_fid "DFID"\n", d->opd_obd->obd_name,
 	       PFID(last_fid));
 
 out:
@@ -646,7 +647,7 @@ static int osp_precreate_cleanup_orphans(struct lu_env *env,
 	LASSERT(!fid_is_zero(last_fid));
 	if (fid_oid(&d->opd_last_used_fid) < 2) {
 		/* lastfid looks strange... ask OST */
-		rc = osp_get_lastfid_from_ost(d);
+		rc = osp_get_lastfid_from_ost(env, d);
 		if (rc)
 			GOTO(out, rc);
 	}
@@ -671,12 +672,8 @@ static int osp_precreate_cleanup_orphans(struct lu_env *env,
 
 	body->oa.o_flags = OBD_FL_DELORPHAN;
 	body->oa.o_valid = OBD_MD_FLFLAGS | OBD_MD_FLGROUP;
-	if (osp_is_fid_client(d))
-		body->oa.o_seq = fid_seq(&d->opd_last_used_fid);
-	else
-		body->oa.o_seq = 0;
-	/* remove from NEXT after used one */
-	body->oa.o_id = fid_oid(&d->opd_last_used_fid);
+
+	fid_to_ostid(&d->opd_last_used_fid, &body->oa.o_oi);
 
 	ptlrpc_request_set_replen(req);
 
@@ -696,10 +693,7 @@ static int osp_precreate_cleanup_orphans(struct lu_env *env,
 	/*
 	 * OST provides us with id new pool starts from in body->oa.o_id
 	 */
-	fid_ostid_unpack(last_fid, &body->oa.o_oi, d->opd_index);
-	CDEBUG(D_INFO, "%s: last_fid "DFID" server last fid "DFID"\n",
-	       d->opd_obd->obd_name, PFID(&d->opd_last_used_fid),
-	       PFID(last_fid));
+	ostid_to_fid(last_fid, &body->oa.o_oi, d->opd_index);
 
 	spin_lock(&d->opd_pre_lock);
 	diff = lu_fid_diff(&d->opd_last_used_fid, last_fid);
@@ -840,7 +834,7 @@ static int osp_init_pre_fid(struct osp_device *osp)
 	last_fid = &osi->osi_fid;
 	fid_zero(last_fid);
 	/* For a freshed fs, it will allocate a new sequence first */
-	if (osp_is_fid_client(osp)) {
+	if (osp_is_fid_client(osp) && osp->opd_group != 0) {
 		cli_seq = osp->opd_obd->u.cli.cl_seq;
 		rc = seq_client_get_seq(&env, cli_seq, &last_fid->f_seq);
 		if (rc != 0) {
@@ -849,7 +843,7 @@ static int osp_init_pre_fid(struct osp_device *osp)
 			GOTO(out, rc);
 		}
 	} else {
-		last_fid->f_seq = fid_idif_seq(1, osp->opd_index);
+		last_fid->f_seq = fid_idif_seq(0, osp->opd_index);
 	}
 	last_fid->f_oid = 1;
 	last_fid->f_ver = 0;
@@ -875,15 +869,11 @@ static int osp_precreate_thread(void *_arg)
 	struct osp_device	*d = _arg;
 	struct ptlrpc_thread	*thread = &d->opd_pre_thread;
 	struct l_wait_info	 lwi = { 0 };
-	char			 pname[16];
 	struct lu_env		 env;
 	int			 rc;
 
 	ENTRY;
 
-	sprintf(pname, "osp-pre-%u\n", d->opd_index);
-	cfs_daemonize(pname);
-
 	rc = lu_env_init(&env, d->opd_dt_dev.dd_lu_dev.ld_type->ldt_ctx_tags);
 	if (rc) {
 		CERROR("%s: init env error: rc = %d\n", d->opd_obd->obd_name,
@@ -906,9 +896,6 @@ static int osp_precreate_thread(void *_arg)
 				     d->opd_new_connection,
 				     &lwi);
 
-			if (!osp_precreate_running(d))
-				break;
-
 			if (!d->opd_new_connection)
 				continue;
 
@@ -917,6 +904,10 @@ static int osp_precreate_thread(void *_arg)
 			break;
 		}
 
+		if (!osp_precreate_running(d))
+			break;
+
+		LASSERT(d->opd_obd->u.cli.cl_seq != NULL);
 		if (d->opd_obd->u.cli.cl_seq->lcs_exp == NULL) {
 			/* Get new sequence for client first */
 			LASSERT(d->opd_exp != NULL);
@@ -1046,7 +1037,6 @@ int osp_precreate_reserve(const struct lu_env *env, struct osp_device *d)
 	struct l_wait_info	 lwi;
 	cfs_time_t		 expire = cfs_time_shift(obd_timeout);
 	int			 precreated, rc;
-	int			 count = 0;
 
 	ENTRY;
 
@@ -1064,17 +1054,6 @@ int osp_precreate_reserve(const struct lu_env *env, struct osp_device *d)
 	while ((rc = d->opd_pre_status) == 0 || rc == -ENOSPC ||
 		rc == -ENODEV || rc == -EAGAIN) {
 
-#if LUSTRE_VERSION_CODE < OBD_OCD_VERSION(2, 3, 90, 0)
-		/*
-		 * to address Andreas's concern on possible busy-loop
-		 * between this thread and osp_precreate_send()
-		 */
-		if (unlikely(count++ == 1000)) {
-			osp_precreate_timeout_condition(d);
-			LBUG();
-		}
-#endif
-
 		/*
 		 * increase number of precreations
 		 */
@@ -1132,8 +1111,10 @@ int osp_precreate_reserve(const struct lu_env *env, struct osp_device *d)
 
 		lwi = LWI_TIMEOUT(expire - cfs_time_current(),
 				osp_precreate_timeout_condition, d);
-		if (cfs_time_aftereq(cfs_time_current(), expire))
+		if (cfs_time_aftereq(cfs_time_current(), expire)) {
+			rc = -ETIMEDOUT;
 			break;
+		}
 
 		l_wait_event(d->opd_pre_user_waitq,
 			     osp_precreate_ready_condition(env, d), &lwi);
@@ -1222,7 +1203,7 @@ int osp_object_truncate(const struct lu_env *env, struct dt_object *dt,
 	if (oa == NULL)
 		GOTO(out, rc = -ENOMEM);
 
-	rc = fid_ostid_pack(lu_object_fid(&dt->do_lu), &oa->o_oi);
+	rc = fid_to_ostid(lu_object_fid(&dt->do_lu), &oa->o_oi);
 	LASSERT(rc == 0);
 	oa->o_size = size;
 	oa->o_blocks = OBD_OBJECT_EOF;
@@ -1231,7 +1212,7 @@ int osp_object_truncate(const struct lu_env *env, struct dt_object *dt,
 
 	body = req_capsule_client_get(&req->rq_pill, &RMF_OST_BODY);
 	LASSERT(body);
-	lustre_set_wire_obdo(&body->oa, oa);
+	lustre_set_wire_obdo(&req->rq_import->imp_connect_data, &body->oa, oa);
 
 	/* XXX: capa support? */
 	/* osc_pack_capa(req, body, capa); */
@@ -1251,7 +1232,7 @@ out:
 int osp_init_precreate(struct osp_device *d)
 {
 	struct l_wait_info	 lwi = { 0 };
-	int			 rc;
+	cfs_task_t		*task;
 
 	ENTRY;
 
@@ -1286,10 +1267,11 @@ int osp_init_precreate(struct osp_device *d)
 	/*
 	 * start thread handling precreation and statfs updates
 	 */
-	rc = cfs_create_thread(osp_precreate_thread, d, 0);
-	if (rc < 0) {
-		CERROR("can't start precreate thread %d\n", rc);
-		RETURN(rc);
+	task = kthread_run(osp_precreate_thread, d,
+			       "osp-pre-%u", d->opd_index);
+	if (IS_ERR(task)) {
+		CERROR("can't start precreate thread %ld\n", PTR_ERR(task));
+		RETURN(PTR_ERR(task));
 	}
 
 	l_wait_event(d->opd_pre_thread.t_ctl_waitq,