X-Git-Url: https://git.whamcloud.com/?a=blobdiff_plain;f=lustre%2Fosd-zfs%2Fosd_handler.c;h=05f51c7ba834cfac9338cd9e9ff5b74e01a2f295;hb=21d716e6c16424d9deb646456758ebbaa9c70fec;hp=d4193cd8b0c11aec64ec344e888fbb9703861b2f;hpb=342c14842fa996181e5d5764701585b1b2f6d6cb;p=fs%2Flustre-release.git

diff --git a/lustre/osd-zfs/osd_handler.c b/lustre/osd-zfs/osd_handler.c
index d4193cd..05f51c7 100644
--- a/lustre/osd-zfs/osd_handler.c
+++ b/lustre/osd-zfs/osd_handler.c
@@ -163,7 +163,7 @@ static void osd_trans_commit_cb(void *cb_data, int error)
 	th->th_dev = NULL;
 	lu_context_exit(&th->th_ctx);
 	lu_context_fini(&th->th_ctx);
-	OBD_FREE_PTR(oh);
+	thandle_put(&oh->ot_super);
 
 	EXIT;
 }
@@ -227,7 +227,8 @@ static int osd_trans_start(const struct lu_env *env, struct dt_device *d,
 /*
  * Concurrency: shouldn't matter.
  */
-static int osd_trans_stop(const struct lu_env *env, struct thandle *th)
+static int osd_trans_stop(const struct lu_env *env, struct dt_device *dt,
+			  struct thandle *th)
 {
 	struct osd_device	*osd = osd_dt_dev(th->th_dev);
 	struct osd_thandle	*oh;
@@ -244,7 +245,7 @@ static int osd_trans_stop(const struct lu_env *env, struct thandle *th)
 		/* there won't be any commit, release reserved quota space now,
 		 * if any */
 		qsd_op_end(env, osd->od_quota_slave, &oh->ot_quota_trans);
-		OBD_FREE_PTR(oh);
+		thandle_put(&oh->ot_super);
 		RETURN(0);
 	}
 
@@ -304,6 +305,8 @@ static struct thandle *osd_trans_create(const struct lu_env *env,
 	th->th_dev = dt;
 	th->th_result = 0;
 	th->th_tags = LCT_TX_HANDLE;
+	atomic_set(&th->th_refc, 1);
+	th->th_alloc_size = sizeof(*oh);
 	RETURN(th);
 }
 
@@ -513,7 +516,8 @@ static int osd_mount(const struct lu_env *env,
 		     struct osd_device *o, struct lustre_cfg *cfg)
 {
 	struct dsl_dataset	*ds;
-	char			*dev  = lustre_cfg_string(cfg, 1);
+	char			*mntdev = lustre_cfg_string(cfg, 1);
+	char			*svname = lustre_cfg_string(cfg, 4);
 	dmu_buf_t		*rootdb;
 	dsl_pool_t		*dp;
 	int			 rc;
@@ -522,12 +526,16 @@ static int osd_mount(const struct lu_env *env,
 	if (o->od_objset.os != NULL)
 		RETURN(0);
 
-	if (strlen(dev) >= sizeof(o->od_mntdev))
+	if (mntdev == NULL || svname == NULL)
+		RETURN(-EINVAL);
+
+	rc = strlcpy(o->od_mntdev, mntdev, sizeof(o->od_mntdev));
+	if (rc >= sizeof(o->od_mntdev))
 		RETURN(-E2BIG);
 
-	strcpy(o->od_mntdev, dev);
-	strncpy(o->od_svname, lustre_cfg_string(cfg, 4),
-		sizeof(o->od_svname) - 1);
+	rc = strlcpy(o->od_svname, svname, sizeof(o->od_svname));
+	if (rc >= sizeof(o->od_svname))
+		RETURN(-E2BIG);
 
 	if (server_name_is_ost(o->od_svname))
 		o->od_is_ost = 1;
@@ -714,8 +722,10 @@ static struct lu_device *osd_device_fini(const struct lu_env *env,
 		if (rc)
 			CERROR("%s: dsl_prop_unregister xattr error %d\n",
 				o->od_svname, rc);
-		arc_remove_prune_callback(o->arc_prune_cb);
-		o->arc_prune_cb = NULL;
+		if (o->arc_prune_cb != NULL) {
+			arc_remove_prune_callback(o->arc_prune_cb);
+			o->arc_prune_cb = NULL;
+		}
 		osd_sync(env, lu2dt_dev(d));
 		txg_wait_callbacks(spa_get_dsl(dmu_objset_spa(o->od_objset.os)));
 	}
@@ -758,12 +768,13 @@ static int osd_process_config(const struct lu_env *env,
 		break;
 	case LCFG_PARAM: {
 		LASSERT(&o->od_dt_dev);
-		rc = class_process_proc_param(PARAM_OSD, lprocfs_osd_obd_vars,
-					      cfg, &o->od_dt_dev);
+		rc = class_process_proc_seq_param(PARAM_OSD,
+						  lprocfs_osd_obd_vars, cfg,
+						  &o->od_dt_dev);
 		if (rc > 0 || rc == -ENOSYS)
-			rc = class_process_proc_param(PARAM_OST,
-						      lprocfs_osd_obd_vars,
-						      cfg, &o->od_dt_dev);
+			rc = class_process_proc_seq_param(PARAM_OST,
+							  lprocfs_osd_obd_vars,
+							  cfg, &o->od_dt_dev);
 		break;
 	}
 	default:
@@ -869,6 +880,14 @@ static void osd_type_stop(struct lu_device_type *t)
 {
 }
 
+int osd_fid_alloc(const struct lu_env *env, struct obd_export *exp,
+		  struct lu_fid *fid, struct md_op_data *op_data)
+{
+	struct osd_device *osd = osd_dev(exp->exp_obd->obd_lu_dev);
+
+	return seq_client_alloc_fid(env, osd->od_cl_seq, fid);
+}
+
 static struct lu_device_type_operations osd_device_type_ops = {
 	.ldto_init		= osd_type_init,
 	.ldto_fini		= osd_type_fini,
@@ -894,7 +913,8 @@ static struct lu_device_type osd_device_type = {
 static struct obd_ops osd_obd_device_ops = {
 	.o_owner       = THIS_MODULE,
 	.o_connect	= osd_obd_connect,
-	.o_disconnect	= osd_obd_disconnect
+	.o_disconnect	= osd_obd_disconnect,
+	.o_fid_alloc	= osd_fid_alloc
 };
 
 int __init osd_init(void)
@@ -909,11 +929,11 @@ int __init osd_init(void)
 	if (rc)
 		return rc;
 
-	rc = class_register_type(&osd_obd_device_ops, NULL, NULL,
+	rc = class_register_type(&osd_obd_device_ops, NULL, true, NULL,
 #ifndef HAVE_ONLY_PROCFS_SEQ
-				lprocfs_osd_module_vars,
+				 NULL,
 #endif
-				LUSTRE_OSD_ZFS_NAME, &osd_device_type);
+				 LUSTRE_OSD_ZFS_NAME, &osd_device_type);
 	if (rc)
 		lu_kmem_fini(osd_caches);
 	return rc;