X-Git-Url: https://git.whamcloud.com/?a=blobdiff_plain;f=lustre%2Fofd%2Fofd_io.c;h=6a81d8784b42873319b50fa5dd4be0888afe8b15;hb=642b095568a9bc6aec68a85d9e46dbe1b8c7d1c0;hp=b52405475926691f550bcfe06949d4a2aa07bece;hpb=2c67b17fd183ef60baba74e914e96b9b292bfc39;p=fs%2Flustre-release.git

diff --git a/lustre/ofd/ofd_io.c b/lustre/ofd/ofd_io.c
index b524054..6a81d87 100644
--- a/lustre/ofd/ofd_io.c
+++ b/lustre/ofd/ofd_io.c
@@ -42,9 +42,325 @@
 
 #include "ofd_internal.h"
 
+struct ofd_inconsistency_item {
+	struct list_head	 oii_list;
+	struct ofd_object	*oii_obj;
+	struct lu_fid		 oii_pfid;
+};
+
+static void ofd_inconsistency_verify_one(const struct lu_env *env,
+					 struct ofd_device *ofd,
+					 struct ofd_inconsistency_item *oii,
+					 struct lfsck_request *lr)
+{
+	struct ofd_object	*fo	= oii->oii_obj;
+	struct lu_fid		*pfid	= &fo->ofo_pfid;
+	int			 rc;
+
+	LASSERT(fo->ofo_pfid_checking);
+	LASSERT(!fo->ofo_pfid_verified);
+
+	lr->lr_fid = fo->ofo_header.loh_fid; /* OST-object itself FID. */
+	lr->lr_fid2 = oii->oii_pfid; /* client given PFID. */
+	lr->lr_fid3 = *pfid; /* OST local stored PFID. */
+
+	rc = lfsck_in_notify(env, ofd->ofd_osd, lr);
+	ofd_write_lock(env, fo);
+	switch (lr->lr_status) {
+	case LPVS_INIT:
+		LASSERT(rc <= 0);
+
+		if (rc < 0)
+			CDEBUG(D_LFSCK, "%s: fail to verify OST local stored "
+			       "PFID xattr for "DFID", the client given PFID "
+			       DFID", OST local stored PFID "DFID": rc = %d\n",
+			       ofd_obd(ofd)->obd_name,
+			       PFID(&fo->ofo_header.loh_fid),
+			       PFID(&oii->oii_pfid), PFID(pfid), rc);
+		else
+			fo->ofo_pfid_verified = 1;
+		break;
+	case LPVS_INCONSISTENT:
+		LASSERT(rc != 0);
+
+		ofd->ofd_inconsistency_self_detected++;
+		if (rc < 0)
+			CDEBUG(D_LFSCK, "%s: fail to verify the client given "
+			       "PFID for "DFID", the client given PFID "DFID
+			       ", local stored PFID "DFID": rc = %d\n",
+			       ofd_obd(ofd)->obd_name,
+			       PFID(&fo->ofo_header.loh_fid),
+			       PFID(&oii->oii_pfid), PFID(pfid), rc);
+		else
+			CDEBUG(D_LFSCK, "%s: both the client given PFID and "
+			       "the OST local stored PFID are stale for the "
+			       "OST-object "DFID", client given PFID is "DFID
+			       ", local stored PFID is "DFID"\n",
+			       ofd_obd(ofd)->obd_name,
+			       PFID(&fo->ofo_header.loh_fid),
+			       PFID(&oii->oii_pfid), PFID(pfid));
+		break;
+	case LPVS_INCONSISTENT_TOFIX:
+		ofd->ofd_inconsistency_self_detected++;
+		if (rc == 0) {
+			ofd->ofd_inconsistency_self_repaired++;
+			CDEBUG(D_LFSCK, "%s: fixed the staled OST PFID xattr "
+			       "for "DFID", with the client given PFID "DFID
+			       ", the old stored PFID "DFID"\n",
+			       ofd_obd(ofd)->obd_name,
+			       PFID(&fo->ofo_header.loh_fid),
+			       PFID(&oii->oii_pfid), PFID(pfid));
+		} else {
+			CDEBUG(D_LFSCK, "%s: fail to fix the OST PFID xattr "
+			       "for "DFID", client given PFID "DFID", local "
+			       "stored PFID "DFID": rc = %d\n",
+			       ofd_obd(ofd)->obd_name,
+			       PFID(&fo->ofo_header.loh_fid),
+			       PFID(&oii->oii_pfid), PFID(pfid), rc);
+		}
+		*pfid = oii->oii_pfid;
+		fo->ofo_pfid_verified = 1;
+		break;
+	default:
+		break;
+	}
+	fo->ofo_pfid_checking = 0;
+	ofd_write_unlock(env, fo);
+
+	lu_object_put(env, &fo->ofo_obj.do_lu);
+	OBD_FREE_PTR(oii);
+}
+
+static int ofd_inconsistency_verification_main(void *args)
+{
+	struct lu_env		       env;
+	struct ofd_device	      *ofd    = args;
+	struct ptlrpc_thread	      *thread = &ofd->ofd_inconsistency_thread;
+	struct ofd_inconsistency_item *oii;
+	struct lfsck_request	      *lr     = NULL;
+	struct l_wait_info	       lwi    = { 0 };
+	int			       rc;
+	ENTRY;
+
+	rc = lu_env_init(&env, LCT_DT_THREAD);
+	spin_lock(&ofd->ofd_inconsistency_lock);
+	thread_set_flags(thread, rc != 0 ? SVC_STOPPED : SVC_RUNNING);
+	wake_up_all(&thread->t_ctl_waitq);
+	spin_unlock(&ofd->ofd_inconsistency_lock);
+	if (rc != 0)
+		RETURN(rc);
+
+	OBD_ALLOC_PTR(lr);
+	if (unlikely(lr == NULL))
+		GOTO(out, rc = -ENOMEM);
+
+	lr->lr_event = LE_PAIRS_VERIFY;
+	lr->lr_active = LT_LAYOUT;
+
+	spin_lock(&ofd->ofd_inconsistency_lock);
+	while (1) {
+		if (unlikely(!thread_is_running(thread)))
+			break;
+
+		while (!list_empty(&ofd->ofd_inconsistency_list)) {
+			oii = list_entry(ofd->ofd_inconsistency_list.next,
+					 struct ofd_inconsistency_item,
+					 oii_list);
+			list_del_init(&oii->oii_list);
+			spin_unlock(&ofd->ofd_inconsistency_lock);
+			ofd_inconsistency_verify_one(&env, ofd, oii, lr);
+			spin_lock(&ofd->ofd_inconsistency_lock);
+		}
+
+		spin_unlock(&ofd->ofd_inconsistency_lock);
+		l_wait_event(thread->t_ctl_waitq,
+			     !list_empty(&ofd->ofd_inconsistency_list) ||
+			     !thread_is_running(thread),
+			     &lwi);
+		spin_lock(&ofd->ofd_inconsistency_lock);
+	}
+
+	while (!list_empty(&ofd->ofd_inconsistency_list)) {
+		struct ofd_object *fo;
+
+		oii = list_entry(ofd->ofd_inconsistency_list.next,
+				 struct ofd_inconsistency_item,
+				 oii_list);
+		list_del_init(&oii->oii_list);
+		fo = oii->oii_obj;
+		spin_unlock(&ofd->ofd_inconsistency_lock);
+
+		ofd_write_lock(&env, fo);
+		fo->ofo_pfid_checking = 0;
+		ofd_write_unlock(&env, fo);
+
+		lu_object_put(&env, &fo->ofo_obj.do_lu);
+		OBD_FREE_PTR(oii);
+		spin_lock(&ofd->ofd_inconsistency_lock);
+	}
+
+	OBD_FREE_PTR(lr);
+
+	GOTO(out, rc = 0);
+
+out:
+	thread_set_flags(thread, SVC_STOPPED);
+	wake_up_all(&thread->t_ctl_waitq);
+	spin_unlock(&ofd->ofd_inconsistency_lock);
+	lu_env_fini(&env);
+
+	return rc;
+}
+
+int ofd_start_inconsistency_verification_thread(struct ofd_device *ofd)
+{
+	struct ptlrpc_thread	*thread = &ofd->ofd_inconsistency_thread;
+	struct l_wait_info	 lwi	= { 0 };
+	long			 rc;
+
+	spin_lock(&ofd->ofd_inconsistency_lock);
+	if (unlikely(thread_is_running(thread))) {
+		spin_unlock(&ofd->ofd_inconsistency_lock);
+
+		return -EALREADY;
+	}
+
+	thread_set_flags(thread, 0);
+	spin_unlock(&ofd->ofd_inconsistency_lock);
+	rc = PTR_ERR(kthread_run(ofd_inconsistency_verification_main, ofd,
+				 "inconsistency_verification"));
+	if (IS_ERR_VALUE(rc)) {
+		CERROR("%s: cannot start self_repair thread: rc = %ld\n",
+		       ofd_obd(ofd)->obd_name, rc);
+	} else {
+		rc = 0;
+		l_wait_event(thread->t_ctl_waitq,
+			     thread_is_running(thread) ||
+			     thread_is_stopped(thread),
+			     &lwi);
+	}
+
+	return rc;
+}
+
+int ofd_stop_inconsistency_verification_thread(struct ofd_device *ofd)
+{
+	struct ptlrpc_thread	*thread = &ofd->ofd_inconsistency_thread;
+	struct l_wait_info	 lwi	= { 0 };
+
+	spin_lock(&ofd->ofd_inconsistency_lock);
+	if (thread_is_init(thread) || thread_is_stopped(thread)) {
+		spin_unlock(&ofd->ofd_inconsistency_lock);
+
+		return -EALREADY;
+	}
+
+	thread_set_flags(thread, SVC_STOPPING);
+	spin_unlock(&ofd->ofd_inconsistency_lock);
+	wake_up_all(&thread->t_ctl_waitq);
+	l_wait_event(thread->t_ctl_waitq,
+		     thread_is_stopped(thread),
+		     &lwi);
+
+	return 0;
+}
+
+static void ofd_add_inconsistency_item(const struct lu_env *env,
+				       struct ofd_object *fo, struct obdo *oa)
+{
+	struct ofd_device		*ofd	= ofd_obj2dev(fo);
+	struct ofd_inconsistency_item	*oii;
+	bool				 wakeup = false;
+
+	OBD_ALLOC_PTR(oii);
+	if (oii == NULL) {
+		CERROR("%s: cannot alloc memory for verify OST-object "
+		       "consistency for "DFID", client given PFID "DFID
+		       ", local stored PFID "DFID"\n",
+		       ofd_obd(ofd)->obd_name, PFID(&fo->ofo_header.loh_fid),
+		       oa->o_parent_seq, oa->o_parent_oid, oa->o_stripe_idx,
+		       PFID(&fo->ofo_pfid));
+
+		return;
+	}
+
+	INIT_LIST_HEAD(&oii->oii_list);
+	lu_object_get(&fo->ofo_obj.do_lu);
+	oii->oii_obj = fo;
+	oii->oii_pfid.f_seq = oa->o_parent_seq;
+	oii->oii_pfid.f_oid = oa->o_parent_oid;
+	oii->oii_pfid.f_stripe_idx = oa->o_stripe_idx;
+
+	spin_lock(&ofd->ofd_inconsistency_lock);
+	if (fo->ofo_pfid_checking || fo->ofo_pfid_verified) {
+		spin_unlock(&ofd->ofd_inconsistency_lock);
+		OBD_FREE_PTR(oii);
+
+		return;
+	}
+
+	fo->ofo_pfid_checking = 1;
+	if (list_empty(&ofd->ofd_inconsistency_list))
+		wakeup = true;
+	list_add_tail(&oii->oii_list, &ofd->ofd_inconsistency_list);
+	spin_unlock(&ofd->ofd_inconsistency_lock);
+	if (wakeup)
+		wake_up_all(&ofd->ofd_inconsistency_thread.t_ctl_waitq);
+
+	/* XXX: When the found inconsistency exceeds some threshold,
+	 *	we can trigger the LFSCK to scan part of the system
+	 *	or the whole system, which depends on how to define
+	 *	the threshold, a simple way maybe like that: define
+	 *	the absolute value of how many inconsisteny allowed
+	 *	to be repaired via self detect/repair mechanism, if
+	 *	exceeded, then trigger the LFSCK to scan the layout
+	 *	inconsistency within the whole system. */
+}
+
+int ofd_verify_ff(const struct lu_env *env, struct ofd_object *fo,
+		  struct obdo *oa)
+{
+	struct lu_fid	*pfid	= &fo->ofo_pfid;
+	int		 rc	= 0;
+	ENTRY;
+
+	if (fid_is_sane(pfid)) {
+		if (likely(oa->o_parent_seq == pfid->f_seq &&
+			   oa->o_parent_oid == pfid->f_oid &&
+			   oa->o_stripe_idx == pfid->f_stripe_idx))
+			RETURN(0);
+
+		if (fo->ofo_pfid_verified)
+			RETURN(-EPERM);
+	}
+
+	/* The OST-object may be inconsistent, and we need further verification.
+	 * To avoid block the RPC service thread, return -EINPROGRESS to client
+	 * and make it retry later. */
+	if (fo->ofo_pfid_checking)
+		RETURN(-EINPROGRESS);
+
+	rc = ofd_object_ff_load(env, fo);
+	if (rc == -ENODATA)
+		RETURN(0);
+
+	if (rc < 0)
+		RETURN(rc);
+
+	if (likely(oa->o_parent_seq == pfid->f_seq &&
+		   oa->o_parent_oid == pfid->f_oid &&
+		   oa->o_stripe_idx == pfid->f_stripe_idx))
+		RETURN(0);
+
+	/* Push it to the dedicated thread for further verification. */
+	ofd_add_inconsistency_item(env, fo, oa);
+
+	RETURN(-EINPROGRESS);
+}
+
 static int ofd_preprw_read(const struct lu_env *env, struct obd_export *exp,
 			   struct ofd_device *ofd, const struct lu_fid *fid,
-			   struct lu_attr *la, int niocount,
+			   struct lu_attr *la, struct obdo *oa, int niocount,
 			   struct niobuf_remote *rnb, int *nr_local,
 			   struct niobuf_local *lnb, char *jobid)
 {
@@ -63,6 +379,12 @@ static int ofd_preprw_read(const struct lu_env *env, struct obd_export *exp,
 	if (!ofd_object_exists(fo))
 		GOTO(unlock, rc = -ENOENT);
 
+	if (ofd->ofd_lfsck_verify_pfid && oa->o_valid & OBD_MD_FLFID) {
+		rc = ofd_verify_ff(env, fo, oa);
+		if (rc != 0)
+			GOTO(unlock, rc);
+	}
+
 	/* parse remote buffers to local buffers and prepare the latter */
 	*nr_local = 0;
 	for (i = 0, j = 0; i < niocount; i++) {
@@ -148,6 +470,15 @@ static int ofd_preprw_write(const struct lu_env *env, struct obd_export *exp,
 		GOTO(out, rc = -ENOENT);
 	}
 
+	if (ofd->ofd_lfsck_verify_pfid && oa->o_valid & OBD_MD_FLFID) {
+		rc = ofd_verify_ff(env, fo, oa);
+		if (rc != 0) {
+			ofd_read_unlock(env, fo);
+			ofd_object_put(env, fo);
+			GOTO(out, rc);
+		}
+	}
+
 	/* Process incoming grant info, set OBD_BRW_GRANTED flag and grant some
 	 * space back if possible */
 	ofd_grant_prepare_write(env, exp, oa, rnb, obj->ioo_bufcnt);
@@ -268,8 +599,9 @@ int ofd_preprw(const struct lu_env *env, int cmd, struct obd_export *exp,
 		if (rc == 0) {
 			ofd_grant_prepare_read(env, exp, oa);
 			rc = ofd_preprw_read(env, exp, ofd, fid,
-					     &info->fti_attr, obj->ioo_bufcnt,
-					     rnb, nr_local, lnb, jobid);
+					     &info->fti_attr, oa,
+					     obj->ioo_bufcnt, rnb, nr_local,
+					     lnb, jobid);
 			obdo_from_la(oa, &info->fti_attr, LA_ATIME);
 		}
 	} else {
@@ -332,7 +664,7 @@ ofd_write_attr_set(const struct lu_env *env, struct ofd_device *ofd,
 		GOTO(out, rc);
 
 	if (ff != NULL) {
-		rc = ofd_object_ff_check(env, ofd_obj);
+		rc = ofd_object_ff_load(env, ofd_obj);
 		if (rc == -ENODATA)
 			ff_needed = 1;
 		else if (rc < 0)
@@ -384,13 +716,25 @@ ofd_write_attr_set(const struct lu_env *env, struct ofd_device *ofd,
 
 	/* set filter fid EA */
 	if (ff_needed) {
+		if (OBD_FAIL_CHECK(OBD_FAIL_LFSCK_NOPFID))
+			GOTO(out_tx, rc);
+
 		rc = dt_xattr_set(env, dt_obj, &info->fti_buf, XATTR_NAME_FID,
 				  0, th, BYPASS_CAPA);
-		if (rc)
-			GOTO(out_tx, rc);
+		if (rc == 0) {
+			ofd_obj->ofo_pfid.f_seq = le64_to_cpu(ff->ff_parent.f_seq);
+			ofd_obj->ofo_pfid.f_oid = le32_to_cpu(ff->ff_parent.f_oid);
+			/* Currently, the filter_fid::ff_parent::f_ver is not
+			 * the real parent MDT-object's FID::f_ver, instead it
+			 * is the OST-object index in its parent MDT-object's
+			 * layout EA. */
+			ofd_obj->ofo_pfid.f_stripe_idx =
+					le32_to_cpu(ff->ff_parent.f_stripe_idx);
+		}
 	}
 
-	EXIT;
+	GOTO(out_tx, rc);
+
 out_tx:
 	dt_trans_stop(env, ofd->ofd_osd, th);
 out: