X-Git-Url: https://git.whamcloud.com/?a=blobdiff_plain;f=lustre%2Fmdt%2Fmdt_xattr.c;h=5fd6ffc1eef919b7735d03961a9ed112bc150d7c;hb=9ca726ac69b07c7fdc8d134df303c3360f7feb02;hp=83ecc742f93311ed2cf4672aed387919b3b21728;hpb=3db2db358a6e427bd7461c52dbd498de808a6659;p=fs%2Flustre-release.git diff --git a/lustre/mdt/mdt_xattr.c b/lustre/mdt/mdt_xattr.c index 83ecc74..5fd6ffc 100644 --- a/lustre/mdt/mdt_xattr.c +++ b/lustre/mdt/mdt_xattr.c @@ -1,32 +1,46 @@ /* -*- mode: c; c-basic-offset: 8; indent-tabs-mode: nil; -*- * vim:expandtab:shiftwidth=8:tabstop=8: * - * linux/mdt/mdt_xattr.c - * Lustre Metadata Target (mdt) extended attributes management. + * GPL HEADER START * - * Copyright (C) 2002-2006 Cluster File Systems, Inc. - * Author: Peter Braam - * Author: Andreas Dilger - * Author: Phil Schwan - * Author: Huang Hua + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * - * This file is part of the Lustre file system, http://www.lustre.org - * Lustre is a trademark of Cluster File Systems, Inc. + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 only, + * as published by the Free Software Foundation. * - * You may have signed or agreed to another license before downloading - * this software. If so, you are bound by the terms and conditions - * of that agreement, and the following does not apply to you. See the - * LICENSE file included with this distribution for more information. + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License version 2 for more details (a copy is included + * in the LICENSE file that accompanied this code). * - * If you did not agree to a different license, then this copy of Lustre - * is open source software; you can redistribute it and/or modify it - * under the terms of version 2 of the GNU General Public License as - * published by the Free Software Foundation. + * You should have received a copy of the GNU General Public License + * version 2 along with this program; If not, see + * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf * - * In either case, Lustre is distributed in the hope that it will be - * useful, but WITHOUT ANY WARRANTY; without even the implied warranty - * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * license text for more details. + * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, + * CA 95054 USA or visit www.sun.com if you need additional information or + * have any questions. + * + * GPL HEADER END + */ +/* + * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved. + * Use is subject to license terms. + */ +/* + * This file is part of Lustre, http://www.lustre.org/ + * Lustre is a trademark of Sun Microsystems, Inc. + * + * lustre/mdt/mdt_xattr.c + * + * Lustre Metadata Target (mdt) extended attributes management. + * + * Author: Peter Braam + * Author: Andreas Dilger + * Author: Phil Schwan + * Author: Huang Hua */ #ifndef EXPORT_SYMTAB @@ -34,13 +48,7 @@ #endif #define DEBUG_SUBSYSTEM S_MDS -/* prerequisite for linux/xattr.h */ -#include -/* prerequisite for linux/xattr.h */ -#include -/* XATTR_{REPLACE,CREATE} */ -#include - +#include #include "mdt_internal.h" @@ -54,12 +62,12 @@ static int mdt_getxattr_pack_reply(struct mdt_thread_info * info) static const char user_string[] = "user."; int size, rc; ENTRY; - + if (OBD_FAIL_CHECK(OBD_FAIL_MDS_GETXATTR_PACK)) RETURN(-ENOMEM); /* Determine how many bytes we need */ - if ((valid & OBD_MD_FLXATTR) == OBD_MD_FLXATTR) { + if (valid & OBD_MD_FLXATTR) { xattr_name = req_capsule_client_get(pill, &RMF_NAME); if (!xattr_name) RETURN(-EFAULT); @@ -67,11 +75,11 @@ static int mdt_getxattr_pack_reply(struct mdt_thread_info * info) if (!(req->rq_export->exp_connect_flags & OBD_CONNECT_XATTR) && !strncmp(xattr_name, user_string, sizeof(user_string) - 1)) RETURN(-EOPNOTSUPP); - + size = mo_xattr_get(info->mti_env, mdt_object_child(info->mti_object), &LU_BUF_NULL, xattr_name); - } else if ((valid & OBD_MD_FLXATTRLS) == OBD_MD_FLXATTRLS) { + } else if (valid & OBD_MD_FLXATTRLS) { size = mo_xattr_list(info->mti_env, mdt_object_child(info->mti_object), &LU_BUF_NULL); @@ -114,6 +122,8 @@ int mdt_getxattr(struct mdt_thread_info *info) struct mdt_body *repbody = NULL; struct md_object *next; struct lu_buf *buf; + __u32 remote = exp_connect_rmtclient(info->mti_exp); + __u32 perm; int easize, rc; ENTRY; @@ -133,11 +143,11 @@ int mdt_getxattr(struct mdt_thread_info *info) next = mdt_object_child(info->mti_object); if (info->mti_body->valid & OBD_MD_FLRMTRGETFACL) { - __u32 perm = mdt_identity_get_perm(uc->mu_identity, - med->med_rmtclient, - req->rq_peer.nid); + if (unlikely(!remote)) + GOTO(out, rc = err_serious(-EINVAL)); - LASSERT(med->med_rmtclient); + perm = mdt_identity_get_perm(uc->mu_identity, remote, + req->rq_peer.nid); if (!(perm & CFS_RMTACL_PERM)) GOTO(out, rc = err_serious(-EPERM)); @@ -183,7 +193,9 @@ int mdt_getxattr(struct mdt_thread_info *info) if (rc > 0 && flags != CFS_IC_NOTHING) { int rc1; - LASSERT(med->med_rmtclient); + if (unlikely(!remote)) + GOTO(out, rc = -EINVAL); + rc1 = lustre_posix_acl_xattr_id2client(uc, med->med_idmap, (posix_acl_xattr_header *)(buf->lb_buf), @@ -261,15 +273,13 @@ int mdt_reint_setxattr(struct mdt_thread_info *info, struct mdt_lock_handle *unused) { struct ptlrpc_request *req = mdt_info_req(info); - struct mdt_export_data *med = mdt_req2med(req); struct md_ucred *uc = mdt_ucred(info); - const char user_string[] = "user."; - const char trust_string[] = "trusted."; struct mdt_lock_handle *lh; struct req_capsule *pill = info->mti_pill; const struct lu_env *env = info->mti_env; struct lu_buf *buf = &info->mti_buf; struct mdt_reint_record *rr = &info->mti_rr; + struct md_attr *ma = &info->mti_attr; struct lu_attr *attr = &info->mti_attr.ma_attr; struct mdt_object *obj; struct md_object *child; @@ -279,6 +289,8 @@ int mdt_reint_setxattr(struct mdt_thread_info *info, __u64 lockpart; int rc; posix_acl_xattr_header *new_xattr = NULL; + __u32 remote = exp_connect_rmtclient(info->mti_exp); + __u32 perm; ENTRY; CDEBUG(D_INODE, "setxattr for "DFID"\n", PFID(rr->rr_fid1)); @@ -296,11 +308,11 @@ int mdt_reint_setxattr(struct mdt_thread_info *info, RETURN(rc); if (valid & OBD_MD_FLRMTRSETFACL) { - __u32 perm = mdt_identity_get_perm(uc->mu_identity, - med->med_rmtclient, - req->rq_peer.nid); + if (unlikely(!remote)) + GOTO(out, rc = err_serious(-EINVAL)); - LASSERT(med->med_rmtclient); + perm = mdt_identity_get_perm(uc->mu_identity, remote, + req->rq_peer.nid); if (!(perm & CFS_RMTACL_PERM)) GOTO(out, rc = err_serious(-EPERM)); } @@ -310,14 +322,24 @@ int mdt_reint_setxattr(struct mdt_thread_info *info, if (!xattr_name) GOTO(out, rc = err_serious(-EFAULT)); - if (strncmp(xattr_name, trust_string, sizeof(trust_string) - 1) == 0) { - if (strcmp(xattr_name + 8, XATTR_NAME_LOV) == 0) + if (strncmp(xattr_name, XATTR_USER_PREFIX, + sizeof(XATTR_USER_PREFIX) - 1) == 0) { + if (!(req->rq_export->exp_connect_flags & OBD_CONNECT_XATTR)) + GOTO(out, rc = -EOPNOTSUPP); + if (strcmp(xattr_name, XATTR_NAME_LOV) == 0) GOTO(out, rc = -EACCES); - } + if (strcmp(xattr_name, XATTR_NAME_LMA) == 0) + GOTO(out, rc = 0); + if (strcmp(xattr_name, XATTR_NAME_LINK) == 0) + GOTO(out, rc = 0); + } else if ((valid & OBD_MD_FLXATTR) && + (strncmp(xattr_name, XATTR_NAME_ACL_ACCESS, + sizeof(XATTR_NAME_ACL_ACCESS) - 1) == 0)) { + /* currently lustre limit acl access size */ + xattr_len = req_capsule_get_size(pill, &RMF_EADATA, RCL_CLIENT); - if (!(req->rq_export->exp_connect_flags & OBD_CONNECT_XATTR) && - (strncmp(xattr_name, user_string, sizeof(user_string) - 1) == 0)) { - GOTO(out, rc = -EOPNOTSUPP); + if (xattr_len > LUSTRE_POSIX_ACL_MAX_SIZE) + GOTO(out, -ERANGE); } lockpart = MDS_INODELOCK_UPDATE; @@ -330,8 +352,20 @@ int mdt_reint_setxattr(struct mdt_thread_info *info, if (IS_ERR(obj)) GOTO(out, rc = PTR_ERR(obj)); + info->mti_mos = obj; + rc = mdt_version_get_check_save(info, obj, 0); + if (rc) + GOTO(out_unlock, rc); + + if (unlikely(!(valid & OBD_MD_FLCTIME))) { + CWARN("client miss to set OBD_MD_FLCTIME when " + "setxattr: [object "DFID"] [valid "LPU64"]\n", + PFID(rr->rr_fid1), valid); + attr->la_ctime = cfs_time_current_sec(); + } + attr->la_valid = LA_CTIME; child = mdt_object_child(obj); - if ((valid & OBD_MD_FLXATTR) == OBD_MD_FLXATTR) { + if (valid & OBD_MD_FLXATTR) { char * xattr; if (!req_capsule_field_present(pill, &RMF_EADATA, RCL_CLIENT)) { @@ -346,7 +380,9 @@ int mdt_reint_setxattr(struct mdt_thread_info *info, xattr = req_capsule_client_get(pill, &RMF_EADATA); if (valid & OBD_MD_FLRMTLSETFACL) { - LASSERT(med->med_rmtclient); + if (unlikely(!remote)) + GOTO(out_unlock, rc = -EINVAL); + xattr_len = mdt_rmtlsetfacl(info, child, xattr_name, (ext_acl_xattr_header *)xattr, @@ -369,9 +405,19 @@ int mdt_reint_setxattr(struct mdt_thread_info *info, buf->lb_buf = xattr; buf->lb_len = xattr_len; rc = mo_xattr_set(env, child, buf, xattr_name, flags); + /* update ctime after xattr changed */ + if (rc == 0) { + ma->ma_attr_flags |= MDS_PERM_BYPASS; + mo_attr_set(env, child, ma); + } } - } else if ((valid & OBD_MD_FLXATTRRM) == OBD_MD_FLXATTRRM) { + } else if (valid & OBD_MD_FLXATTRRM) { rc = mo_xattr_del(env, child, xattr_name); + /* update ctime after xattr changed */ + if (rc == 0) { + ma->ma_attr_flags |= MDS_PERM_BYPASS; + mo_attr_set(env, child, ma); + } } else { CDEBUG(D_INFO, "valid bits: "LPX64"\n", valid); rc = -EINVAL;