X-Git-Url: https://git.whamcloud.com/?a=blobdiff_plain;f=lustre%2Fmdt%2Fmdt_hsm_cdt_client.c;h=83626272b2885d75cea95a87150e30557928c9a5;hb=a9c51c03eaecb5234ba754b738877323a35bed51;hp=285818bec225fd9ec4a1756a97f08f775349e433;hpb=b87e99adf44b80308f341cbf143374034f627ab9;p=fs%2Flustre-release.git

diff --git a/lustre/mdt/mdt_hsm_cdt_client.c b/lustre/mdt/mdt_hsm_cdt_client.c
index 285818b..8362627 100644
--- a/lustre/mdt/mdt_hsm_cdt_client.c
+++ b/lustre/mdt/mdt_hsm_cdt_client.c
@@ -39,7 +39,6 @@
 #include <lustre_net.h>
 #include <lustre_export.h>
 #include <obd.h>
-#include <obd_lov.h>
 #include <lprocfs_status.h>
 #include <lustre_log.h>
 #include "mdt_internal.h"
@@ -245,6 +244,43 @@ static bool hal_is_sane(struct hsm_action_list *hal)
 	RETURN(true);
 }
 
+static int
+hsm_action_permission(struct mdt_thread_info *mti,
+		      struct mdt_object *obj,
+		      enum hsm_copytool_action hsma)
+{
+	struct coordinator *cdt = &mti->mti_mdt->mdt_coordinator;
+	struct lu_ucred *uc = mdt_ucred(mti);
+	struct md_attr *ma = &mti->mti_attr;
+	const __u64 *mask;
+	int rc;
+	ENTRY;
+
+	if (hsma != HSMA_RESTORE &&
+	    exp_connect_flags(mti->mti_exp) & OBD_CONNECT_RDONLY)
+		RETURN(-EROFS);
+
+	if (md_capable(uc, CFS_CAP_SYS_ADMIN))
+		RETURN(0);
+
+	ma->ma_need = MA_INODE;
+	rc = mdt_attr_get_complex(mti, obj, ma);
+	if (rc < 0)
+		RETURN(rc);
+
+	if (uc->uc_fsuid == ma->ma_attr.la_uid)
+		mask = &cdt->cdt_user_request_mask;
+	else if (lustre_in_group_p(uc, ma->ma_attr.la_gid))
+		mask = &cdt->cdt_group_request_mask;
+	else
+		mask = &cdt->cdt_other_request_mask;
+
+	if (!(0 <= hsma && hsma < 8 * sizeof(*mask)))
+		RETURN(-EINVAL);
+
+	RETURN(*mask & (1UL << hsma) ? 0 : -EPERM);
+}
+
 /*
  * Coordinator external API
  */
@@ -321,23 +357,30 @@ int mdt_hsm_add_actions(struct mdt_thread_info *mti,
 		 * if restore, we take the layout lock
 		 */
 
-		/* if action is cancel, also no need to check */
-		if (hai->hai_action == HSMA_CANCEL)
-			goto record;
-
-		/* get HSM attributes */
+		/* Get HSM attributes and check permissions. */
 		obj = mdt_hsm_get_md_hsm(mti, &hai->hai_fid, &mh);
-		if (IS_ERR(obj) || obj == NULL) {
-			/* in case of archive remove, Lustre file
-			 * is not mandatory */
-			if (hai->hai_action == HSMA_REMOVE)
+		if (IS_ERR(obj)) {
+			/* In case of REMOVE and CANCEL a Lustre file
+			 * is not mandatory, but restrict this
+			 * exception to admins. */
+			if (md_capable(mdt_ucred(mti), CFS_CAP_SYS_ADMIN) &&
+			    (hai->hai_action == HSMA_REMOVE ||
+			     hai->hai_action == HSMA_CANCEL))
 				goto record;
-			if (obj == NULL)
-				GOTO(out, rc = -ENOENT);
-			GOTO(out, rc = PTR_ERR(obj));
+			else
+				GOTO(out, rc = PTR_ERR(obj));
 		}
+
+		rc = hsm_action_permission(mti, obj, hai->hai_action);
 		mdt_object_put(mti->mti_env, obj);
 
+		if (rc < 0)
+			GOTO(out, rc);
+
+		/* if action is cancel, also no need to check */
+		if (hai->hai_action == HSMA_CANCEL)
+			goto record;
+
 		/* Check if an action is needed, compare request
 		 * and HSM flags status */
 		if (!hsm_action_is_needed(hai, archive_id, flags, &mh))
@@ -363,7 +406,7 @@ int mdt_hsm_add_actions(struct mdt_thread_info *mti,
 			if (mh.mh_arch_id != 0)
 				archive_id = mh.mh_arch_id;
 			else
-				archive_id = cdt->cdt_archive_id;
+				archive_id = cdt->cdt_default_archive_id;
 		}
 
 		/* if restore, take an exclusive lock on layout */