X-Git-Url: https://git.whamcloud.com/?a=blobdiff_plain;f=lustre%2Fmdd%2Fmdd_lproc.c;h=78366e3fd9edaa959dc76bb9487226040dc85390;hb=9b924e86b27d;hp=2573e330f7479b81e86a98a695047db6bf305efe;hpb=7e81f13c4a852cdba9fbebcc2b6385d6c2effa4b;p=fs%2Flustre-release.git

diff --git a/lustre/mdd/mdd_lproc.c b/lustre/mdd/mdd_lproc.c
index 2573e33..78366e3 100644
--- a/lustre/mdd/mdd_lproc.c
+++ b/lustre/mdd/mdd_lproc.c
@@ -15,11 +15,7 @@
  *
  * You should have received a copy of the GNU General Public License
  * version 2 along with this program; If not, see
- * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf
- *
- * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
- * CA 95054 USA or visit www.sun.com if you need additional information or
- * have any questions.
+ * http://www.gnu.org/licenses/gpl-2.0.html
  *
  * GPL HEADER END
  */
@@ -27,7 +23,7 @@
  * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2012, 2013, Intel Corporation.
+ * Copyright (c) 2012, 2017, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
@@ -49,111 +45,60 @@
 #include <libcfs/libcfs_string.h>
 #include "mdd_internal.h"
 
-int mdd_procfs_init(struct mdd_device *mdd, const char *name)
+static ssize_t
+mdd_atime_diff_seq_write(struct file *file, const char __user *buffer,
+			 size_t count, loff_t *off)
 {
-        struct lprocfs_static_vars lvars;
-        struct obd_type     *type;
-        int                  rc;
-        ENTRY;
-
-	/* at the moment there is no linkage between lu_type
-	 * and obd_type, so we lookup obd_type this way */
-	type = class_search_type(LUSTRE_MDD_NAME);
-
-        LASSERT(name != NULL);
-        LASSERT(type != NULL);
-
-        /* Find the type procroot and add the proc entry for this device */
-        lprocfs_mdd_init_vars(&lvars);
-        mdd->mdd_proc_entry = lprocfs_register(name, type->typ_procroot,
-                                               lvars.obd_vars, mdd);
-        if (IS_ERR(mdd->mdd_proc_entry)) {
-                rc = PTR_ERR(mdd->mdd_proc_entry);
-                CERROR("Error %d setting up lprocfs for %s\n",
-                       rc, name);
-                mdd->mdd_proc_entry = NULL;
-                GOTO(out, rc);
-        }
-
-	rc = 0;
-
-        EXIT;
-out:
-        if (rc)
-               mdd_procfs_fini(mdd);
-        return rc;
-}
-
-int mdd_procfs_fini(struct mdd_device *mdd)
-{
-        if (mdd->mdd_proc_entry) {
-                 lprocfs_remove(&mdd->mdd_proc_entry);
-                 mdd->mdd_proc_entry = NULL;
-        }
-        RETURN(0);
-}
-
-static int lprocfs_wr_atime_diff(struct file *file, const char *buffer,
-                                 unsigned long count, void *data)
-{
-        struct mdd_device *mdd = data;
-        char kernbuf[20], *end;
-        unsigned long diff = 0;
-
-        if (count > (sizeof(kernbuf) - 1))
-                return -EINVAL;
-
-	if (copy_from_user(kernbuf, buffer, count))
-                return -EFAULT;
-
-        kernbuf[count] = '\0';
+	struct seq_file *m = file->private_data;
+	struct mdd_device *mdd = m->private;
+	time64_t diff = 0;
+	int rc;
 
-        diff = simple_strtoul(kernbuf, &end, 0);
-        if (kernbuf == end)
-                return -EINVAL;
+	rc = kstrtoll_from_user(buffer, count, 0, &diff);
+	if (rc)
+		return rc;
 
         mdd->mdd_atime_diff = diff;
         return count;
 }
 
-static int lprocfs_rd_atime_diff(char *page, char **start, off_t off,
-                                 int count, int *eof, void *data)
+static int mdd_atime_diff_seq_show(struct seq_file *m, void *data)
 {
-        struct mdd_device *mdd = data;
+	struct mdd_device *mdd = m->private;
 
-        *eof = 1;
-        return snprintf(page, count, "%lu\n", mdd->mdd_atime_diff);
+	seq_printf(m, "%lld\n", mdd->mdd_atime_diff);
+	return 0;
 }
-
+LPROC_SEQ_FOPS(mdd_atime_diff);
 
 /**** changelogs ****/
-static int lprocfs_rd_changelog_mask(char *page, char **start, off_t off,
-                                     int count, int *eof, void *data)
+static int mdd_changelog_mask_seq_show(struct seq_file *m, void *data)
 {
-        struct mdd_device *mdd = data;
-        int i = 0, rc = 0;
-
-        *eof = 1;
-        while (i < CL_LAST) {
-                if (mdd->mdd_cl.mc_mask & (1 << i))
-                        rc += snprintf(page + rc, count - rc, "%s ",
-                                       changelog_type2str(i));
-                i++;
-        }
-        return rc;
+	struct mdd_device *mdd = m->private;
+	int i = 0;
+
+	while (i < CL_LAST) {
+		if (mdd->mdd_cl.mc_mask & (1 << i))
+			seq_printf(m, "%s ", changelog_type2str(i));
+		i++;
+	}
+	seq_putc(m, '\n');
+	return 0;
 }
 
-static int lprocfs_wr_changelog_mask(struct file *file, const char *buffer,
-				     unsigned long count, void *data)
+static ssize_t
+mdd_changelog_mask_seq_write(struct file *file, const char __user *buffer,
+			     size_t count, loff_t *off)
 {
-	struct mdd_device *mdd = data;
+	struct seq_file *m = file->private_data;
+	struct mdd_device *mdd = m->private;
 	char *kernbuf;
 	int rc;
 	ENTRY;
 
-	if (count >= PAGE_CACHE_SIZE)
+	if (count >= PAGE_SIZE)
 		RETURN(-EINVAL);
-	OBD_ALLOC(kernbuf, PAGE_CACHE_SIZE);
+	OBD_ALLOC(kernbuf, PAGE_SIZE);
 	if (kernbuf == NULL)
 		RETURN(-ENOMEM);
 	if (copy_from_user(kernbuf, buffer, count))
@@ -165,48 +110,36 @@ static int lprocfs_wr_changelog_mask(struct file *file, const char *buffer,
 	if (rc == 0)
 		rc = count;
 out:
-	OBD_FREE(kernbuf, PAGE_CACHE_SIZE);
+	OBD_FREE(kernbuf, PAGE_SIZE);
 	return rc;
 }
-
-struct cucb_data {
-        char *page;
-        int count;
-        int idx;
-};
+LPROC_SEQ_FOPS(mdd_changelog_mask);
 
 static int lprocfs_changelog_users_cb(const struct lu_env *env,
 				      struct llog_handle *llh,
 				      struct llog_rec_hdr *hdr, void *data)
 {
-        struct llog_changelog_user_rec *rec;
-        struct cucb_data *cucb = (struct cucb_data *)data;
-
-        LASSERT(llh->lgh_hdr->llh_flags & LLOG_F_IS_PLAIN);
+	struct llog_changelog_user_rec *rec;
+	struct seq_file *m = data;
 
-        rec = (struct llog_changelog_user_rec *)hdr;
+	LASSERT(llh->lgh_hdr->llh_flags & LLOG_F_IS_PLAIN);
 
-        cucb->idx += snprintf(cucb->page + cucb->idx, cucb->count - cucb->idx,
-                              CHANGELOG_USER_PREFIX"%-3d "LPU64"\n",
-                              rec->cur_id, rec->cur_endrec);
-        if (cucb->idx >= cucb->count)
-                return -ENOSPC;
+	rec = (struct llog_changelog_user_rec *)hdr;
 
-        return 0;
+	seq_printf(m, CHANGELOG_USER_PREFIX"%-3d %llu (%u)\n",
+		   rec->cur_id, rec->cur_endrec, (__u32)get_seconds() -
+						 rec->cur_time);
+	return 0;
 }
 
-static int lprocfs_rd_changelog_users(char *page, char **start, off_t off,
-                                      int count, int *eof, void *data)
+static int mdd_changelog_users_seq_show(struct seq_file *m, void *data)
 {
 	struct lu_env		 env;
-	struct mdd_device	*mdd = data;
+	struct mdd_device	*mdd = m->private;
 	struct llog_ctxt	*ctxt;
-	struct cucb_data	 cucb;
 	__u64			 cur;
 	int			 rc;
 
-        *eof = 1;
-
         ctxt = llog_get_context(mdd2obd_dev(mdd),
 				LLOG_CHANGELOG_USER_ORIG_CTXT);
         if (ctxt == NULL)
@@ -223,141 +156,449 @@ static int lprocfs_rd_changelog_users(char *page, char **start, off_t off,
 	cur = mdd->mdd_cl.mc_index;
 	spin_unlock(&mdd->mdd_cl.mc_lock);
 
-        cucb.count = count;
-        cucb.page = page;
-        cucb.idx = 0;
-
-        cucb.idx += snprintf(cucb.page + cucb.idx, cucb.count - cucb.idx,
-                              "current index: "LPU64"\n", cur);
-
-        cucb.idx += snprintf(cucb.page + cucb.idx, cucb.count - cucb.idx,
-                              "%-5s %s\n", "ID", "index");
+	seq_printf(m, "current index: %llu\n", cur);
+	seq_printf(m, "%-5s %s %s\n", "ID", "index", "(idle seconds)");
 
 	llog_cat_process(&env, ctxt->loc_handle, lprocfs_changelog_users_cb,
-			 &cucb, 0, 0);
+			 m, 0, 0);
 
 	lu_env_fini(&env);
 	llog_ctxt_put(ctxt);
-	return cucb.idx;
+	return 0;
 }
+LPROC_SEQ_FOPS_RO(mdd_changelog_users);
 
-static int lprocfs_rd_sync_perm(char *page, char **start, off_t off,
-                                int count, int *eof, void *data)
+static int mdd_changelog_size_ctxt(const struct lu_env *env,
+				   struct mdd_device *mdd,
+				   int index, __u64 *val)
 {
-        struct mdd_device *mdd = data;
+	struct llog_ctxt	*ctxt;
+
+	ctxt = llog_get_context(mdd2obd_dev(mdd),
+				index);
+	if (ctxt == NULL)
+		return -ENXIO;
 
-        LASSERT(mdd != NULL);
-        return snprintf(page, count, "%d\n", mdd->mdd_sync_permission);
+	if (!(ctxt->loc_handle->lgh_hdr->llh_flags & LLOG_F_IS_CAT)) {
+		CERROR("%s: ChangeLog has wrong flags: rc = %d\n",
+		       ctxt->loc_obd->obd_name, -EINVAL);
+		llog_ctxt_put(ctxt);
+		return -EINVAL;
+	}
+
+	*val += llog_cat_size(env, ctxt->loc_handle);
+
+	llog_ctxt_put(ctxt);
+
+	return 0;
 }
 
-static int lprocfs_wr_sync_perm(struct file *file, const char *buffer,
-                                unsigned long count, void *data)
+static int mdd_changelog_size_seq_show(struct seq_file *m, void *data)
 {
-        struct mdd_device *mdd = data;
-        int val, rc;
+	struct lu_env		 env;
+	struct mdd_device	*mdd = m->private;
+	__u64			 tmp = 0;
+	int			 rc;
 
-        LASSERT(mdd != NULL);
-        rc = lprocfs_write_helper(buffer, count, &val);
-        if (rc)
-                return rc;
+	rc = lu_env_init(&env, LCT_LOCAL);
+	if (rc)
+		return rc;
 
-        mdd->mdd_sync_permission = !!val;
-        return count;
+	rc = mdd_changelog_size_ctxt(&env, mdd, LLOG_CHANGELOG_ORIG_CTXT, &tmp);
+	if (rc) {
+		lu_env_fini(&env);
+		return rc;
+	}
+
+	rc = mdd_changelog_size_ctxt(&env, mdd, LLOG_CHANGELOG_USER_ORIG_CTXT,
+				     &tmp);
+
+	seq_printf(m, "%llu\n", tmp);
+	lu_env_fini(&env);
+	return rc;
 }
+LPROC_SEQ_FOPS_RO(mdd_changelog_size);
 
-static int lprocfs_rd_lfsck_speed_limit(char *page, char **start, off_t off,
-					int count, int *eof, void *data)
+static int mdd_changelog_gc_seq_show(struct seq_file *m, void *data)
 {
-	struct mdd_device *mdd = data;
+	struct mdd_device *mdd = m->private;
+
+	LASSERT(mdd != NULL);
+	seq_printf(m, "%u\n", mdd->mdd_changelog_gc);
+	return 0;
+}
+
+static ssize_t
+mdd_changelog_gc_seq_write(struct file *file, const char __user *buffer,
+			   size_t count, loff_t *off)
+{
+	struct seq_file *m = file->private_data;
+	struct mdd_device *mdd = m->private;
+	bool val;
 	int rc;
 
 	LASSERT(mdd != NULL);
-	*eof = 1;
+	rc = kstrtobool_from_user(buffer, count, &val);
+	if (rc)
+		return rc;
 
-	rc = lfsck_get_speed(mdd->mdd_bottom, page, count);
-	return rc != 0 ? rc : count;
+	mdd->mdd_changelog_gc = val;
+
+	return count;
+}
+LPROC_SEQ_FOPS(mdd_changelog_gc);
+
+static int mdd_changelog_max_idle_time_seq_show(struct seq_file *m, void *data)
+{
+	struct mdd_device *mdd = m->private;
+
+	LASSERT(mdd != NULL);
+	seq_printf(m, "%lld\n", mdd->mdd_changelog_max_idle_time);
+	return 0;
+}
+
+static ssize_t
+mdd_changelog_max_idle_time_seq_write(struct file *file,
+				      const char __user *buffer, size_t count,
+				      loff_t *off)
+{
+	struct seq_file *m = file->private_data;
+	struct mdd_device *mdd = m->private;
+	time64_t val;
+	int rc;
+
+	LASSERT(mdd != NULL);
+
+	rc = kstrtoll_from_user(buffer, count, 0, &val);
+	if (rc)
+		return rc;
+
+	/* as it sounds reasonable, do not allow a user to be idle since
+	 * more than about 68 years, this will allow to use 32bits
+	 * timestamps for comparison
+	 */
+	if (val < 1 || val > INT_MAX)
+		return -ERANGE;
+
+	mdd->mdd_changelog_max_idle_time = val;
+
+	return count;
+}
+LPROC_SEQ_FOPS(mdd_changelog_max_idle_time);
+
+static int mdd_changelog_max_idle_indexes_seq_show(struct seq_file *m,
+						   void *data)
+{
+	struct mdd_device *mdd = m->private;
+
+	LASSERT(mdd != NULL);
+	seq_printf(m, "%lu\n", mdd->mdd_changelog_max_idle_indexes);
+	return 0;
+}
+
+static ssize_t
+mdd_changelog_max_idle_indexes_seq_write(struct file *file,
+					 const char __user *buffer,
+					 size_t count, loff_t *off)
+{
+	struct seq_file *m = file->private_data;
+	struct mdd_device *mdd = m->private;
+	unsigned long val;
+	int rc;
+
+	LASSERT(mdd != NULL);
+	rc = kstrtoul_from_user(buffer, count, 0, &val);
+	if (rc)
+		return rc;
+
+	/* XXX may need to limit/check with reasonable elapsed/idle indexes */
+	/* XXX may better allow to specify a % of full ChangeLogs */
+
+	mdd->mdd_changelog_max_idle_indexes = val;
+
+	return count;
+}
+LPROC_SEQ_FOPS(mdd_changelog_max_idle_indexes);
+
+static int mdd_changelog_min_gc_interval_seq_show(struct seq_file *m,
+						  void *data)
+{
+	struct mdd_device *mdd = m->private;
+
+	LASSERT(mdd != NULL);
+	seq_printf(m, "%lld\n", mdd->mdd_changelog_min_gc_interval);
+	return 0;
+}
+
+static ssize_t
+mdd_changelog_min_gc_interval_seq_write(struct file *file,
+					const char __user *buffer,
+					size_t count, loff_t *off)
+{
+	struct seq_file *m = file->private_data;
+	struct mdd_device *mdd = m->private;
+	time64_t val;
+	int rc;
+
+	LASSERT(mdd != NULL);
+	rc = kstrtoll_from_user(buffer, count, 0, &val);
+	if (rc)
+		return rc;
+
+	/* XXX may need to limit with reasonable elapsed/interval times */
+	if (val < 1)
+		return -ERANGE;
+
+	mdd->mdd_changelog_min_gc_interval = val;
+
+	return count;
+}
+LPROC_SEQ_FOPS(mdd_changelog_min_gc_interval);
+
+static int mdd_changelog_min_free_cat_entries_seq_show(struct seq_file *m,
+						       void *data)
+{
+	struct mdd_device *mdd = m->private;
+
+	LASSERT(mdd != NULL);
+	seq_printf(m, "%u\n", mdd->mdd_changelog_min_free_cat_entries);
+	return 0;
+}
+
+static ssize_t
+mdd_changelog_min_free_cat_entries_seq_write(struct file *file,
+					     const char __user *buffer,
+					     size_t count, loff_t *off)
+{
+	struct seq_file *m = file->private_data;
+	struct mdd_device *mdd = m->private;
+	unsigned int val;
+	int rc;
+
+	LASSERT(mdd != NULL);
+	rc = kstrtouint_from_user(buffer, count, 0, &val);
+	if (rc)
+		return rc;
+
+	/* XXX may need to limit with more reasonable number of free entries */
+	if (val < 1)
+		return -ERANGE;
+
+	mdd->mdd_changelog_min_free_cat_entries = val;
+
+	return count;
+}
+LPROC_SEQ_FOPS(mdd_changelog_min_free_cat_entries);
+
+static int mdd_changelog_deniednext_seq_show(struct seq_file *m, void *data)
+{
+	struct mdd_device *mdd = m->private;
+
+	seq_printf(m, "%u\n", mdd->mdd_cl.mc_deniednext);
+	return 0;
+}
+
+static ssize_t
+mdd_changelog_deniednext_seq_write(struct file *file, const char __user *buffer,
+				   size_t count, loff_t *off)
+{
+	struct seq_file *m = file->private_data;
+	struct mdd_device *mdd = m->private;
+	char kernbuf[11];
+	unsigned int time = 0;
+	int rc;
+
+	if (count > (sizeof(kernbuf) - 1))
+		return -EINVAL;
+
+	if (copy_from_user(kernbuf, buffer, count))
+		return -EFAULT;
+
+	kernbuf[count] = '\0';
+
+	rc = kstrtoul(kernbuf, 0, (unsigned long int *)&time);
+	if (rc)
+		return rc;
+
+	mdd->mdd_cl.mc_deniednext = time;
+	return count;
+}
+LPROC_SEQ_FOPS(mdd_changelog_deniednext);
+
+static int mdd_sync_perm_seq_show(struct seq_file *m, void *data)
+{
+	struct mdd_device *mdd = m->private;
+
+	LASSERT(mdd != NULL);
+	seq_printf(m, "%d\n", mdd->mdd_sync_permission);
+	return 0;
 }
 
-static int lprocfs_wr_lfsck_speed_limit(struct file *file, const char *buffer,
-					unsigned long count, void *data)
+static ssize_t
+mdd_sync_perm_seq_write(struct file *file, const char __user *buffer,
+			size_t count, loff_t *off)
 {
-	struct mdd_device *mdd = data;
-	__u32 val;
+	struct seq_file *m = file->private_data;
+	struct mdd_device *mdd = m->private;
+	bool val;
 	int rc;
 
 	LASSERT(mdd != NULL);
-	rc = lprocfs_write_helper(buffer, count, &val);
+	rc = kstrtobool_from_user(buffer, count, &val);
+	if (rc)
+		return rc;
+
+	mdd->mdd_sync_permission = val;
+
+	return count;
+}
+LPROC_SEQ_FOPS(mdd_sync_perm);
+
+static int mdd_lfsck_speed_limit_seq_show(struct seq_file *m, void *data)
+{
+	struct mdd_device *mdd = m->private;
+
+	LASSERT(mdd != NULL);
+	return lfsck_get_speed(m, NULL, mdd->mdd_bottom);
+}
+
+static ssize_t
+mdd_lfsck_speed_limit_seq_write(struct file *file, const char __user *buffer,
+				size_t count, loff_t *off)
+{
+	struct seq_file *m = file->private_data;
+	struct mdd_device *mdd = m->private;
+	unsigned int val;
+	int rc;
+
+	LASSERT(mdd != NULL);
+	rc = kstrtouint_from_user(buffer, count, 0, &val);
 	if (rc != 0)
 		return rc;
 
 	rc = lfsck_set_speed(mdd->mdd_bottom, val);
 	return rc != 0 ? rc : count;
 }
+LPROC_SEQ_FOPS(mdd_lfsck_speed_limit);
 
-static int lprocfs_rd_lfsck_async_windows(char *page, char **start, off_t off,
-					  int count, int *eof, void *data)
+static int mdd_lfsck_async_windows_seq_show(struct seq_file *m, void *data)
 {
-	struct mdd_device *mdd = data;
-	int		   rc;
+	struct mdd_device *mdd = m->private;
+
+	LASSERT(mdd != NULL);
+	return lfsck_get_windows(m, mdd->mdd_bottom);
+}
+
+static ssize_t
+mdd_lfsck_async_windows_seq_write(struct file *file, const char __user *buffer,
+				  size_t count, loff_t *off)
+{
+	struct seq_file *m = file->private_data;
+	struct mdd_device *mdd = m->private;
+	unsigned int val;
+	int rc;
 
 	LASSERT(mdd != NULL);
-	*eof = 1;
+	rc = kstrtouint_from_user(buffer, count, 0, &val);
+	if (rc)
+		return rc;
 
-	rc = lfsck_get_windows(mdd->mdd_bottom, page, count);
+	rc = lfsck_set_windows(mdd->mdd_bottom, val);
 
 	return rc != 0 ? rc : count;
 }
+LPROC_SEQ_FOPS(mdd_lfsck_async_windows);
 
-static int lprocfs_wr_lfsck_async_windows(struct file *file, const char *buffer,
-					  unsigned long count, void *data)
+static int mdd_lfsck_namespace_seq_show(struct seq_file *m, void *data)
 {
-	struct mdd_device *mdd = data;
-	__u32		   val;
-	int		   rc;
+	struct mdd_device *mdd = m->private;
 
 	LASSERT(mdd != NULL);
-	rc = lprocfs_write_helper(buffer, count, &val);
-	if (rc == 0)
-		rc = lfsck_set_windows(mdd->mdd_bottom, val);
 
-	return rc != 0 ? rc : count;
+	return lfsck_dump(m, mdd->mdd_bottom, LFSCK_TYPE_NAMESPACE);
 }
+LPROC_SEQ_FOPS_RO(mdd_lfsck_namespace);
 
-static int lprocfs_rd_lfsck_namespace(char *page, char **start, off_t off,
-				      int count, int *eof, void *data)
+static int mdd_lfsck_layout_seq_show(struct seq_file *m, void *data)
 {
-	struct mdd_device *mdd = data;
-	int rc;
+	struct mdd_device *mdd = m->private;
 
 	LASSERT(mdd != NULL);
-	*eof = 1;
 
-	rc = lfsck_dump(mdd->mdd_bottom, page, count, LT_NAMESPACE);
-	return rc;
+	return lfsck_dump(m, mdd->mdd_bottom, LFSCK_TYPE_LAYOUT);
 }
+LPROC_SEQ_FOPS_RO(mdd_lfsck_layout);
 
 static struct lprocfs_vars lprocfs_mdd_obd_vars[] = {
-        { "atime_diff",      lprocfs_rd_atime_diff, lprocfs_wr_atime_diff, 0 },
-        { "changelog_mask",  lprocfs_rd_changelog_mask,
-                             lprocfs_wr_changelog_mask, 0 },
-        { "changelog_users", lprocfs_rd_changelog_users, 0, 0},
-        { "sync_permission", lprocfs_rd_sync_perm, lprocfs_wr_sync_perm, 0 },
-	{ "lfsck_speed_limit", lprocfs_rd_lfsck_speed_limit,
-			       lprocfs_wr_lfsck_speed_limit, 0 },
-	{ "lfsck_async_windows", lprocfs_rd_lfsck_async_windows,
-				 lprocfs_wr_lfsck_async_windows, 0 },
-	{ "lfsck_namespace", lprocfs_rd_lfsck_namespace, 0, 0 },
-	{ 0 }
-};
-
-static struct lprocfs_vars lprocfs_mdd_module_vars[] = {
-        { "num_refs",   lprocfs_rd_numrefs, 0, 0 },
-        { 0 }
+	{ .name =	"atime_diff",
+	  .fops =	&mdd_atime_diff_fops		},
+	{ .name =	"changelog_mask",
+	  .fops =	&mdd_changelog_mask_fops	},
+	{ .name =	"changelog_users",
+	  .fops =	&mdd_changelog_users_fops	},
+	{ .name =	"changelog_size",
+	  .fops =	&mdd_changelog_size_fops	},
+	{ .name =	"changelog_gc",
+	  .fops =	&mdd_changelog_gc_fops		},
+	{ .name =	"changelog_max_idle_time",
+	  .fops =	&mdd_changelog_max_idle_time_fops	},
+	{ .name =	"changelog_max_idle_indexes",
+	  .fops =	&mdd_changelog_max_idle_indexes_fops	},
+	{ .name =	"changelog_min_gc_interval",
+	  .fops =	&mdd_changelog_min_gc_interval_fops	},
+	{ .name =	"changelog_min_free_cat_entries",
+	  .fops =	&mdd_changelog_min_free_cat_entries_fops	},
+	{ .name =	"changelog_deniednext",
+	  .fops =	&mdd_changelog_deniednext_fops	},
+	{ .name =	"sync_permission",
+	  .fops =	&mdd_sync_perm_fops		},
+	{ .name =	"lfsck_speed_limit",
+	  .fops =	&mdd_lfsck_speed_limit_fops	},
+	{ .name =	"lfsck_async_windows",
+	  .fops =	&mdd_lfsck_async_windows_fops	},
+	{ .name =	"lfsck_namespace",
+	  .fops =	&mdd_lfsck_namespace_fops	},
+	{ .name	=	"lfsck_layout",
+	  .fops	=	&mdd_lfsck_layout_fops		},
+	{ NULL }
 };
 
-void lprocfs_mdd_init_vars(struct lprocfs_static_vars *lvars)
+int mdd_procfs_init(struct mdd_device *mdd, const char *name)
 {
-        lvars->module_vars  = lprocfs_mdd_module_vars;
-        lvars->obd_vars     = lprocfs_mdd_obd_vars;
+	struct obd_device *obd = mdd2obd_dev(mdd);
+	struct obd_type   *type;
+	int		   rc;
+	ENTRY;
+
+	/* at the moment there is no linkage between lu_type
+	 * and obd_type, so we lookup obd_type this way */
+	type = class_search_type(LUSTRE_MDD_NAME);
+
+	LASSERT(name != NULL);
+	LASSERT(type != NULL);
+	LASSERT(obd  != NULL);
+
+	/* Find the type procroot and add the proc entry for this device */
+	obd->obd_vars = lprocfs_mdd_obd_vars;
+	mdd->mdd_proc_entry = lprocfs_register(name, type->typ_procroot,
+					       obd->obd_vars, mdd);
+	if (IS_ERR(mdd->mdd_proc_entry)) {
+		rc = PTR_ERR(mdd->mdd_proc_entry);
+		CERROR("Error %d setting up lprocfs for %s\n",
+		       rc, name);
+		mdd->mdd_proc_entry = NULL;
+		GOTO(out, rc);
+	}
+	rc = 0;
+	EXIT;
+out:
+	if (rc)
+		mdd_procfs_fini(mdd);
+	return rc;
 }
 
+void mdd_procfs_fini(struct mdd_device *mdd)
+{
+	if (mdd->mdd_proc_entry)
+		lprocfs_remove(&mdd->mdd_proc_entry);
+}