X-Git-Url: https://git.whamcloud.com/?a=blobdiff_plain;f=lustre%2Flov%2Flov_pool.c;h=88cf76a1148ca47ab3fa5e40b53e2a1cc8423e5c;hb=94a6bc2a947359a9b03b039a2fb4bb49842666e5;hp=2b320de02aa22f58635d1cf47b1083e221ba08b0;hpb=0f8dca08a4f68cba82c2c822998ecc309d3b7aaf;p=fs%2Flustre-release.git diff --git a/lustre/lov/lov_pool.c b/lustre/lov/lov_pool.c index 2b320de..88cf76a 100644 --- a/lustre/lov/lov_pool.c +++ b/lustre/lov/lov_pool.c @@ -1,6 +1,4 @@ -/* -*- mode: c; c-basic-offset: 8; indent-tabs-mode: nil; -*- - * vim:expandtab:shiftwidth=8:tabstop=8: - * +/* * GPL HEADER START * * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. @@ -28,6 +26,8 @@ /* * Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved. * Use is subject to license terms. + * + * Copyright (c) 2012, Intel Corporation. */ /* * This file is part of Lustre, http://www.lustre.org/ @@ -53,26 +53,35 @@ #include #include "lov_internal.h" +#define pool_tgt(_p, _i) \ + _p->pool_lobd->u.lov.lov_tgts[_p->pool_obds.op_array[_i]] + static void lov_pool_getref(struct pool_desc *pool) { - CDEBUG(D_INFO, "pool %p\n", pool); - cfs_atomic_inc(&pool->pool_refcount); + CDEBUG(D_INFO, "pool %p\n", pool); + atomic_inc(&pool->pool_refcount); } void lov_pool_putref(struct pool_desc *pool) { - CDEBUG(D_INFO, "pool %p\n", pool); - if (cfs_atomic_dec_and_test(&pool->pool_refcount)) { - LASSERT(cfs_hlist_unhashed(&pool->pool_hash)); - LASSERT(cfs_list_empty(&pool->pool_list)); - LASSERT(pool->pool_proc_entry == NULL); - lov_ost_pool_free(&(pool->pool_rr.lqr_pool)); - lov_ost_pool_free(&(pool->pool_obds)); - OBD_FREE_PTR(pool); - EXIT; - } + CDEBUG(D_INFO, "pool %p\n", pool); + if (atomic_dec_and_test(&pool->pool_refcount)) { + LASSERT(hlist_unhashed(&pool->pool_hash)); + LASSERT(list_empty(&pool->pool_list)); + LASSERT(pool->pool_proc_entry == NULL); + lov_ost_pool_free(&(pool->pool_obds)); + OBD_FREE_PTR(pool); + EXIT; + } } +void lov_pool_putref_locked(struct pool_desc *pool) +{ + CDEBUG(D_INFO, "pool %p\n", pool); + LASSERT(atomic_read(&pool->pool_refcount) > 1); + + atomic_dec(&pool->pool_refcount); +} /* * hash function using a Rotating Hash algorithm @@ -81,7 +90,7 @@ void lov_pool_putref(struct pool_desc *pool) * Chapter 6.4. * Addison Wesley, 1973 */ -static __u32 pool_hashfn(cfs_hash_t *hash_body, void *key, unsigned mask) +static __u32 pool_hashfn(cfs_hash_t *hash_body, const void *key, unsigned mask) { int i; __u32 result; @@ -97,50 +106,55 @@ static __u32 pool_hashfn(cfs_hash_t *hash_body, void *key, unsigned mask) return (result % mask); } -static void *pool_key(cfs_hlist_node_t *hnode) +static void *pool_key(struct hlist_node *hnode) { struct pool_desc *pool; - pool = cfs_hlist_entry(hnode, struct pool_desc, pool_hash); + pool = hlist_entry(hnode, struct pool_desc, pool_hash); return (pool->pool_name); } -static int pool_hashkey_compare(void *key, cfs_hlist_node_t *compared_hnode) +static int +pool_hashkey_keycmp(const void *key, struct hlist_node *compared_hnode) { char *pool_name; struct pool_desc *pool; - int rc; pool_name = (char *)key; - pool = cfs_hlist_entry(compared_hnode, struct pool_desc, pool_hash); - rc = strncmp(pool_name, pool->pool_name, LOV_MAXPOOLNAME); - return (!rc); + pool = hlist_entry(compared_hnode, struct pool_desc, pool_hash); + return !strncmp(pool_name, pool->pool_name, LOV_MAXPOOLNAME); +} + +static void *pool_hashobject(struct hlist_node *hnode) +{ + return hlist_entry(hnode, struct pool_desc, pool_hash); } -static void *pool_hashrefcount_get(cfs_hlist_node_t *hnode) +static void pool_hashrefcount_get(cfs_hash_t *hs, struct hlist_node *hnode) { struct pool_desc *pool; - pool = cfs_hlist_entry(hnode, struct pool_desc, pool_hash); + pool = hlist_entry(hnode, struct pool_desc, pool_hash); lov_pool_getref(pool); - return (pool); } -static void *pool_hashrefcount_put(cfs_hlist_node_t *hnode) +static void pool_hashrefcount_put_locked(cfs_hash_t *hs, + struct hlist_node *hnode) { struct pool_desc *pool; - pool = cfs_hlist_entry(hnode, struct pool_desc, pool_hash); - lov_pool_putref(pool); - return (pool); + pool = hlist_entry(hnode, struct pool_desc, pool_hash); + lov_pool_putref_locked(pool); } cfs_hash_ops_t pool_hash_operations = { .hs_hash = pool_hashfn, .hs_key = pool_key, - .hs_compare = pool_hashkey_compare, + .hs_keycmp = pool_hashkey_keycmp, + .hs_object = pool_hashobject, .hs_get = pool_hashrefcount_get, - .hs_put = pool_hashrefcount_put, + .hs_put_locked = pool_hashrefcount_put_locked, + }; #ifdef LPROCFS @@ -174,14 +188,14 @@ static void *pool_proc_next(struct seq_file *s, void *v, loff_t *pos) /* iterate to find a non empty entry */ prev_idx = iter->idx; - cfs_down_read(&pool_tgt_rw_sem(iter->pool)); + down_read(&pool_tgt_rw_sem(iter->pool)); iter->idx++; if (iter->idx == pool_tgt_count(iter->pool)) { iter->idx = prev_idx; /* we stay on the last entry */ - cfs_up_read(&pool_tgt_rw_sem(iter->pool)); + up_read(&pool_tgt_rw_sem(iter->pool)); return NULL; } - cfs_up_read(&pool_tgt_rw_sem(iter->pool)); + up_read(&pool_tgt_rw_sem(iter->pool)); (*pos)++; /* return != NULL to continue */ return iter; @@ -251,9 +265,9 @@ static int pool_proc_show(struct seq_file *s, void *v) LASSERT(iter->pool != NULL); LASSERT(iter->idx <= pool_tgt_count(iter->pool)); - cfs_down_read(&pool_tgt_rw_sem(iter->pool)); + down_read(&pool_tgt_rw_sem(iter->pool)); tgt = pool_tgt(iter->pool, iter->idx); - cfs_up_read(&pool_tgt_rw_sem(iter->pool)); + up_read(&pool_tgt_rw_sem(iter->pool)); if (tgt) seq_printf(s, "%s\n", obd_uuid2str(&(tgt->ltd_uuid))); @@ -274,7 +288,7 @@ static int pool_proc_open(struct inode *inode, struct file *file) rc = seq_open(file, &pool_proc_ops); if (!rc) { struct seq_file *s = file->private_data; - s->private = PROC_I(inode)->pde->data; + s->private = PDE_DATA(inode); } return rc; } @@ -295,7 +309,7 @@ void lov_dump_pool(int level, struct pool_desc *pool) CDEBUG(level, "pool "LOV_POOLNAMEF" has %d members\n", pool->pool_name, pool->pool_obds.op_count); - cfs_down_read(&pool_tgt_rw_sem(pool)); + down_read(&pool_tgt_rw_sem(pool)); for (i = 0; i < pool_tgt_count(pool) ; i++) { if (!pool_tgt(pool, i) || !(pool_tgt(pool, i))->ltd_exp) @@ -305,7 +319,7 @@ void lov_dump_pool(int level, struct pool_desc *pool) obd_uuid2str(&((pool_tgt(pool, i))->ltd_uuid))); } - cfs_up_read(&pool_tgt_rw_sem(pool)); + up_read(&pool_tgt_rw_sem(pool)); lov_pool_putref(pool); } @@ -318,7 +332,7 @@ int lov_ost_pool_init(struct ost_pool *op, unsigned int count) count = LOV_POOL_INIT_COUNT; op->op_array = NULL; op->op_count = 0; - cfs_init_rwsem(&op->op_rw_sem); + init_rwsem(&op->op_rw_sem); op->op_size = count; OBD_ALLOC(op->op_array, op->op_size * sizeof(op->op_array[0])); if (op->op_array == NULL) { @@ -358,7 +372,7 @@ int lov_ost_pool_add(struct ost_pool *op, __u32 idx, unsigned int min_count) int rc = 0, i; ENTRY; - cfs_down_write(&op->op_rw_sem); + down_write(&op->op_rw_sem); rc = lov_ost_pool_extend(op, min_count); if (rc) @@ -374,7 +388,7 @@ int lov_ost_pool_add(struct ost_pool *op, __u32 idx, unsigned int min_count) op->op_count++; EXIT; out: - cfs_up_write(&op->op_rw_sem); + up_write(&op->op_rw_sem); return rc; } @@ -383,20 +397,20 @@ int lov_ost_pool_remove(struct ost_pool *op, __u32 idx) int i; ENTRY; - cfs_down_write(&op->op_rw_sem); + down_write(&op->op_rw_sem); for (i = 0; i < op->op_count; i++) { if (op->op_array[i] == idx) { memmove(&op->op_array[i], &op->op_array[i + 1], (op->op_count - i - 1) * sizeof(op->op_array[0])); op->op_count--; - cfs_up_write(&op->op_rw_sem); + up_write(&op->op_rw_sem); EXIT; return 0; } } - cfs_up_write(&op->op_rw_sem); + up_write(&op->op_rw_sem); RETURN(-EINVAL); } @@ -407,14 +421,14 @@ int lov_ost_pool_free(struct ost_pool *op) if (op->op_size == 0) RETURN(0); - cfs_down_write(&op->op_rw_sem); + down_write(&op->op_rw_sem); OBD_FREE(op->op_array, op->op_size * sizeof(op->op_array[0])); op->op_array = NULL; op->op_count = 0; op->op_size = 0; - cfs_up_write(&op->op_rw_sem); + up_write(&op->op_rw_sem); RETURN(0); } @@ -435,32 +449,30 @@ int lov_pool_new(struct obd_device *obd, char *poolname) if (new_pool == NULL) RETURN(-ENOMEM); - strncpy(new_pool->pool_name, poolname, LOV_MAXPOOLNAME); - new_pool->pool_name[LOV_MAXPOOLNAME] = '\0'; - new_pool->pool_lov = lov; - /* ref count init to 1 because when created a pool is always used - * up to deletion - */ - cfs_atomic_set(&new_pool->pool_refcount, 1); - rc = lov_ost_pool_init(&new_pool->pool_obds, 0); - if (rc) - GOTO(out_err, rc); - - memset(&(new_pool->pool_rr), 0, sizeof(struct lov_qos_rr)); - rc = lov_ost_pool_init(&new_pool->pool_rr.lqr_pool, 0); - if (rc) - GOTO(out_free_pool_obds, rc); + strncpy(new_pool->pool_name, poolname, LOV_MAXPOOLNAME); + new_pool->pool_name[LOV_MAXPOOLNAME] = '\0'; + new_pool->pool_lobd = obd; + /* ref count init to 1 because when created a pool is always used + * up to deletion + */ + atomic_set(&new_pool->pool_refcount, 1); + rc = lov_ost_pool_init(&new_pool->pool_obds, 0); + if (rc) + GOTO(out_err, rc); - CFS_INIT_HLIST_NODE(&new_pool->pool_hash); + INIT_HLIST_NODE(&new_pool->pool_hash); #ifdef LPROCFS /* we need this assert seq_file is not implementated for liblustre */ /* get ref for /proc file */ lov_pool_getref(new_pool); new_pool->pool_proc_entry = lprocfs_add_simple(lov->lov_pool_proc_entry, - poolname, NULL, NULL, - new_pool, - &pool_proc_operations); + poolname, +#ifndef HAVE_ONLY_PROCFS_SEQ + NULL, NULL, +#endif + new_pool, + &pool_proc_operations); if (IS_ERR(new_pool->pool_proc_entry)) { CWARN("Cannot add proc pool entry "LOV_POOLNAMEF"\n", poolname); new_pool->pool_proc_entry = NULL; @@ -469,10 +481,10 @@ int lov_pool_new(struct obd_device *obd, char *poolname) CDEBUG(D_INFO, "pool %p - proc %p\n", new_pool, new_pool->pool_proc_entry); #endif - cfs_spin_lock(&obd->obd_dev_lock); - cfs_list_add_tail(&new_pool->pool_list, &lov->lov_pool_list); - lov->lov_pool_count++; - cfs_spin_unlock(&obd->obd_dev_lock); + spin_lock(&obd->obd_dev_lock); + list_add_tail(&new_pool->pool_list, &lov->lov_pool_list); + lov->lov_pool_count++; + spin_unlock(&obd->obd_dev_lock); /* add to find only when it fully ready */ rc = cfs_hash_add_unique(lov->lov_pools_hash_body, poolname, @@ -486,18 +498,15 @@ int lov_pool_new(struct obd_device *obd, char *poolname) RETURN(0); out_err: - cfs_spin_lock(&obd->obd_dev_lock); - cfs_list_del_init(&new_pool->pool_list); - lov->lov_pool_count--; - cfs_spin_unlock(&obd->obd_dev_lock); - + spin_lock(&obd->obd_dev_lock); + list_del_init(&new_pool->pool_list); + lov->lov_pool_count--; + spin_unlock(&obd->obd_dev_lock); lprocfs_remove(&new_pool->pool_proc_entry); + lov_ost_pool_free(&new_pool->pool_obds); + OBD_FREE_PTR(new_pool); - lov_ost_pool_free(&new_pool->pool_rr.lqr_pool); -out_free_pool_obds: - lov_ost_pool_free(&new_pool->pool_obds); - OBD_FREE_PTR(new_pool); - return rc; + return rc; } int lov_pool_del(struct obd_device *obd, char *poolname) @@ -519,15 +528,15 @@ int lov_pool_del(struct obd_device *obd, char *poolname) lov_pool_putref(pool); } - cfs_spin_lock(&obd->obd_dev_lock); - cfs_list_del_init(&pool->pool_list); - lov->lov_pool_count--; - cfs_spin_unlock(&obd->obd_dev_lock); + spin_lock(&obd->obd_dev_lock); + list_del_init(&pool->pool_list); + lov->lov_pool_count--; + spin_unlock(&obd->obd_dev_lock); - /* release last reference */ - lov_pool_putref(pool); + /* release last reference */ + lov_pool_putref(pool); - RETURN(0); + RETURN(0); } @@ -566,8 +575,6 @@ int lov_pool_add(struct obd_device *obd, char *poolname, char *ostname) if (rc) GOTO(out, rc); - pool->pool_rr.lqr_dirty = 1; - CDEBUG(D_CONFIG, "Added %s to "LOV_POOLNAMEF" as member %d\n", ostname, poolname, pool_tgt_count(pool)); @@ -612,8 +619,6 @@ int lov_pool_remove(struct obd_device *obd, char *poolname, char *ostname) lov_ost_pool_remove(&pool->pool_obds, lov_idx); - pool->pool_rr.lqr_dirty = 1; - CDEBUG(D_CONFIG, "%s removed from "LOV_POOLNAMEF"\n", ostname, poolname); @@ -623,51 +628,3 @@ out: lov_pool_putref(pool); return rc; } - -int lov_check_index_in_pool(__u32 idx, struct pool_desc *pool) -{ - int i, rc; - ENTRY; - - /* caller may no have a ref on pool if it got the pool - * without calling lov_find_pool() (e.g. go through the lov pool - * list) - */ - lov_pool_getref(pool); - - cfs_down_read(&pool_tgt_rw_sem(pool)); - - for (i = 0; i < pool_tgt_count(pool); i++) { - if (pool_tgt_array(pool)[i] == idx) - GOTO(out, rc = 0); - } - rc = -ENOENT; - EXIT; -out: - cfs_up_read(&pool_tgt_rw_sem(pool)); - - lov_pool_putref(pool); - return rc; -} - -struct pool_desc *lov_find_pool(struct lov_obd *lov, char *poolname) -{ - struct pool_desc *pool; - - pool = NULL; - if (poolname[0] != '\0') { - pool = cfs_hash_lookup(lov->lov_pools_hash_body, poolname); - if (pool == NULL) - CWARN("Request for an unknown pool ("LOV_POOLNAMEF")\n", - poolname); - if ((pool != NULL) && (pool_tgt_count(pool) == 0)) { - CWARN("Request for an empty pool ("LOV_POOLNAMEF")\n", - poolname); - /* pool is ignored, so we remove ref on it */ - lov_pool_putref(pool); - pool = NULL; - } - } - return pool; -} -