X-Git-Url: https://git.whamcloud.com/?a=blobdiff_plain;f=lnet%2Futils%2Flnetctl.c;h=4932aafed068d45915012302222088139ce55fd3;hb=97a64c94671c3116eddd54ca2fdda88dfad466f0;hp=819ce0bf0cafdf0341c59ec6a54b94e1169ce04b;hpb=f4e3a8239c520606032aa38f7c114cd9600385f3;p=fs%2Flustre-release.git diff --git a/lnet/utils/lnetctl.c b/lnet/utils/lnetctl.c index 819ce0b..4932aaf 100644 --- a/lnet/utils/lnetctl.c +++ b/lnet/utils/lnetctl.c @@ -18,7 +18,7 @@ * * LGPL HEADER END * - * Copyright (c) 2014, 2016, Intel Corporation. + * Copyright (c) 2014, 2017, Intel Corporation. * * Author: * Amir Shehata @@ -30,9 +30,7 @@ #include #include #include -#include -#include -#include "cyaml/cyaml.h" +#include #include "lnetconfig/liblnetconfig.h" #define LNET_CONFIGURE true @@ -50,15 +48,60 @@ static int jt_show_net(int argc, char **argv); static int jt_show_routing(int argc, char **argv); static int jt_show_stats(int argc, char **argv); static int jt_show_peer(int argc, char **argv); -static int jt_show_numa(int argc, char **argv); +static int jt_show_recovery(int argc, char **argv); +static int jt_show_global(int argc, char **argv); static int jt_set_tiny(int argc, char **argv); static int jt_set_small(int argc, char **argv); static int jt_set_large(int argc, char **argv); static int jt_set_numa(int argc, char **argv); +static int jt_set_retry_count(int argc, char **argv); +static int jt_set_transaction_to(int argc, char **argv); +static int jt_set_hsensitivity(int argc, char **argv); static int jt_add_peer_nid(int argc, char **argv); static int jt_del_peer_nid(int argc, char **argv); +static int jt_set_max_intf(int argc, char **argv); +static int jt_set_discovery(int argc, char **argv); +static int jt_list_peer(int argc, char **argv); /*static int jt_show_peer(int argc, char **argv);*/ static int lnetctl_list_commands(int argc, char **argv); +static int jt_import(int argc, char **argv); +static int jt_export(int argc, char **argv); +static int jt_ping(int argc, char **argv); +static int jt_discover(int argc, char **argv); +static int jt_lnet(int argc, char **argv); +static int jt_route(int argc, char **argv); +static int jt_net(int argc, char **argv); +static int jt_routing(int argc, char **argv); +static int jt_set(int argc, char **argv); +static int jt_debug(int argc, char **argv); +static int jt_stats(int argc, char **argv); +static int jt_global(int argc, char **argv); +static int jt_peers(int argc, char **argv); +static int jt_set_ni_value(int argc, char **argv); +static int jt_set_peer_ni_value(int argc, char **argv); + +command_t cmd_list[] = { + {"lnet", jt_lnet, 0, "lnet {configure | unconfigure} [--all]"}, + {"route", jt_route, 0, "route {add | del | show | help}"}, + {"net", jt_net, 0, "net {add | del | show | help}"}, + {"routing", jt_routing, 0, "routing {show | help}"}, + {"set", jt_set, 0, "set {tiny_buffers | small_buffers | large_buffers" + " | routing | numa_range | max_interfaces" + " | discovery}"}, + {"import", jt_import, 0, "import FILE.yaml"}, + {"export", jt_export, 0, "export FILE.yaml"}, + {"stats", jt_stats, 0, "stats {show | help}"}, + {"debug", jt_debug, 0, "debug recovery {local | peer}"}, + {"global", jt_global, 0, "global {show | help}"}, + {"peer", jt_peers, 0, "peer {add | del | show | help}"}, + {"ping", jt_ping, 0, "ping nid,[nid,...]"}, + {"discover", jt_discover, 0, "discover nid[,nid,...]"}, + {"help", Parser_help, 0, "help"}, + {"exit", Parser_quit, 0, "quit"}, + {"quit", Parser_quit, 0, "quit"}, + {"--list-commands", lnetctl_list_commands, 0, "list commands"}, + { 0, 0, 0, NULL } +}; command_t lnet_cmds[] = { {"configure", jt_config_lnet, 0, "configure lnet\n" @@ -100,7 +143,12 @@ command_t net_cmds[] = { "\t--if: physical interface (e.g. eth0)\n"}, {"show", jt_show_net, 0, "show networks\n" "\t--net: net name (e.g. tcp0) to filter on\n" - "\t--verbose: display detailed output per network\n"}, + "\t--verbose: display detailed output per network." + " Optional argument of '2' outputs more stats\n"}, + {"set", jt_set_ni_value, 0, "set local NI specific parameter\n" + "\t--nid: NI NID to set the\n" + "\t--health: specify health value to set\n" + "\t--all: set all NIs value to the one specified\n"}, { 0, 0, 0, NULL } }; @@ -114,8 +162,15 @@ command_t stats_cmds[] = { { 0, 0, 0, NULL } }; -command_t numa_cmds[] = { - {"show", jt_show_numa, 0, "show NUMA range\n"}, +command_t debug_cmds[] = { + {"recovery", jt_show_recovery, 0, "list recovery queues\n" + "\t--local : list local recovery queue\n" + "\t--peer : list peer recovery queue\n"}, + { 0, 0, 0, NULL } +}; + +command_t global_cmds[] = { + {"show", jt_show_global, 0, "show global variables\n"}, { 0, 0, 0, NULL } }; @@ -131,6 +186,20 @@ command_t set_cmds[] = { "\t1 - enable routing\n"}, {"numa_range", jt_set_numa, 0, "set NUMA range for NI selection\n" "\tVALUE must be at least 0\n"}, + {"max_interfaces", jt_set_max_intf, 0, "set the default value for " + "max interfaces\n" + "\tValue must be greater than 16\n"}, + {"discovery", jt_set_discovery, 0, "enable/disable peer discovery\n" + "\t0 - disable peer discovery\n" + "\t1 - enable peer discovery (default)\n"}, + {"retry_count", jt_set_retry_count, 0, "number of retries\n" + "\t0 - turn of retries\n" + "\t>0 - number of retries\n"}, + {"transaction_timeout", jt_set_transaction_to, 0, "Message/Response timeout\n" + "\t>0 - timeout in seconds\n"}, + {"health_sensitivity", jt_set_hsensitivity, 0, "sensitivity to failure\n" + "\t0 - turn off health evaluation\n" + "\t>0 - sensitivity value not more than 1000\n"}, { 0, 0, 0, NULL } }; @@ -140,14 +209,22 @@ command_t peer_cmds[] = { "\t NID in the list becomes the Primary NID of a newly created\n" "\t peer. \n" "\t--nid: one or more peer NIDs\n" - "\t--non_mr: create this peer as not Multi-Rail capable\n"}, + "\t--non_mr: create this peer as not Multi-Rail capable\n" + "\t--ip2nets: specify a range of nids per peer"}, {"del", jt_del_peer_nid, 0, "delete a peer NID\n" "\t--prim_nid: Primary NID of the peer.\n" "\t--nid: list of NIDs to remove. If none provided,\n" - "\t peer is deleted\n"}, + "\t peer is deleted\n" + "\t--ip2nets: specify a range of nids per peer"}, {"show", jt_show_peer, 0, "show peer information\n" "\t--nid: NID of peer to filter on.\n" - "\t--verbose: Include extended statistics\n"}, + "\t--verbose: display detailed output per peer." + " Optional argument of '2' outputs more stats\n"}, + {"list", jt_list_peer, 0, "list all peers\n"}, + {"set", jt_set_peer_ni_value, 0, "set peer ni specific parameter\n" + "\t--nid: Peer NI NID to set the\n" + "\t--health: specify health value to set\n" + "\t--all: set all peer_nis values to the one specified\n"}, { 0, 0, 0, NULL } }; @@ -173,6 +250,9 @@ static int parse_long(const char *number, long int *value) { char *end; + if (!number) + return -1; + *value = strtol(number, &end, 0); if (end != NULL && *end != 0) return -1; @@ -180,11 +260,12 @@ static int parse_long(const char *number, long int *value) return 0; } -static int handle_help(const command_t *cmd_list, const char *cmd, - const char *sub_cmd, int argc, char **argv) +static int check_cmd(const command_t *cmd_list, const char *cmd, + const char *sub_cmd, const int min_args, + int argc, char **argv) { int opt; - int rc = -1; + int rc = 0; optind = 0; opterr = 0; @@ -194,32 +275,70 @@ static int handle_help(const command_t *cmd_list, const char *cmd, { .name = NULL } }; + if (argc < min_args) { + print_help(cmd_list, cmd, sub_cmd); + rc = -1; + goto out; + } else if (argc > 2) { + return 0; + } + while ((opt = getopt_long(argc, argv, short_options, long_options, NULL)) != -1) { switch (opt) { case 'h': print_help(cmd_list, cmd, sub_cmd); - rc = 0; + rc = 1; break; default: - rc = -1; + rc = 0; break; } } +out: opterr = 1; optind = 0; return rc; } +static int jt_set_max_intf(int argc, char **argv) +{ + long int value; + int rc; + struct cYAML *err_rc = NULL; + + rc = check_cmd(set_cmds, "set", "max_interfaces", 2, argc, argv); + if (rc) + return rc; + + rc = parse_long(argv[1], &value); + if (rc != 0) { + cYAML_build_error(-1, -1, "parser", "set", + "cannot parse max_interfaces value", &err_rc); + cYAML_print_tree2file(stderr, err_rc); + cYAML_free_tree(err_rc); + return -1; + } + + rc = lustre_lnet_config_max_intf(value, -1, &err_rc); + if (rc != LUSTRE_CFG_RC_NO_ERR) + cYAML_print_tree2file(stderr, err_rc); + + cYAML_free_tree(err_rc); + + return rc; +} + static int jt_set_numa(int argc, char **argv) { long int value; int rc; struct cYAML *err_rc = NULL; - if (handle_help(set_cmds, "set", "numa_range", argc, argv) == 0) - return 0; + rc = check_cmd(set_cmds, "set", "numa_range", 2, argc, argv); + if (rc) + return rc; rc = parse_long(argv[1], &value); if (rc != 0) { @@ -239,14 +358,127 @@ static int jt_set_numa(int argc, char **argv) return rc; } +static int jt_set_hsensitivity(int argc, char **argv) +{ + long int value; + int rc; + struct cYAML *err_rc = NULL; + + rc = check_cmd(set_cmds, "set", "health_sensitivity", 2, argc, argv); + if (rc) + return rc; + + rc = parse_long(argv[1], &value); + if (rc != 0) { + cYAML_build_error(-1, -1, "parser", "set", + "cannot parse health sensitivity value", &err_rc); + cYAML_print_tree2file(stderr, err_rc); + cYAML_free_tree(err_rc); + return -1; + } + + rc = lustre_lnet_config_hsensitivity(value, -1, &err_rc); + if (rc != LUSTRE_CFG_RC_NO_ERR) + cYAML_print_tree2file(stderr, err_rc); + + cYAML_free_tree(err_rc); + + return rc; +} + +static int jt_set_transaction_to(int argc, char **argv) +{ + long int value; + int rc; + struct cYAML *err_rc = NULL; + + rc = check_cmd(set_cmds, "set", "transaction_timeout", 2, argc, argv); + if (rc) + return rc; + + rc = parse_long(argv[1], &value); + if (rc != 0) { + cYAML_build_error(-1, -1, "parser", "set", + "cannot parse transaction timeout value", &err_rc); + cYAML_print_tree2file(stderr, err_rc); + cYAML_free_tree(err_rc); + return -1; + } + + rc = lustre_lnet_config_transaction_to(value, -1, &err_rc); + if (rc != LUSTRE_CFG_RC_NO_ERR) + cYAML_print_tree2file(stderr, err_rc); + + cYAML_free_tree(err_rc); + + return rc; +} + +static int jt_set_retry_count(int argc, char **argv) +{ + long int value; + int rc; + struct cYAML *err_rc = NULL; + + rc = check_cmd(set_cmds, "set", "retry_count", 2, argc, argv); + if (rc) + return rc; + + rc = parse_long(argv[1], &value); + if (rc != 0) { + cYAML_build_error(-1, -1, "parser", "set", + "cannot parse retry_count value", &err_rc); + cYAML_print_tree2file(stderr, err_rc); + cYAML_free_tree(err_rc); + return -1; + } + + rc = lustre_lnet_config_retry_count(value, -1, &err_rc); + if (rc != LUSTRE_CFG_RC_NO_ERR) + cYAML_print_tree2file(stderr, err_rc); + + cYAML_free_tree(err_rc); + + return rc; +} + +static int jt_set_discovery(int argc, char **argv) +{ + long int value; + int rc; + struct cYAML *err_rc = NULL; + + rc = check_cmd(set_cmds, "set", "discovery", 2, argc, argv); + if (rc) + return rc; + + rc = parse_long(argv[1], &value); + if (rc != 0) { + cYAML_build_error(-1, -1, "parser", "set", + "cannot parse discovery value", &err_rc); + cYAML_print_tree2file(stderr, err_rc); + cYAML_free_tree(err_rc); + return -1; + } + + rc = lustre_lnet_config_discovery(value, -1, &err_rc); + if (rc != LUSTRE_CFG_RC_NO_ERR) + cYAML_print_tree2file(stderr, err_rc); + + cYAML_free_tree(err_rc); + + return rc; +} + static int jt_set_tiny(int argc, char **argv) { long int value; int rc; struct cYAML *err_rc = NULL; - if (handle_help(set_cmds, "set", "tiny_buffers", argc, argv) == 0) - return 0; + rc = check_cmd(set_cmds, "set", "tiny_buffers", 2, argc, argv); + if (rc) + return rc; rc = parse_long(argv[1], &value); if (rc != 0) { @@ -272,8 +504,9 @@ static int jt_set_small(int argc, char **argv) int rc; struct cYAML *err_rc = NULL; - if (handle_help(set_cmds, "set", "small_buffers", argc, argv) == 0) - return 0; + rc = check_cmd(set_cmds, "set", "small_buffers", 2, argc, argv); + if (rc) + return rc; rc = parse_long(argv[1], &value); if (rc != 0) { @@ -299,8 +532,9 @@ static int jt_set_large(int argc, char **argv) int rc; struct cYAML *err_rc = NULL; - if (handle_help(set_cmds, "set", "large_buffers", argc, argv) == 0) - return 0; + rc = check_cmd(set_cmds, "set", "large_buffers", 2, argc, argv); + if (rc) + return rc; rc = parse_long(argv[1], &value); if (rc != 0) { @@ -326,8 +560,9 @@ static int jt_set_routing(int argc, char **argv) struct cYAML *err_rc = NULL; int rc; - if (handle_help(set_cmds, "set", "routing", argc, argv) == 0) - return 0; + rc = check_cmd(set_cmds, "set", "routing", 2, argc, argv); + if (rc) + return rc; rc = parse_long(argv[1], &value); if (rc != 0 || (value != 0 && value != 1)) { @@ -356,22 +591,22 @@ static int jt_config_lnet(int argc, char **argv) bool load_mod_params = false; int rc, opt; - const char *const short_options = "ah"; + const char *const short_options = "a"; static const struct option long_options[] = { { .name = "all", .has_arg = no_argument, .val = 'a' }, - { .name = "help", .has_arg = no_argument, .val = 'h' }, { .name = NULL } }; + rc = check_cmd(lnet_cmds, "lnet", "configure", 0, argc, argv); + if (rc) + return rc; + while ((opt = getopt_long(argc, argv, short_options, long_options, NULL)) != -1) { switch (opt) { case 'a': load_mod_params = true; break; - case 'h': - print_help(lnet_cmds, "lnet", "configure"); - return 0; default: return 0; } @@ -393,8 +628,9 @@ static int jt_unconfig_lnet(int argc, char **argv) struct cYAML *err_rc = NULL; int rc; - if (handle_help(lnet_cmds, "lnet", "unconfigure", argc, argv) == 0) - return 0; + rc = check_cmd(lnet_cmds, "lnet", "unconfigure", 0, argc, argv); + if (rc) + return rc; rc = lustre_lnet_config_ni_system(LNET_UNCONFIGURE, 0, -1, &err_rc); @@ -412,15 +648,18 @@ static int jt_add_route(int argc, char **argv) struct cYAML *err_rc = NULL; int rc, opt; - const char *const short_options = "n:g:c:p:h"; + const char *const short_options = "n:g:c:p:"; static const struct option long_options[] = { { .name = "net", .has_arg = required_argument, .val = 'n' }, { .name = "gateway", .has_arg = required_argument, .val = 'g' }, { .name = "hop-count", .has_arg = required_argument, .val = 'c' }, { .name = "priority", .has_arg = required_argument, .val = 'p' }, - { .name = "help", .has_arg = no_argument, .val = 'h' }, { .name = NULL } }; + rc = check_cmd(route_cmds, "route", "add", 0, argc, argv); + if (rc) + return rc; + while ((opt = getopt_long(argc, argv, short_options, long_options, NULL)) != -1) { switch (opt) { @@ -446,9 +685,8 @@ static int jt_add_route(int argc, char **argv) continue; } break; - case 'h': + case '?': print_help(route_cmds, "route", "add"); - return 0; default: return 0; } @@ -478,7 +716,7 @@ static int jt_add_ni(int argc, char **argv) memset(&tunables, 0, sizeof(tunables)); lustre_lnet_init_nw_descr(&nw_descr); - const char *const short_options = "n:i:p:t:c:b:r:s:h"; + const char *const short_options = "n:i:p:t:c:b:r:s:"; static const struct option long_options[] = { { .name = "net", .has_arg = required_argument, .val = 'n' }, { .name = "if", .has_arg = required_argument, .val = 'i' }, @@ -489,9 +727,12 @@ static int jt_add_ni(int argc, char **argv) .has_arg = required_argument, .val = 'b' }, { .name = "credits", .has_arg = required_argument, .val = 'r' }, { .name = "cpt", .has_arg = required_argument, .val = 's' }, - { .name = "help", .has_arg = no_argument, .val = 'h' }, { .name = NULL } }; + rc = check_cmd(net_cmds, "net", "add", 0, argc, argv); + if (rc) + return rc; + while ((opt = getopt_long(argc, argv, short_options, long_options, NULL)) != -1) { switch (opt) { @@ -547,9 +788,8 @@ static int jt_add_ni(int argc, char **argv) strlen(optarg), 0, UINT_MAX, &global_cpts); break; - case 'h': + case '?': print_help(net_cmds, "net", "add"); - return 0; default: return 0; } @@ -586,13 +826,16 @@ static int jt_del_route(int argc, char **argv) struct cYAML *err_rc = NULL; int rc, opt; - const char *const short_options = "n:g:h"; + const char *const short_options = "n:g:"; static const struct option long_options[] = { { .name = "net", .has_arg = required_argument, .val = 'n' }, { .name = "gateway", .has_arg = required_argument, .val = 'g' }, - { .name = "help", .has_arg = no_argument, .val = 'h' }, { .name = NULL } }; + rc = check_cmd(route_cmds, "route", "del", 0, argc, argv); + if (rc) + return rc; + while ((opt = getopt_long(argc, argv, short_options, long_options, NULL)) != -1) { switch (opt) { @@ -602,9 +845,8 @@ static int jt_del_route(int argc, char **argv) case 'g': gateway = optarg; break; - case 'h': + case '?': print_help(route_cmds, "route", "del"); - return 0; default: return 0; } @@ -628,13 +870,16 @@ static int jt_del_ni(int argc, char **argv) lustre_lnet_init_nw_descr(&nw_descr); - const char *const short_options = "n:i:h"; + const char *const short_options = "n:i:"; static const struct option long_options[] = { { .name = "net", .has_arg = required_argument, .val = 'n' }, { .name = "if", .has_arg = required_argument, .val = 'i' }, - { .name = "help", .has_arg = no_argument, .val = 'h' }, { .name = NULL } }; + rc = check_cmd(net_cmds, "net", "del", 0, argc, argv); + if (rc) + return rc; + while ((opt = getopt_long(argc, argv, short_options, long_options, NULL)) != -1) { switch (opt) { @@ -650,9 +895,8 @@ static int jt_del_ni(int argc, char **argv) goto out; } break; - case 'h': + case '?': print_help(net_cmds, "net", "del"); - return 0; default: return 0; } @@ -676,16 +920,19 @@ static int jt_show_route(int argc, char **argv) int detail = 0, rc, opt; struct cYAML *err_rc = NULL, *show_rc = NULL; - const char *const short_options = "n:g:h:p:vh"; + const char *const short_options = "n:g:h:p:v"; static const struct option long_options[] = { { .name = "net", .has_arg = required_argument, .val = 'n' }, { .name = "gateway", .has_arg = required_argument, .val = 'g' }, { .name = "hop-count", .has_arg = required_argument, .val = 'c' }, { .name = "priority", .has_arg = required_argument, .val = 'p' }, { .name = "verbose", .has_arg = no_argument, .val = 'v' }, - { .name = "help", .has_arg = no_argument, .val = 'h' }, { .name = NULL } }; + rc = check_cmd(route_cmds, "route", "show", 0, argc, argv); + if (rc) + return rc; + while ((opt = getopt_long(argc, argv, short_options, long_options, NULL)) != -1) { switch (opt) { @@ -714,16 +961,113 @@ static int jt_show_route(int argc, char **argv) case 'v': detail = 1; break; - case 'h': + case '?': print_help(route_cmds, "route", "show"); - return 0; default: return 0; } } rc = lustre_lnet_show_route(network, gateway, hop, prio, detail, -1, - &show_rc, &err_rc); + &show_rc, &err_rc, false); + + if (rc != LUSTRE_CFG_RC_NO_ERR) + cYAML_print_tree2file(stderr, err_rc); + else if (show_rc) + cYAML_print_tree(show_rc); + + cYAML_free_tree(err_rc); + cYAML_free_tree(show_rc); + + return rc; +} + +static int set_value_helper(int argc, char **argv, + int (*cb)(int, bool, char*, int, struct cYAML**)) +{ + char *nid = NULL; + long int healthv = -1; + bool all = false; + int rc, opt; + struct cYAML *err_rc = NULL; + + const char *const short_options = "t:n:a"; + static const struct option long_options[] = { + { .name = "nid", .has_arg = required_argument, .val = 'n' }, + { .name = "health", .has_arg = required_argument, .val = 't' }, + { .name = "all", .has_arg = no_argument, .val = 'a' }, + { .name = NULL } }; + + rc = check_cmd(net_cmds, "net", "set", 0, argc, argv); + if (rc) + return rc; + + while ((opt = getopt_long(argc, argv, short_options, + long_options, NULL)) != -1) { + switch (opt) { + case 'n': + nid = optarg; + break; + case 't': + if (parse_long(optarg, &healthv) != 0) + healthv = -1; + break; + case 'a': + all = true; + break; + default: + return 0; + } + } + + rc = cb(healthv, all, nid, -1, &err_rc); + + if (rc != LUSTRE_CFG_RC_NO_ERR) + cYAML_print_tree2file(stderr, err_rc); + + cYAML_free_tree(err_rc); + + return rc; +} + +static int jt_set_ni_value(int argc, char **argv) +{ + return set_value_helper(argc, argv, lustre_lnet_config_ni_healthv); +} + +static int jt_set_peer_ni_value(int argc, char **argv) +{ + return set_value_helper(argc, argv, lustre_lnet_config_peer_ni_healthv); +} + +static int jt_show_recovery(int argc, char **argv) +{ + int rc, opt; + struct cYAML *err_rc = NULL, *show_rc = NULL; + + const char *const short_options = "lp"; + static const struct option long_options[] = { + { .name = "local", .has_arg = no_argument, .val = 'l' }, + { .name = "peer", .has_arg = no_argument, .val = 'p' }, + { .name = NULL } }; + + rc = check_cmd(debug_cmds, "recovery", NULL, 0, argc, argv); + if (rc) + return rc; + + while ((opt = getopt_long(argc, argv, short_options, + long_options, NULL)) != -1) { + switch (opt) { + case 'l': + rc = lustre_lnet_show_local_ni_recovq(-1, &show_rc, &err_rc); + break; + case 'p': + rc = lustre_lnet_show_peer_ni_recovq(-1, &show_rc, &err_rc); + break; + default: + return 0; + } + } if (rc != LUSTRE_CFG_RC_NO_ERR) cYAML_print_tree2file(stderr, err_rc); @@ -739,16 +1083,20 @@ static int jt_show_route(int argc, char **argv) static int jt_show_net(int argc, char **argv) { char *network = NULL; - int detail = 0, rc, opt; + int rc, opt; struct cYAML *err_rc = NULL, *show_rc = NULL; + long int detail = 0; - const char *const short_options = "n:vh"; + const char *const short_options = "n:v"; static const struct option long_options[] = { { .name = "net", .has_arg = required_argument, .val = 'n' }, - { .name = "verbose", .has_arg = no_argument, .val = 'v' }, - { .name = "help", .has_arg = no_argument, .val = 'h' }, + { .name = "verbose", .has_arg = optional_argument, .val = 'v' }, { .name = NULL } }; + rc = check_cmd(net_cmds, "net", "show", 0, argc, argv); + if (rc) + return rc; + while ((opt = getopt_long(argc, argv, short_options, long_options, NULL)) != -1) { switch (opt) { @@ -756,17 +1104,23 @@ static int jt_show_net(int argc, char **argv) network = optarg; break; case 'v': - detail = 1; + if ((!optarg) && (argv[optind] != NULL) && + (argv[optind][0] != '-')) { + if (parse_long(argv[optind++], &detail) != 0) + detail = 1; + } else { + detail = 1; + } break; - case 'h': + case '?': print_help(net_cmds, "net", "show"); - return 0; default: return 0; } } - rc = lustre_lnet_show_net(network, detail, -1, &show_rc, &err_rc); + rc = lustre_lnet_show_net(network, (int) detail, -1, &show_rc, &err_rc, + false); if (rc != LUSTRE_CFG_RC_NO_ERR) cYAML_print_tree2file(stderr, err_rc); @@ -784,10 +1138,11 @@ static int jt_show_routing(int argc, char **argv) struct cYAML *err_rc = NULL, *show_rc = NULL; int rc; - if (handle_help(routing_cmds, "routing", "show", argc, argv) == 0) - return 0; + rc = check_cmd(routing_cmds, "routing", "show", 0, argc, argv); + if (rc) + return rc; - rc = lustre_lnet_show_routing(-1, &show_rc, &err_rc); + rc = lustre_lnet_show_routing(-1, &show_rc, &err_rc, false); if (rc != LUSTRE_CFG_RC_NO_ERR) cYAML_print_tree2file(stderr, err_rc); @@ -805,8 +1160,9 @@ static int jt_show_stats(int argc, char **argv) int rc; struct cYAML *show_rc = NULL, *err_rc = NULL; - if (handle_help(stats_cmds, "stats", "show", argc, argv) == 0) - return 0; + rc = check_cmd(stats_cmds, "stats", "show", 0, argc, argv); + if (rc) + return rc; rc = lustre_lnet_show_stats(-1, &show_rc, &err_rc); @@ -821,119 +1177,156 @@ static int jt_show_stats(int argc, char **argv) return rc; } -static int jt_show_numa(int argc, char **argv) +static int jt_show_global(int argc, char **argv) { int rc; struct cYAML *show_rc = NULL, *err_rc = NULL; - if (handle_help(numa_cmds, "numa", "show", argc, argv) == 0) - return 0; + rc = check_cmd(global_cmds, "global", "show", 0, argc, argv); + if (rc) + return rc; rc = lustre_lnet_show_numa_range(-1, &show_rc, &err_rc); + if (rc != LUSTRE_CFG_RC_NO_ERR) { + cYAML_print_tree2file(stderr, err_rc); + goto out; + } - if (rc != LUSTRE_CFG_RC_NO_ERR) + rc = lustre_lnet_show_max_intf(-1, &show_rc, &err_rc); + if (rc != LUSTRE_CFG_RC_NO_ERR) { cYAML_print_tree2file(stderr, err_rc); - else if (show_rc) + goto out; + } + + rc = lustre_lnet_show_discovery(-1, &show_rc, &err_rc); + if (rc != LUSTRE_CFG_RC_NO_ERR) { + cYAML_print_tree2file(stderr, err_rc); + goto out; + } + + rc = lustre_lnet_show_retry_count(-1, &show_rc, &err_rc); + if (rc != LUSTRE_CFG_RC_NO_ERR) { + cYAML_print_tree2file(stderr, err_rc); + goto out; + } + + rc = lustre_lnet_show_transaction_to(-1, &show_rc, &err_rc); + if (rc != LUSTRE_CFG_RC_NO_ERR) { + cYAML_print_tree2file(stderr, err_rc); + goto out; + } + + rc = lustre_lnet_show_hsensitivity(-1, &show_rc, &err_rc); + if (rc != LUSTRE_CFG_RC_NO_ERR) { + cYAML_print_tree2file(stderr, err_rc); + goto out; + } + + if (show_rc) cYAML_print_tree(show_rc); +out: cYAML_free_tree(err_rc); cYAML_free_tree(show_rc); return rc; } -static inline int jt_lnet(int argc, char **argv) +static int jt_lnet(int argc, char **argv) { - if (argc < 2) - return CMD_HELP; + int rc; - if (argc == 2 && - handle_help(lnet_cmds, "lnet", NULL, argc, argv) == 0) - return 0; + rc = check_cmd(lnet_cmds, "lnet", NULL, 2, argc, argv); + if (rc) + return rc; return Parser_execarg(argc - 1, &argv[1], lnet_cmds); } -static inline int jt_route(int argc, char **argv) +static int jt_route(int argc, char **argv) { - if (argc < 2) - return CMD_HELP; + int rc; - if (argc == 2 && - handle_help(route_cmds, "route", NULL, argc, argv) == 0) - return 0; + rc = check_cmd(route_cmds, "route", NULL, 2, argc, argv); + if (rc) + return rc; return Parser_execarg(argc - 1, &argv[1], route_cmds); } -static inline int jt_net(int argc, char **argv) +static int jt_net(int argc, char **argv) { - if (argc < 2) - return CMD_HELP; + int rc; - if (argc == 2 && - handle_help(net_cmds, "net", NULL, argc, argv) == 0) - return 0; + rc = check_cmd(net_cmds, "net", NULL, 2, argc, argv); + if (rc) + return rc; return Parser_execarg(argc - 1, &argv[1], net_cmds); } -static inline int jt_routing(int argc, char **argv) +static int jt_routing(int argc, char **argv) { - if (argc < 2) - return CMD_HELP; + int rc; - if (argc == 2 && - handle_help(routing_cmds, "routing", NULL, argc, argv) == 0) - return 0; + rc = check_cmd(routing_cmds, "routing", NULL, 2, argc, argv); + if (rc) + return rc; return Parser_execarg(argc - 1, &argv[1], routing_cmds); } -static inline int jt_stats(int argc, char **argv) +static int jt_stats(int argc, char **argv) { - if (argc < 2) - return CMD_HELP; + int rc; - if (argc == 2 && - handle_help(stats_cmds, "stats", NULL, argc, argv) == 0) - return 0; + rc = check_cmd(stats_cmds, "stats", NULL, 2, argc, argv); + if (rc) + return rc; return Parser_execarg(argc - 1, &argv[1], stats_cmds); } -static inline int jt_numa(int argc, char **argv) +static int jt_debug(int argc, char **argv) { - if (argc < 2) - return CMD_HELP; + int rc; - if (argc == 2 && - handle_help(numa_cmds, "numa", NULL, argc, argv) == 0) - return 0; + rc = check_cmd(debug_cmds, "recovery", NULL, 2, argc, argv); + if (rc) + return rc; - return Parser_execarg(argc - 1, &argv[1], numa_cmds); + return Parser_execarg(argc - 1, &argv[1], debug_cmds); } -static inline int jt_peers(int argc, char **argv) +static int jt_global(int argc, char **argv) { - if (argc < 2) - return CMD_HELP; + int rc; - if (argc == 2 && - handle_help(peer_cmds, "peer", NULL, argc, argv) == 0) - return 0; + rc = check_cmd(global_cmds, "global", NULL, 2, argc, argv); + if (rc) + return rc; + + return Parser_execarg(argc - 1, &argv[1], global_cmds); +} + +static int jt_peers(int argc, char **argv) +{ + int rc; + + rc = check_cmd(peer_cmds, "peer", NULL, 2, argc, argv); + if (rc) + return rc; return Parser_execarg(argc - 1, &argv[1], peer_cmds); } -static inline int jt_set(int argc, char **argv) +static int jt_set(int argc, char **argv) { - if (argc < 2) - return CMD_HELP; + int rc; - if (argc == 2 && - handle_help(set_cmds, "set", NULL, argc, argv) == 0) - return 0; + rc = check_cmd(set_cmds, "set", NULL, 2, argc, argv); + if (rc) + return rc; return Parser_execarg(argc - 1, &argv[1], set_cmds); } @@ -943,14 +1336,15 @@ static int jt_import(int argc, char **argv) char *file = NULL; struct cYAML *err_rc = NULL; struct cYAML *show_rc = NULL; - int rc = 0, opt, opt_found = 0; + int rc = 0, return_rc = 0, opt, opt_found = 0; char cmd = 'a'; - const char *const short_options = "adsh"; + const char *const short_options = "adseh"; static const struct option long_options[] = { { .name = "add", .has_arg = no_argument, .val = 'a' }, { .name = "del", .has_arg = no_argument, .val = 'd' }, { .name = "show", .has_arg = no_argument, .val = 's' }, + { .name = "exec", .has_arg = no_argument, .val = 'e' }, { .name = "help", .has_arg = no_argument, .val = 'h' }, { .name = NULL } }; @@ -959,16 +1353,22 @@ static int jt_import(int argc, char **argv) opt_found = 1; switch (opt) { case 'a': + cmd = opt; + break; case 'd': case 's': cmd = opt; break; + case 'e': + cmd = opt; + break; case 'h': printf("import FILE\n" "import < FILE : import a file\n" "\t--add: add configuration\n" "\t--del: delete configuration\n" "\t--show: show configuration\n" + "\t--exec: execute command\n" "\t--help: display this help\n" "If no command option is given then --add" " is assumed by default\n"); @@ -987,6 +1387,9 @@ static int jt_import(int argc, char **argv) switch (cmd) { case 'a': rc = lustre_yaml_config(file, &err_rc); + return_rc = lustre_yaml_exec(file, &show_rc, &err_rc); + cYAML_print_tree(show_rc); + cYAML_free_tree(show_rc); break; case 'd': rc = lustre_yaml_del(file, &err_rc); @@ -996,11 +1399,17 @@ static int jt_import(int argc, char **argv) cYAML_print_tree(show_rc); cYAML_free_tree(show_rc); break; + case 'e': + rc = lustre_yaml_exec(file, &show_rc, &err_rc); + cYAML_print_tree(show_rc); + cYAML_free_tree(show_rc); + break; } - cYAML_print_tree2file(stderr, err_rc); - - cYAML_free_tree(err_rc); + if (rc || return_rc) { + cYAML_print_tree2file(stderr, err_rc); + cYAML_free_tree(err_rc); + } return rc; } @@ -1009,63 +1418,94 @@ static int jt_export(int argc, char **argv) { struct cYAML *show_rc = NULL; struct cYAML *err_rc = NULL; - int rc, opt; + int rc; FILE *f = NULL; + int opt; + bool backup = false; + char *file = NULL; - const char *const short_options = "h"; + const char *const short_options = "bh"; static const struct option long_options[] = { + { .name = "backup", .has_arg = no_argument, .val = 'b' }, { .name = "help", .has_arg = no_argument, .val = 'h' }, { .name = NULL } }; while ((opt = getopt_long(argc, argv, short_options, long_options, NULL)) != -1) { switch (opt) { + case 'b': + backup = true; + break; case 'h': - printf("export FILE\n" - "export > FILE : export configuration\n" - "\t--help: display this help\n"); - return 0; default: + printf("export > FILE.yaml : export configuration\n" + "\t--backup: export only what's necessary for reconfig\n" + "\t--help: display this help\n"); return 0; } } - if (argc >= 2) { - f = fopen(argv[1], "w"); + if (backup && argc >= 3) + file = argv[2]; + else if (!backup && argc >= 2) + file = argv[1]; + else + f = stdout; + + if (file) { + f = fopen(file, "w"); if (f == NULL) return -1; - } else - f = stdout; + } - rc = lustre_lnet_show_net(NULL, 1, -1, &show_rc, &err_rc); + rc = lustre_lnet_show_net(NULL, 2, -1, &show_rc, &err_rc, backup); if (rc != LUSTRE_CFG_RC_NO_ERR) { cYAML_print_tree2file(stderr, err_rc); cYAML_free_tree(err_rc); + err_rc = NULL; } rc = lustre_lnet_show_route(NULL, NULL, -1, -1, 1, -1, &show_rc, - &err_rc); + &err_rc, backup); if (rc != LUSTRE_CFG_RC_NO_ERR) { cYAML_print_tree2file(stderr, err_rc); cYAML_free_tree(err_rc); + err_rc = NULL; } - rc = lustre_lnet_show_routing(-1, &show_rc, &err_rc); + rc = lustre_lnet_show_routing(-1, &show_rc, &err_rc, backup); if (rc != LUSTRE_CFG_RC_NO_ERR) { cYAML_print_tree2file(stderr, err_rc); cYAML_free_tree(err_rc); + err_rc = NULL; } - rc = lustre_lnet_show_peer(NULL, 1, -1, &show_rc, &err_rc); + rc = lustre_lnet_show_peer(NULL, 2, -1, &show_rc, &err_rc, backup); if (rc != LUSTRE_CFG_RC_NO_ERR) { cYAML_print_tree2file(stderr, err_rc); cYAML_free_tree(err_rc); + err_rc = NULL; } rc = lustre_lnet_show_numa_range(-1, &show_rc, &err_rc); if (rc != LUSTRE_CFG_RC_NO_ERR) { cYAML_print_tree2file(stderr, err_rc); cYAML_free_tree(err_rc); + err_rc = NULL; + } + + rc = lustre_lnet_show_max_intf(-1, &show_rc, &err_rc); + if (rc != LUSTRE_CFG_RC_NO_ERR) { + cYAML_print_tree2file(stderr, err_rc); + cYAML_free_tree(err_rc); + err_rc = NULL; + } + + rc = lustre_lnet_show_discovery(-1, &show_rc, &err_rc); + if (rc != LUSTRE_CFG_RC_NO_ERR) { + cYAML_print_tree2file(stderr, err_rc); + cYAML_free_tree(err_rc); + err_rc = NULL; } if (show_rc != NULL) { @@ -1087,23 +1527,50 @@ static int jt_add_peer_nid(int argc, char **argv) struct cYAML *err_rc = NULL; int rc = LUSTRE_CFG_RC_NO_ERR, opt, i; bool non_mr = false; + bool ip2nets = false, nid_list = false, prim_nid_present = false; + + const char *const short_opts = "k:mn:"; + const struct option long_opts[] = { + { .name = "prim_nid", .has_arg = required_argument, .val = 'k' }, + { .name = "non_mr", .has_arg = no_argument, .val = 'm' }, + { .name = "nid", .has_arg = required_argument, .val = 'n' }, + { .name = "ip2nets", .has_arg = required_argument, .val = 'i' }, + { .name = NULL } }; - const char *const short_options = "k:n:mh"; - const struct option long_options[] = { - { "prim_nid", 1, NULL, 'k' }, - { "nid", 1, NULL, 'n' }, - { "non_mr", 0, NULL, 'm'}, - { "help", 0, NULL, 'h' }, - { NULL, 0, NULL, 0 }, - }; + rc = check_cmd(peer_cmds, "peer", "add", 2, argc, argv); + if (rc) + return rc; - while ((opt = getopt_long(argc, argv, short_options, - long_options, NULL)) != -1) { + while ((opt = getopt_long(argc, argv, short_opts, + long_opts, NULL)) != -1) { switch (opt) { case 'k': + prim_nid_present = true; + if (ip2nets) { + cYAML_build_error(-1, -1, "peer", "add", + "ip2nets can not be specified" + " along side prim_nid parameter.", + &err_rc); + goto failed; + } prim_nid = optarg; break; + case 'i': case 'n': + if (opt == 'i') + ip2nets = true; + + if (opt == 'n') + nid_list = true; + + if (ip2nets && (nid_list || prim_nid_present)) { + cYAML_build_error(-1, -1, "peer", "add", + "ip2nets can not be specified" + " along side nid or prim_nid" + " parameters", &err_rc); + goto failed; + } + size = lustre_lnet_parse_nids(optarg, nids, size, &nids2); if (nids2 == NULL) @@ -1114,16 +1581,23 @@ static int jt_add_peer_nid(int argc, char **argv) case 'm': non_mr = true; break; - case 'h': + case '?': print_help(peer_cmds, "peer", "add"); - return 0; default: return 0; } } + for (; optind < argc; optind++) { + size = lustre_lnet_parse_nids(argv[optind], nids, size, + &nids2); + if (nids2 == NULL) + goto failed; + nids = nids2; + } + rc = lustre_lnet_config_peer_nid(prim_nid, nids, size, - !non_mr, -1, &err_rc); + !non_mr, ip2nets, -1, &err_rc); failed: if (nids) { @@ -1147,22 +1621,48 @@ static int jt_del_peer_nid(int argc, char **argv) char **nids = NULL, **nids2 = NULL; struct cYAML *err_rc = NULL; int rc = LUSTRE_CFG_RC_NO_ERR, opt, i, size = 0; + bool ip2nets = false, nid_list = false, prim_nid_present = false; - const char *const short_options = "k:n:h"; - const struct option long_options[] = { - { "prim_nid", 1, NULL, 'k' }, - { "nid", 1, NULL, 'n' }, - { "help", 0, NULL, 'h' }, - { NULL, 0, NULL, 0 }, - }; + const char *const short_opts = "k:n:"; + const struct option long_opts[] = { + { .name = "prim_nid", .has_arg = required_argument, .val = 'k' }, + { .name = "nid", .has_arg = required_argument, .val = 'n' }, + { .name = "ip2nets", .has_arg = required_argument, .val = 'i' }, + { .name = NULL } }; - while ((opt = getopt_long(argc, argv, short_options, - long_options, NULL)) != -1) { + rc = check_cmd(peer_cmds, "peer", "del", 2, argc, argv); + if (rc) + return rc; + + while ((opt = getopt_long(argc, argv, short_opts, + long_opts, NULL)) != -1) { switch (opt) { case 'k': + prim_nid_present = true; + if (ip2nets) { + cYAML_build_error(-1, -1, "peer", "add", + "ip2nets can not be specified" + " along side prim_nid parameter.", + &err_rc); + goto failed; + } prim_nid = optarg; break; + case 'i': case 'n': + if (opt == 'i') + ip2nets = true; + + if (opt == 'n') + nid_list = true; + + if (ip2nets && (nid_list || prim_nid_present)) { + cYAML_build_error(-1, -1, "peer", "add", + "ip2nets can not be specified" + " along side nid or prim_nid" + " parameters", &err_rc); + goto failed; + } size = lustre_lnet_parse_nids(optarg, nids, size, &nids2); if (nids2 == NULL) @@ -1170,15 +1670,22 @@ static int jt_del_peer_nid(int argc, char **argv) nids = nids2; rc = LUSTRE_CFG_RC_OUT_OF_MEM; break; - case 'h': + case '?': print_help(peer_cmds, "peer", "del"); - return 0; default: return 0; } } - rc = lustre_lnet_del_peer_nid(prim_nid, nids, size, -1, &err_rc); + for (; optind < argc; optind++) { + size = lustre_lnet_parse_nids(argv[optind], nids, size, + &nids2); + if (nids2 == NULL) + goto failed; + nids = nids2; + } + + rc = lustre_lnet_del_peer_nid(prim_nid, nids, size, ip2nets, -1, &err_rc); failed: if (nids) { @@ -1200,34 +1707,43 @@ static int jt_show_peer(int argc, char **argv) char *nid = NULL; int rc, opt; struct cYAML *err_rc = NULL, *show_rc = NULL; - int detail = 0; + long int detail = 0; - const char *const short_options = "n:vh"; - const struct option long_options[] = { - { "nid", 1, NULL, 'n' }, - { "verbose", 0, NULL, 'v' }, - { "help", 0, NULL, 'h' }, - { NULL, 0, NULL, 0 }, - }; + const char *const short_opts = "hn:v::"; + const struct option long_opts[] = { + { .name = "help", .has_arg = no_argument, .val = 'h' }, + { .name = "nid", .has_arg = required_argument, .val = 'n' }, + { .name = "verbose", .has_arg = optional_argument, .val = 'v' }, + { .name = NULL } }; - while ((opt = getopt_long(argc, argv, short_options, - long_options, NULL)) != -1) { + rc = check_cmd(peer_cmds, "peer", "show", 1, argc, argv); + if (rc) + return rc; + + while ((opt = getopt_long(argc, argv, short_opts, + long_opts, NULL)) != -1) { switch (opt) { case 'n': nid = optarg; break; case 'v': - detail = 1; + if ((!optarg) && (argv[optind] != NULL) && + (argv[optind][0] != '-')) { + if (parse_long(argv[optind++], &detail) != 0) + detail = 1; + } else { + detail = 1; + } break; - case 'h': + case '?': print_help(peer_cmds, "peer", "show"); - return 0; default: return 0; } } - rc = lustre_lnet_show_peer(nid, detail, -1, &show_rc, &err_rc); + rc = lustre_lnet_show_peer(nid, (int) detail, -1, &show_rc, &err_rc, + false); if (rc != LUSTRE_CFG_RC_NO_ERR) cYAML_print_tree2file(stderr, err_rc); @@ -1240,31 +1756,122 @@ static int jt_show_peer(int argc, char **argv) return rc; } -command_t list[] = { - {"lnet", jt_lnet, 0, "lnet {configure | unconfigure} [--all]"}, - {"route", jt_route, 0, "route {add | del | show | help}"}, - {"net", jt_net, 0, "net {add | del | show | help}"}, - {"routing", jt_routing, 0, "routing {show | help}"}, - {"set", jt_set, 0, "set {tiny_buffers | small_buffers | large_buffers" - " | routing}"}, - {"import", jt_import, 0, "import {--add | --del | --show | " - "--help} FILE.yaml"}, - {"export", jt_export, 0, "export {--help} FILE.yaml"}, - {"stats", jt_stats, 0, "stats {show | help}"}, - {"numa", jt_numa, 0, "numa {show | help}"}, - {"peer", jt_peers, 0, "peer {add | del | show | help}"}, - {"help", Parser_help, 0, "help"}, - {"exit", Parser_quit, 0, "quit"}, - {"quit", Parser_quit, 0, "quit"}, - {"--list-commands", lnetctl_list_commands, 0, "list commands"}, - { 0, 0, 0, NULL } -}; +static int jt_list_peer(int argc, char **argv) +{ + int rc; + struct cYAML *err_rc = NULL, *list_rc = NULL; + + rc = check_cmd(peer_cmds, "peer", "list", 0, argc, argv); + if (rc) + return rc; + + rc = lustre_lnet_list_peer(-1, &list_rc, &err_rc); + + if (rc != LUSTRE_CFG_RC_NO_ERR) + cYAML_print_tree2file(stderr, err_rc); + else if (list_rc) + cYAML_print_tree(list_rc); + + cYAML_free_tree(err_rc); + cYAML_free_tree(list_rc); + + return rc; +} + +static int jt_ping(int argc, char **argv) +{ + struct cYAML *err_rc = NULL; + struct cYAML *show_rc = NULL; + int timeout = 1000; + int rc = 0, opt; + + const char *const short_options = "ht:"; + const struct option long_options[] = { + { .name = "help", .has_arg = no_argument, .val = 'h' }, + { .name = "timeout", .has_arg = required_argument, .val = 't' }, + { .name = NULL } }; + + while ((opt = getopt_long(argc, argv, short_options, + long_options, NULL)) != -1) { + switch (opt) { + case 't': + timeout = 1000 * atol(optarg); + break; + case 'h': + printf("ping nid[,nid,...]\n" + "\t --timeout: ping timeout\n" + "\t --help: display this help\n"); + return 0; + default: + return 0; + } + } + + for (; optind < argc; optind++) + rc = lustre_lnet_ping_nid(argv[optind], timeout, -1, &show_rc, &err_rc); + + if (show_rc) + cYAML_print_tree(show_rc); + + if (err_rc) + cYAML_print_tree2file(stderr, err_rc); + + cYAML_free_tree(err_rc); + cYAML_free_tree(show_rc); + + return rc; +} + +static int jt_discover(int argc, char **argv) +{ + struct cYAML *err_rc = NULL; + struct cYAML *show_rc = NULL; + int force = 0; + int rc = 0, opt; + + const char *const short_options = "fh"; + const struct option long_options[] = { + { .name = "force", .has_arg = no_argument, .val = 'f' }, + { .name = "help", .has_arg = no_argument, .val = 'h' }, + { .name = NULL } }; + + while ((opt = getopt_long(argc, argv, short_options, + long_options, NULL)) != -1) { + switch (opt) { + case 'f': + force = 1; + break; + case 'h': + printf("discover nid[,nid,...]\n" + "\t --force: force discovery\n" + "\t --help: display this help\n"); + return 0; + default: + return 0; + } + } + + for (; optind < argc; optind++) + rc = lustre_lnet_discover_nid(argv[optind], force, -1, &show_rc, + &err_rc); + + if (show_rc) + cYAML_print_tree(show_rc); + + if (err_rc) + cYAML_print_tree2file(stderr, err_rc); + + cYAML_free_tree(err_rc); + cYAML_free_tree(show_rc); + + return rc; +} static int lnetctl_list_commands(int argc, char **argv) { char buffer[81] = ""; /* 80 printable chars + terminating NUL */ - Parser_list_commands(list, buffer, sizeof(buffer), NULL, 0, 4); + Parser_list_commands(cmd_list, buffer, sizeof(buffer), NULL, 0, 4); return 0; } @@ -1282,9 +1889,9 @@ int main(int argc, char **argv) return rc; } - Parser_init("lnetctl > ", list); + Parser_init("lnetctl > ", cmd_list); if (argc > 1) { - rc = Parser_execarg(argc - 1, &argv[1], list); + rc = Parser_execarg(argc - 1, &argv[1], cmd_list); goto errorout; }