X-Git-Url: https://git.whamcloud.com/?a=blobdiff_plain;f=build%2Fcvsdiffclient;h=ca09609476dcbc7d4b3c1d05c9cc584c6aae9f32;hb=5319b7a1ec96abf964cc74b90e41b783cba371aa;hp=1ad9afd14045ae4e9065c2e7ad8b791a7afdd9e3;hpb=e54c618cf0f3321aa3517bb97f0377ea7ab85316;p=fs%2Flustre-release.git

diff --git a/build/cvsdiffclient b/build/cvsdiffclient
index 1ad9afd..ca09609 100644
--- a/build/cvsdiffclient
+++ b/build/cvsdiffclient
@@ -6,7 +6,8 @@
 # in your .bashrc and you will get a nice bunch of CVS commit reminders:
 # <merge/land tag information>
 # b=<bug_number>
-# r=<reviewed by>
+# i=<inspected_by>
+# i=<inspected_by>
 #
 # Remember to remove the leading "CVS: " part of the comment before saving
 # your commit comment if you want those entries to be saved.
@@ -20,6 +21,12 @@ fi
 FILES=$($CVS_MODIFIED_FILES_PL $1)
 TMP=`mktemp /tmp/cvslog-XXXXXXXX`
 if [ -f $TMP ]; then
+	cat - >> $TMP <<- EOH
+		CVS: did you test your fix properly (acc-sm.sh, or as needed)?
+		CVS: did you update the ChangeLog for a bug fix?
+		CVS: did you verify/update affected user documentation?
+		CVS: Remove "CVS:" from lines below to include in commit message
+	EOH
 	[ -f .mergeinfo ] && . .mergeinfo
 	[ -z "$PARENT" -a -f lustre/.mergeinfo ] && . lustre/.mergeinfo
 	if [ "$PARENT" ]; then
@@ -32,14 +39,15 @@ if [ -f $TMP ]; then
 		[ "$TAG" ] && BRANCH="`sed 's/^T//' $TAG`" || BRANCH="HEAD"
 		echo "CVS: Branch $BRANCH" >> $TMP
 	fi
-cat - >> $TMP <<- EOF
-	CVS: Remove "CVS:" from start of lines that should be in commit message
-	CVS: did you update the ChangeLog for a bug fix?
-	CVS: did you update the hours spent in Bugzilla?
-	CVS: did you verify/update the HLD/DLD in CVS?
-	CVS: b=<bug>
-	CVS: r=<reviewed_by>
-EOF
+	# We can't just put these into the commit template without the leading
+	# "CVS: ", otherwise exiting the commend edit would still leave a valid
+	# comment in the file and the commit will still be done.  We need to
+	# make a file without valid comments to allow the commit to be aborted.
+	cat - >> $TMP <<- EOB
+		CVS: b=<bug>
+		CVS: i=<inspected_by>
+		CVS: i=<inspected_by>
+	EOB
 
 	cat $1 >> $TMP
 	cp $TMP $1