va_end(ap);
rc = fcntl(fd, cmd);
if (rc == -1) {
+ rc = -errno;
fprintf(stderr, "fcntl GETFL failed: %s\n",
strerror(errno));
- return(1);
+ return rc;
}
break;
case F_SETFL:
va_end(ap);
rc = fcntl(fd, cmd, arg);
if (rc == -1) {
+ rc = -errno;
fprintf(stderr, "fcntl SETFL %ld failed: %s\n",
arg, strerror(errno));
- return(1);
+ return rc ;
}
break;
case F_GETLK:
va_end(ap);
rc = fcntl(fd, cmd, lock);
if (rc == -1) {
+ rc = -errno;
fprintf(stderr, "fcntl cmd %d failed: %s\n",
cmd, strerror(errno));
- return(1);
+ return rc ;
}
break;
case F_DUPFD:
va_end(ap);
rc = fcntl(fd, cmd, arg);
if (rc == -1) {
+ rc = -errno;
fprintf(stderr, "fcntl F_DUPFD %d failed: %s\n",
(int)arg, strerror(errno));
- return(1);
+ return rc;
}
break;
default:
va_end(ap);
fprintf(stderr, "fcntl cmd %d not supported\n", cmd);
- return(1);
+ return rc;
}
return rc;
}
}
if ((fd = open(argv[4], O_RDWR)) < 0) {
- fprintf(stderr, "Couldn't open file: %s\n", argv[3]);
+ fprintf(stderr, "Couldn't open file: %s\n", argv[4]);
return EXIT_FAILURE;
}
t_fcntl(fd, F_SETFL, O_APPEND);
rc = t_fcntl(fd, F_GETFL);
- if ((rc & O_APPEND) == 0) {
+ if ((rc < 0) || (rc & O_APPEND) == 0) {
fprintf(stderr, "error get flag: ret %x\n", rc);
rc = EXIT_FAILURE;
goto out;
}
if ((fd = open(argv[2], O_RDWR)) < 0) {
- fprintf(stderr, "Couldn't open file: %s\n", argv[1]);
+ fprintf(stderr, "Couldn't open file: %s\n", argv[2]);
return EXIT_FAILURE;
}
if (flock(fd, LOCK_EX | LOCK_NB) < 0) {
goto out;
}
if ((fd2 = open(argv[2], O_RDWR)) < 0) {
- fprintf(stderr, "Couldn't open file: %s\n", argv[1]);
+ fprintf(stderr, "Couldn't open file: %s\n", argv[2]);
rc = EXIT_FAILURE;
goto out;
}
};
int fd, fd2;
- int pid;
+ pid_t child_pid;
+ int child_status;
int rc = EXIT_SUCCESS;
if (argc != 4) {
goto out;
}
- pid = fork();
- if (pid == -1) {
+ child_pid = fork();
+ if (child_pid < 0) {
perror("fork");
rc = EXIT_FAILURE;
goto out;
}
- if (pid == 0) {
+ if (child_pid == 0) {
printf("%d: get lock1\n", getpid());
fflush(stdout);
if (t_fcntl(fd, F_SETLKW, &lock) < 0) {
- perror("first flock failed");
+ fprintf(stderr, "%d: cannot get lock1: %s\n",
+ getpid(), strerror(errno));
rc = EXIT_FAILURE;
goto out_child;
}
printf("%d: get lock2\n", getpid());
fflush(stdout);
if (t_fcntl(fd2, F_SETLKW, &lock) < 0) {
- perror("first flock failed");
- rc = EXIT_FAILURE;
+ fprintf(stderr, "%d: cannot get lock2: %s\n",
+ getpid(), strerror(errno));
+
+ if (errno == EDEADLK)
+ rc = EXIT_SUCCESS;
+ else
+ rc = EXIT_FAILURE;
+
goto out_child;
}
printf("%d: done\n", getpid());
printf("%d: get lock2\n", getpid());
fflush(stdout);
if (t_fcntl(fd2, F_SETLKW, &lock) < 0) {
- perror("first flock failed");
+ fprintf(stderr, "%d: cannot get lock2: %s\n",
+ getpid(), strerror(errno));
rc = EXIT_FAILURE;
goto out;
}
printf("%d: get lock1\n", getpid());
fflush(stdout);
if (t_fcntl(fd, F_SETLKW, &lock) < 0) {
- perror("first flock failed");
- rc = EXIT_FAILURE;
- goto out;
+ fprintf(stderr, "%d: cannot get lock1: %s\n",
+ getpid(), strerror(errno));
+
+ if (errno != EDEADLK) {
+ rc = EXIT_FAILURE;
+ goto out;
+ }
}
printf("%d: done\n", getpid());
}
+ sleep(1);
+
+ if (close(fd) < 0) {
+ fprintf(stderr, "%d: error closing file1: %s\n",
+ getpid(), strerror(errno));
+ rc = EXIT_FAILURE;
+ }
+
+ if (close(fd2) < 0) {
+ fprintf(stderr, "%d: error closing file2: %s\n",
+ getpid(), strerror(errno));
+ rc = EXIT_FAILURE;
+ }
+
+ if (waitpid(child_pid, &child_status, 0) < 0) {
+ fprintf(stderr, "%d: cannot get termination status of %d: %s\n",
+ getpid(), child_pid, strerror(errno));
+ rc = EXIT_FAILURE;
+ } else if (!WIFEXITED(child_status)) {
+ fprintf(stderr, "%d: child %d terminated with status %d\n",
+ getpid(), child_pid, child_status);
+ rc = EXIT_FAILURE;
+ } else {
+ rc = WEXITSTATUS(child_status);
+ }
+
out:
printf("%d: exit rc=%d\n", getpid(), rc);
return rc;
}
+#define T5_USAGE \
+ "Usage: ./flocks_test 5 set|get|unlock [read|write] [sleep N] file1\n"\
+" set: F_SETLKW F_WRLCK\n" \
+" get: F_GETLK F_WRLCK (conflict)\n" \
+" unlock: F_SETLKW F_UNLCK\n" \
+" read|write: lock mode, write by default\n" \
+" sleep N: sleep for N secs after fcntl\n" \
+" file1: fcntl is called for this file\n"
+
+int t5(int argc, char *argv[])
+{
+ struct flock lock = {
+ .l_type = F_WRLCK,
+ .l_whence = SEEK_SET,
+ };
+
+ int setlk = 0, getlk = 0, unlk = 0, secs = 0;
+ int pos;
+ int fd;
+ int rc = 0;
+
+ if (argc < 4 || argc > 7) {
+ fprintf(stderr, T5_USAGE);
+ return EXIT_FAILURE;
+ }
+
+ if (!strncmp(argv[2], "set", 4))
+ setlk = 1;
+ else if (!strncmp(argv[2], "get", 4))
+ getlk = 1;
+ else if (!strncmp(argv[2], "unlock", 7))
+ unlk = 1;
+ else {
+ fprintf(stderr, "Wrong 2nd argument: %s\n", argv[2]);
+ return EXIT_FAILURE;
+ }
+
+ pos = 3;
+
+ if (!strncmp(argv[pos], "read", 5)) {
+ lock.l_type = F_RDLCK;
+ pos++;
+ } else if (!strncmp(argv[pos], "write", 6)) {
+ lock.l_type = F_WRLCK;
+ pos++;
+ }
+
+ if (!strncmp(argv[pos], "sleep", 6)) {
+ secs = atoi(argv[pos + 1]);
+ if (secs < 0 || secs > 10) {
+ fprintf(stderr, "Sleep argument is wrong: %s\n",
+ argv[pos + 1]);
+ return EXIT_FAILURE;
+ }
+ pos += 2;
+ }
+
+ fd = open(argv[pos], O_RDWR);
+ if (fd < 0) {
+ fprintf(stderr, "Couldn't open file: %s\n", argv[pos]);
+ return EXIT_FAILURE;
+ }
+
+ fprintf(stderr, "\nFLOCKS_TEST 5: %s %s flock\n",
+ setlk ? "SET" : getlk ? "GET" : "UNLOCK",
+ lock.l_type == F_WRLCK ? "write" : "read");
+
+ if (setlk) {
+ rc = t_fcntl(fd, F_SETLKW, &lock);
+ } else if (getlk) {
+ rc = t_fcntl(fd, F_GETLK, &lock);
+ } else if (unlk) {
+ lock.l_type = F_UNLCK;
+ rc = t_fcntl(fd, F_SETLKW, &lock);
+ }
+
+ if (secs)
+ sleep(secs);
+
+ close(fd);
+ return rc < 0 ? -rc : 0;
+
+}
+
/** ==============================================================
* program entry
*/
case 4:
rc = t4(argc, argv);
break;
- default:
+ case 5:
+ rc = t5(argc, argv);
+ break;
+ default:
fprintf(stderr, "unknow test number %s\n", argv[1]);
break;
}