* Copyright (c) 2009, 2010, Oracle and/or its affiliates. All rights reserved.
* Use is subject to license terms.
*
- * Copyright (c) 2011, 2014, Intel Corporation.
+ * Copyright (c) 2011, 2015, Intel Corporation.
*/
/*
* This file is part of Lustre, http://www.lustre.org/
{
CDEBUG(D_TRACE, "%s: free reply data %p: xid %llu, transno %llu, "
"client gen %u, slot idx %d\n",
- tgt_name(lut), trd, trd->trd_reply.lrd_xid,
+ lut == NULL ? "" : tgt_name(lut), trd, trd->trd_reply.lrd_xid,
trd->trd_reply.lrd_transno, trd->trd_reply.lrd_client_gen,
trd->trd_index);
list_del(&trd->trd_list);
ted->ted_reply_cnt--;
- tgt_clear_reply_slot(lut, trd->trd_index);
+ if (lut != NULL)
+ tgt_clear_reply_slot(lut, trd->trd_index);
OBD_FREE_PTR(trd);
}
{
CDEBUG(D_TRACE, "%s: release reply data %p: xid %llu, transno %llu, "
"client gen %u, slot idx %d\n",
- tgt_name(lut), trd, trd->trd_reply.lrd_xid,
+ lut == NULL ? "" : tgt_name(lut), trd, trd->trd_reply.lrd_xid,
trd->trd_reply.lrd_transno, trd->trd_reply.lrd_client_gen,
trd->trd_index);
OBD_FREE_PTR(ted->ted_lcd);
ted->ted_lcd = NULL;
- /* Slot may be not yet assigned */
- if (ted->ted_lr_idx < 0)
+ /* Target may have been freed (see LU-7430)
+ * Slot may be not yet assigned */
+ if (exp->exp_obd->u.obt.obt_magic != OBT_MAGIC ||
+ ted->ted_lr_idx < 0)
return;
+
/* Clear bit when lcd is freed */
LASSERT(lut && lut->lut_client_bitmap);
if (!test_and_clear_bit(ted->ted_lr_idx, lut->lut_client_bitmap)) {
}
/**
- * commit callback, need to update last_commited value
+ * commit callback, need to update last_committed value
*/
struct tgt_last_committed_callback {
struct dt_txn_commit_cb llcc_cb;
if (ccb->llcc_transno > ccb->llcc_exp->exp_last_committed) {
ccb->llcc_exp->exp_last_committed = ccb->llcc_transno;
spin_unlock(&ccb->llcc_tgt->lut_translock);
+
ptlrpc_commit_replies(ccb->llcc_exp);
+ tgt_cancel_slc_locks(ccb->llcc_transno);
} else {
spin_unlock(&ccb->llcc_tgt->lut_translock);
}
struct tg_export_data *ted;
__u64 *transno_p;
int rc = 0;
- bool lw_client, update = false;
+ bool lw_client;
ENTRY;
spin_lock(&tgt->lut_translock);
if (tti->tti_transno > tgt->lut_lsd.lsd_last_transno) {
tgt->lut_lsd.lsd_last_transno = tti->tti_transno;
- update = true;
+ spin_unlock(&tgt->lut_translock);
+ /* Although lightweight (LW) connections have no slot
+ * in the last_rcvd, we still want to maintain
+ * the in-memory lsd_client_data structure in order to
+ * properly handle reply reconstruction. */
+ rc = tgt_server_data_write(env, tgt, th);
+ } else {
+ spin_unlock(&tgt->lut_translock);
}
- spin_unlock(&tgt->lut_translock);
- /* Although lightweight (LW) connections have no slot in
- * last_rcvd, we still want to maintain the in-memory
- * lsd_client_data structure in order to properly handle reply
- * reconstruction. */
} else if (ted->ted_lr_off == 0) {
CERROR("%s: client idx %d has offset %lld\n",
tgt_name(tgt), ted->ted_lr_idx, ted->ted_lr_off);
RETURN(-EINVAL);
}
- /* if the export has already been disconnected, we have no last_rcvd
- * slot, update server data with latest transno then */
- if (ted->ted_lcd == NULL) {
- CWARN("commit transaction for disconnected client %s: rc %d\n",
- exp->exp_client_uuid.uuid, rc);
- GOTO(srv_update, rc = 0);
- }
-
/* Target that supports multiple reply data */
if (tgt_is_multimodrpcs_client(exp)) {
struct tg_reply_data *trd;
OBD_ALLOC_PTR(trd);
if (unlikely(trd == NULL))
- GOTO(srv_update, rc = -ENOMEM);
+ RETURN(-ENOMEM);
/* fill reply data information */
lrd = &trd->trd_reply;
}
rc = tgt_add_reply_data(env, tgt, ted, trd, th, write_update);
- GOTO(srv_update, rc);
+ if (rc < 0)
+ OBD_FREE_PTR(trd);
+ return rc;
}
/* Enough for update replay, let's return */
if (req == NULL)
- GOTO(srv_update, rc);
+ RETURN(rc);
mutex_lock(&ted->ted_lcd_lock);
LASSERT(ergo(tti->tti_transno == 0, th->th_result != 0));
/* Update transno in slot only if non-zero number, i.e. no errors */
if (likely(tti->tti_transno != 0)) {
- if (*transno_p > tti->tti_transno &&
- !tgt->lut_no_reconstruct) {
- CERROR("%s: trying to overwrite bigger transno:"
- "on-disk: "LPU64", new: "LPU64" replay: %d. "
- "see LU-617.\n", tgt_name(tgt), *transno_p,
- tti->tti_transno, req_is_replay(req));
- if (req_is_replay(req)) {
- spin_lock(&req->rq_export->exp_lock);
- req->rq_export->exp_vbr_failed = 1;
- spin_unlock(&req->rq_export->exp_lock);
+ /* Don't overwrite bigger transaction number with lower one.
+ * That is not sign of problem in all cases, but in any case
+ * this value should be monotonically increased only. */
+ if (*transno_p > tti->tti_transno) {
+ if (!tgt->lut_no_reconstruct) {
+ CERROR("%s: trying to overwrite bigger transno:"
+ "on-disk: "LPU64", new: "LPU64" replay: "
+ "%d. See LU-617.\n", tgt_name(tgt),
+ *transno_p, tti->tti_transno,
+ req_is_replay(req));
+ if (req_is_replay(req)) {
+ spin_lock(&req->rq_export->exp_lock);
+ req->rq_export->exp_vbr_failed = 1;
+ spin_unlock(&req->rq_export->exp_lock);
+ }
+ mutex_unlock(&ted->ted_lcd_lock);
+ RETURN(req_is_replay(req) ? -EOVERFLOW : 0);
}
- mutex_unlock(&ted->ted_lcd_lock);
- RETURN(req_is_replay(req) ? -EOVERFLOW : 0);
+ } else {
+ *transno_p = tti->tti_transno;
}
- *transno_p = tti->tti_transno;
}
if (!lw_client) {
}
}
mutex_unlock(&ted->ted_lcd_lock);
- EXIT;
-srv_update:
- if (update)
- rc = tgt_server_data_write(env, tgt, th);
- return rc;
+ RETURN(rc);
}
/*
if (rc)
return rc;
+ if (tgt_is_multimodrpcs_client(tsi->tsi_exp)) {
+ /*
+ * Use maximum possible file offset for declaration to ensure
+ * ZFS will reserve enough credits for a write anywhere in this
+ * file, since we don't know where in the file the write will be
+ * because a replay slot has not been assigned. This should be
+ * replaced by dmu_tx_hold_append() when available.
+ */
+ tti->tti_off = atomic_read(&tgt->lut_num_clients) * 8 *
+ sizeof(struct lsd_reply_data);
+ tti->tti_buf.lb_buf = NULL;
+ tti->tti_buf.lb_len = sizeof(struct lsd_reply_data);
+ dto = dt_object_locate(tgt->lut_reply_data, th->th_dev);
+ rc = dt_declare_record_write(env, dto, &tti->tti_buf,
+ tti->tti_off, th);
+ if (rc)
+ return rc;
+ }
+
if (tsi->tsi_vbr_obj != NULL &&
!lu_object_remote(&tsi->tsi_vbr_obj->do_lu)) {
dto = dt_object_locate(tsi->tsi_vbr_obj, th->th_dev);
git://git.whamcloud.com / fs / lustre-release.git / blobdiff