Whamcloud - gitweb
LU-4611 osd: improve credits calculation
[fs/lustre-release.git] / lustre / osd-ldiskfs / osd_io.c
index eeae025..7bab102 100644 (file)
@@ -1314,36 +1314,149 @@ static ssize_t osd_read(const struct lu_env *env, struct dt_object *dt,
         return rc;
 }
 
+static inline int osd_extents_enabled(struct super_block *sb,
+                                     struct inode *inode)
+{
+       if (inode != NULL) {
+               if (LDISKFS_I(inode)->i_flags & LDISKFS_EXTENTS_FL)
+                       return 1;
+       } else if (test_opt(sb, EXTENTS)) {
+               return 1;
+       }
+       return 0;
+}
+
+static inline int osd_calc_bkmap_credits(struct super_block *sb,
+                                        struct inode *inode,
+                                        const loff_t size,
+                                        const loff_t pos,
+                                        const int blocks)
+{
+       int credits, bits, bs, i;
+
+       bits = sb->s_blocksize_bits;
+       bs = 1 << bits;
+
+       /* legacy blockmap: 3 levels * 3 (bitmap,gd,itself)
+        * we do not expect blockmaps on the large files,
+        * so let's shrink it to 2 levels (4GB files) */
+
+       /* this is default reservation: 2 levels */
+       credits = (blocks + 2) * 3;
+
+       /* actual offset is unknown, hard to optimize */
+       if (pos == -1)
+               return credits;
+
+       /* now check for few specific cases to optimize */
+       if (pos + size <= LDISKFS_NDIR_BLOCKS * bs) {
+               /* no indirects */
+               credits = blocks;
+               /* allocate if not allocated */
+               if (inode == NULL) {
+                       credits += blocks * 2;
+                       return credits;
+               }
+               for (i = (pos >> bits); i < (pos >> bits) + blocks; i++) {
+                       LASSERT(i < LDISKFS_NDIR_BLOCKS);
+                       if (LDISKFS_I(inode)->i_data[i] == 0)
+                               credits += 2;
+               }
+       } else if (pos + size <= (LDISKFS_NDIR_BLOCKS + 1024) * bs) {
+               /* single indirect */
+               credits = blocks * 3;
+               /* probably indirect block has been allocated already */
+               if (!inode || LDISKFS_I(inode)->i_data[LDISKFS_IND_BLOCK])
+                       credits += 3;
+       }
+
+       return credits;
+}
+
 static ssize_t osd_declare_write(const struct lu_env *env, struct dt_object *dt,
-                                 const loff_t size, loff_t pos,
-                                 struct thandle *handle)
+                                const struct lu_buf *buf, loff_t _pos,
+                                struct thandle *handle)
 {
-        struct osd_thandle *oh;
-        int                 credits;
-       struct inode       *inode;
-       int                 rc;
+       struct osd_object  *obj  = osd_dt_obj(dt);
+       struct inode       *inode = obj->oo_inode;
+       struct super_block *sb = osd_sb(osd_obj2dev(obj));
+       struct osd_thandle *oh;
+       int                 rc = 0, est = 0, credits, blocks, allocated = 0;
+       int                 bits, bs;
+       int                 depth, size;
+       loff_t              pos;
        ENTRY;
 
+       LASSERT(buf != NULL);
         LASSERT(handle != NULL);
 
         oh = container_of0(handle, struct osd_thandle, ot_super);
         LASSERT(oh->ot_handle == NULL);
 
-       credits = osd_dto_credits_noquota[DTO_WRITE_BLOCK];
+       size = buf->lb_len;
+       bits = sb->s_blocksize_bits;
+       bs = 1 << bits;
 
-       osd_trans_declare_op(env, oh, OSD_OT_WRITE, credits);
+       if (_pos == -1) {
+               /* if this is an append, then we
+                * should expect cross-block record */
+               pos = 0;
+       } else {
+               pos = _pos;
+       }
 
-       inode = osd_dt_obj(dt)->oo_inode;
+       /* blocks to modify */
+       blocks = ((pos + size + bs - 1) >> bits) - (pos >> bits);
+       LASSERT(blocks > 0);
+
+       if (inode != NULL && _pos != -1) {
+               /* object size in blocks */
+               est = (i_size_read(inode) + bs - 1) >> bits;
+               allocated = inode->i_blocks >> (bits - 9);
+               if (pos + size <= i_size_read(inode) && est <= allocated) {
+                       /* looks like an overwrite, no need to modify tree */
+                       credits = blocks;
+                       /* no need to modify i_size */
+                       goto out;
+               }
+       }
 
-       /* we may declare write to non-exist llog */
-       if (inode == NULL)
-               RETURN(0);
+       if (osd_extents_enabled(sb, inode)) {
+               /*
+                * many concurrent threads may grow tree by the time
+                * our transaction starts. so, consider 2 is a min depth
+                * for every level we may need to allocate a new block
+                * and take some entries from the old one. so, 3 blocks
+                * to allocate (bitmap, gd, itself) + old block - 4 per
+                * level.
+                */
+               depth = inode != NULL ? ext_depth(inode) : 0;
+               depth = max(depth, 1) + 1;
+               credits = depth;
+               /* if not append, then split may need to modify
+                * existing blocks moving entries into the new ones */
+               if (_pos == -1)
+                       credits += depth;
+               /* blocks to store data: bitmap,gd,itself */
+               credits += blocks * 3;
+       } else {
+               credits = osd_calc_bkmap_credits(sb, inode, size, _pos, blocks);
+       }
+       /* if inode is created as part of the transaction,
+        * then it's counted already by the creation method */
+       if (inode != NULL)
+               credits++;
+
+out:
+
+       osd_trans_declare_op(env, oh, OSD_OT_WRITE, credits);
 
        /* dt_declare_write() is usually called for system objects, such
         * as llog or last_rcvd files. We needn't enforce quota on those
         * objects, so always set the lqi_space as 0. */
-       rc = osd_declare_inode_qid(env, inode->i_uid, inode->i_gid, 0, oh,
-                                  true, true, NULL, false);
+       if (inode != NULL)
+               rc = osd_declare_inode_qid(env, inode->i_uid, inode->i_gid,
+                                          0, oh, true, true, NULL, false);
        RETURN(rc);
 }
 
@@ -1513,48 +1626,44 @@ static int osd_declare_punch(const struct lu_env *env, struct dt_object *dt,
 }
 
 static int osd_punch(const struct lu_env *env, struct dt_object *dt,
-                     __u64 start, __u64 end, struct thandle *th,
-                     struct lustre_capa *capa)
+                    __u64 start, __u64 end, struct thandle *th,
+                    struct lustre_capa *capa)
 {
-        struct osd_thandle *oh;
-        struct osd_object  *obj = osd_dt_obj(dt);
-        struct inode       *inode = obj->oo_inode;
-        handle_t           *h;
-        tid_t               tid;
+       struct osd_thandle *oh;
+       struct osd_object  *obj = osd_dt_obj(dt);
+       struct inode       *inode = obj->oo_inode;
+       handle_t           *h;
+       tid_t               tid;
        int                rc = 0, rc2 = 0;
-        ENTRY;
+       ENTRY;
 
-        LASSERT(end == OBD_OBJECT_EOF);
-        LASSERT(dt_object_exists(dt));
-        LASSERT(osd_invariant(obj));
+       LASSERT(end == OBD_OBJECT_EOF);
+       LASSERT(dt_object_exists(dt));
+       LASSERT(osd_invariant(obj));
        LASSERT(inode != NULL);
        ll_vfs_dq_init(inode);
 
-        LASSERT(th);
-        oh = container_of(th, struct osd_thandle, ot_super);
-        LASSERT(oh->ot_handle->h_transaction != NULL);
+       LASSERT(th);
+       oh = container_of(th, struct osd_thandle, ot_super);
+       LASSERT(oh->ot_handle->h_transaction != NULL);
 
        osd_trans_exec_op(env, th, OSD_OT_PUNCH);
 
-        tid = oh->ot_handle->h_transaction->t_tid;
+       tid = oh->ot_handle->h_transaction->t_tid;
 
        i_size_write(inode, start);
        ll_truncate_pagecache(inode, start);
 #ifdef HAVE_INODEOPS_TRUNCATE
-       if (inode->i_op->truncate)
+       if (inode->i_op->truncate) {
                inode->i_op->truncate(inode);
-#else
-       if (!(inode->i_state & (I_NEW|I_FREEING)))
-               mutex_lock(&inode->i_mutex);
-       ldiskfs_truncate(inode);
-       if (!(inode->i_state & (I_NEW|I_FREEING)))
-               mutex_unlock(&inode->i_mutex);
+       } else
 #endif
+               ldiskfs_truncate(inode);
 
-        /*
-         * For a partial-page truncate, flush the page to disk immediately to
-         * avoid data corruption during direct disk write.  b=17397
-         */
+       /*
+        * For a partial-page truncate, flush the page to disk immediately to
+        * avoid data corruption during direct disk write.  b=17397
+        */
        if ((start & ~CFS_PAGE_MASK) != 0)
                 rc = filemap_fdatawrite_range(inode->i_mapping, start, start+1);