LU-8649 recovery: print some useful messages in recovery

[fs/lustre-release.git] / lustre / obdclass / kernelcomm.c

diff --git a/lustre/obdclass/kernelcomm.c b/lustre/obdclass/kernelcomm.c
index 0787f46..041d33e 100644 (file)
--- a/lustre/obdclass/kernelcomm.c
+++ b/lustre/obdclass/kernelcomm.c
@@ -100,27 +100,41 @@ EXPORT_SYMBOL(libcfs_kkuc_msg_put);
 /** A single group registration has a uid and a file pointer */
 struct kkuc_reg {
        struct list_head kr_chain;
+       struct obd_uuid  kr_uuid;
        int              kr_uid;
        struct file     *kr_fp;
        char             kr_data[0];
 };
 
-static struct list_head kkuc_groups[KUC_GRP_MAX+1] = {};
+static struct list_head kkuc_groups[KUC_GRP_MAX + 1];
 /* Protect message sending against remove and adds */
 static DECLARE_RWSEM(kg_sem);
 
+static inline bool libcfs_kkuc_group_is_valid(int group)
+{
+       return 0 <= group && group < ARRAY_SIZE(kkuc_groups);
+}
+
+void libcfs_kkuc_init(void)
+{
+       int group;
+
+       for (group = 0; group < ARRAY_SIZE(kkuc_groups); group++)
+               INIT_LIST_HEAD(&kkuc_groups[group]);
+}
+
 /** Add a receiver to a broadcast group
  * @param filp pipe to write into
  * @param uid identifier for this receiver
  * @param group group number
  * @param data user data
  */
-int libcfs_kkuc_group_add(struct file *filp, int uid, int group,
-                         void *data, size_t data_len)
+int libcfs_kkuc_group_add(struct file *filp, const struct obd_uuid *uuid,
+                         int uid, int group, void *data, size_t data_len)
 {
        struct kkuc_reg *reg;
 
-       if (group > KUC_GRP_MAX) {
+       if (!libcfs_kkuc_group_is_valid(group)) {
                CDEBUG(D_WARNING, "Kernelcomm: bad group %d\n", group);
                return -EINVAL;
        }
@@ -130,17 +144,16 @@ int libcfs_kkuc_group_add(struct file *filp, int uid, int group,
                return -EBADF;
 
        /* freed in group_rem */
-       reg = kmalloc(sizeof(*reg) + data_len, 0);
+       reg = kzalloc(sizeof(*reg) + data_len, 0);
        if (reg == NULL)
                return -ENOMEM;
 
+       reg->kr_uuid = *uuid;
        reg->kr_fp = filp;
        reg->kr_uid = uid;
        memcpy(reg->kr_data, data, data_len);
 
        down_write(&kg_sem);
-       if (kkuc_groups[group].next == NULL)
-               INIT_LIST_HEAD(&kkuc_groups[group]);
        list_add(&reg->kr_chain, &kkuc_groups[group]);
        up_write(&kg_sem);
 
@@ -150,13 +163,15 @@ int libcfs_kkuc_group_add(struct file *filp, int uid, int group,
 }
 EXPORT_SYMBOL(libcfs_kkuc_group_add);
 
-int libcfs_kkuc_group_rem(int uid, int group)
+int libcfs_kkuc_group_rem(const struct obd_uuid *uuid, int uid, int group)
 {
        struct kkuc_reg *reg, *next;
        ENTRY;
 
-       if (kkuc_groups[group].next == NULL)
-               RETURN(0);
+       if (!libcfs_kkuc_group_is_valid(group)) {
+               CDEBUG(D_WARNING, "Kernelcomm: bad group %d\n", group);
+               return -EINVAL;
+       }
 
        if (uid == 0) {
                /* Broadcast a shutdown message */
@@ -166,12 +181,13 @@ int libcfs_kkuc_group_rem(int uid, int group)
                lh.kuc_transport = KUC_TRANSPORT_GENERIC;
                lh.kuc_msgtype = KUC_MSG_SHUTDOWN;
                lh.kuc_msglen = sizeof(lh);
-               libcfs_kkuc_group_put(group, &lh);
+               libcfs_kkuc_group_put(uuid, group, &lh);
        }
 
        down_write(&kg_sem);
        list_for_each_entry_safe(reg, next, &kkuc_groups[group], kr_chain) {
-               if ((uid == 0) || (uid == reg->kr_uid)) {
+               if (obd_uuid_equals(uuid, &reg->kr_uuid) &&
+                   (uid == 0 || uid == reg->kr_uid)) {
                        list_del(&reg->kr_chain);
                        CDEBUG(D_KUC, "Removed uid=%d fp=%p from group %d\n",
                                reg->kr_uid, reg->kr_fp, group);
@@ -186,16 +202,30 @@ int libcfs_kkuc_group_rem(int uid, int group)
 }
 EXPORT_SYMBOL(libcfs_kkuc_group_rem);
 
-int libcfs_kkuc_group_put(int group, void *payload)
+int libcfs_kkuc_group_put(const struct obd_uuid *uuid, int group, void *payload)
 {
        struct kkuc_reg *reg;
        int              rc = 0;
        int one_success = 0;
        ENTRY;
 
+       if (!libcfs_kkuc_group_is_valid(group)) {
+               CDEBUG(D_WARNING, "Kernelcomm: bad group %d\n", group);
+               return -EINVAL;
+       }
+
        down_write(&kg_sem);
+
+       if (unlikely(list_empty(&kkuc_groups[group])) ||
+           unlikely(OBD_FAIL_CHECK(OBD_FAIL_MDS_HSM_CT_REGISTER_NET))) {
+               /* no agent have fully registered, CDT will retry */
+               up_write(&kg_sem);
+               RETURN(-EAGAIN);
+       }
+
        list_for_each_entry(reg, &kkuc_groups[group], kr_chain) {
-               if (reg->kr_fp != NULL) {
+               if (obd_uuid_equals(uuid, &reg->kr_uuid) &&
+                   reg->kr_fp != NULL) {
                        rc = libcfs_kkuc_msg_put(reg->kr_fp, payload);
                        if (rc == 0)
                                one_success = 1;
@@ -222,25 +252,21 @@ EXPORT_SYMBOL(libcfs_kkuc_group_put);
  * @param cb_func the function to be called.
  * @param cb_arg extra argument to be passed to the callback function.
  */
-int libcfs_kkuc_group_foreach(int group, libcfs_kkuc_cb_t cb_func,
-                             void *cb_arg)
+int libcfs_kkuc_group_foreach(const struct obd_uuid *uuid, int group,
+                             libcfs_kkuc_cb_t cb_func, void *cb_arg)
 {
        struct kkuc_reg *reg;
        int              rc = 0;
        ENTRY;
 
-       if (group > KUC_GRP_MAX) {
+       if (!libcfs_kkuc_group_is_valid(group)) {
                CDEBUG(D_WARNING, "Kernelcomm: bad group %d\n", group);
                RETURN(-EINVAL);
        }
 
-       /* no link for this group */
-       if (kkuc_groups[group].next == NULL)
-               RETURN(0);
-
        down_read(&kg_sem);
        list_for_each_entry(reg, &kkuc_groups[group], kr_chain) {
-               if (reg->kr_fp != NULL)
+               if (obd_uuid_equals(uuid, &reg->kr_uuid) && reg->kr_fp != NULL)
                        rc = cb_func(reg->kr_data, cb_arg);
        }
        up_read(&kg_sem);