Whamcloud - gitweb
class_obd.c: plugged a few minor memory leaks
[fs/lustre-release.git] / lustre / obdclass / genops.c
index 3eaa05d..c4f1533 100644 (file)
  *
  */
 
-#include <asm/uaccess.h>
-#include <linux/sched.h>
-#include <linux/stat.h>
+#include <linux/config.h>
+#include <linux/kernel.h>
+#include <linux/mm.h>
 #include <linux/string.h>
+#include <linux/stat.h>
+#include <linux/errno.h>
 #include <linux/locks.h>
-#include <linux/quotaops.h>
-#include <linux/list.h>
-#include <linux/file.h>
-#include <linux/iobuf.h>
-#include <asm/bitops.h>
-#include <asm/byteorder.h>
+#include <linux/unistd.h>
+
+#include <asm/system.h>
+#include <asm/uaccess.h>
+
+#include <linux/fs.h>
+#include <linux/stat.h>
+#include <asm/uaccess.h>
+#include <linux/vmalloc.h>
+#include <asm/segment.h>
+#include <linux/mm.h>
+#include <linux/pagemap.h>
+#include <linux/smp_lock.h>
+
 #include <linux/obd_support.h>
 #include <linux/obd_class.h>
 
 
 extern struct obd_device obd_dev[MAX_OBD_DEVICES];
+kmem_cache_t *obdo_cachep = NULL;
+
+int obd_init_obdo_cache(void)
+{
+       ENTRY;
+       if (obdo_cachep == NULL) {
+               CDEBUG(D_CACHE, "allocating obdo_cache\n");
+               obdo_cachep = kmem_cache_create("obdo_cache",
+                                               sizeof(struct obdo),
+                                               0, SLAB_HWCACHE_ALIGN,
+                                               NULL, NULL);
+               if (obdo_cachep == NULL) {
+                       EXIT;
+                       return -ENOMEM;
+               } else {
+                       CDEBUG(D_CACHE, "allocated cache at %p\n", obdo_cachep);
+               }
+       } else {
+               CDEBUG(D_CACHE, "using existing cache at %p\n", obdo_cachep);
+       }
+       EXIT;
+       return 0;
+}
+
+void obd_cleanup_obdo_cache(void)
+{
+       ENTRY;
+       if (obdo_cachep != NULL) {
+               CDEBUG(D_CACHE, "destroying obdo_cache at %p\n", obdo_cachep);
+               if (kmem_cache_destroy(obdo_cachep))
+                       printk(KERN_WARNING __FUNCTION__
+                              ": unable to free cache\n");
+       } else
+               printk(KERN_INFO __FUNCTION__
+                      ": called with NULL cache pointer\n");
+
+       obdo_cachep = NULL;
+       EXIT;
+}
+
 
 /* map connection to client */
-struct obd_client *gen_client(int cli_id)
+struct obd_client *gen_client(struct obd_conn *conn)
 {
-       struct obd_device * obddev;
+       struct obd_device * obddev = conn->oc_dev;
        struct list_head * lh, * next;
        struct obd_client * cli;
-       int a;
-
-       for (a = 0; a < MAX_OBD_DEVICES; a++) {
-               obddev = &obd_dev[a];
 
-               lh = next = &obddev->obd_gen_clients;
-               while ((lh = lh->next) != &obddev->obd_gen_clients) {
-                       cli = list_entry(lh, struct obd_client, cli_chain);
-                       
-                       if (cli->cli_id == cli_id)
-                               return cli;
-               }
+       lh = next = &obddev->obd_gen_clients;
+       while ((lh = lh->next) != &obddev->obd_gen_clients) {
+               cli = list_entry(lh, struct obd_client, cli_chain);
+               
+               if (cli->cli_id == conn->oc_id)
+                       return cli;
        }
 
        return NULL;
 } /* obd_client */
 
 
-
 /* a connection defines a context in which preallocation can be managed. */ 
-int gen_connect (struct obd_device *obddev, 
-                       struct obd_conn_info * conninfo)
+int gen_connect (struct obd_conn *conn)
 {
        struct obd_client * cli;
 
        OBD_ALLOC(cli, struct obd_client *, sizeof(struct obd_client));
        if ( !cli ) {
-               printk("obd_connect (minor %d): no memory!\n", 
-                      obddev->obd_minor);
+               printk(__FUNCTION__ ": no memory! (minor %d)\n", 
+                      conn->oc_dev->obd_minor);
                return -ENOMEM;
        }
 
        INIT_LIST_HEAD(&cli->cli_prealloc_inodes);
-       /* this should probably spinlocked? */
-       cli->cli_id = ++obddev->obd_gen_last_id;
+       /* XXX this should probably spinlocked? */
+       cli->cli_id = ++conn->oc_dev->obd_gen_last_id;
        cli->cli_prealloc_quota = 0;
-       cli->cli_obd = obddev;
-       list_add(&(cli->cli_chain), obddev->obd_gen_clients.prev);
+       cli->cli_obd = conn->oc_dev;
+       list_add(&(cli->cli_chain), conn->oc_dev->obd_gen_clients.prev);
 
-       CDEBUG(D_IOCTL, "connect: new ID %u\n", cli->cli_id);
-       conninfo->conn_id = cli->cli_id;
+       CDEBUG(D_INFO, "connect: new ID %u\n", cli->cli_id);
+       conn->oc_id = cli->cli_id;
        return 0;
 } /* gen_obd_connect */
 
 
-int gen_disconnect(unsigned int conn_id)
+int gen_disconnect(struct obd_conn *conn)
 {
        struct obd_client * cli;
-
        ENTRY;
 
-       if (!(cli = gen_client(conn_id))) {
+       if (!(cli = gen_client(conn))) {
                CDEBUG(D_IOCTL, "disconnect: attempting to free "
-                      "nonexistent client %u\n", conn_id);
+                      "nonexistent client %u\n", conn->oc_id);
                return -EINVAL;
        }
 
+
        list_del(&(cli->cli_chain));
        OBD_FREE(cli, sizeof(struct obd_client));
 
-       CDEBUG(D_IOCTL, "disconnect: ID %u\n", conn_id);
+       CDEBUG(D_INFO, "disconnect: ID %u\n", conn->oc_id);
 
        EXIT;
        return 0;
@@ -101,45 +144,30 @@ int gen_disconnect(unsigned int conn_id)
  *   used to make calls to these devices.
  *   data holds nothing
  */ 
-int gen_multi_setup(struct obd_device *obddev, int len, void *data)
+int gen_multi_setup(struct obd_device *obddev, uint32_t len, void *data)
 {
        int i;
-       struct obd_device *rdev = obddev->obd_multi_dev[0];
 
        for (i = 0 ; i < obddev->obd_multi_count ; i++ ) {
                int rc;
-               struct obd_device *child = rdev + i;
-               rc  = OBP(child, connect)(child, &rdev->obd_multi_conns[i]);
+               struct obd_conn *ch_conn = &obddev->obd_multi_conn[i];
+               rc  = OBP(ch_conn->oc_dev, connect)(ch_conn);
 
                if ( rc != 0 ) {
-                       /* XXX disconnect others */
+                       int j;
+
+                       for (j = --i; j >= 0; --j) {
+                               ch_conn = &obddev->obd_multi_conn[i];
+                               OBP(ch_conn->oc_dev, disconnect)(ch_conn);
+                       }
                        return -EINVAL;
                }
        }               
        return 0;
 }
 
-int gen_multi_cleanup(struct obd_device * obddev)
-{
-       int i;
-       struct obd_device **rdev = obddev->obd_multi_dev;
-
-       for (i = 0 ; i < obddev->obd_multi_count ; i++ ) {
-               int rc;
-               struct obd_device *child = *(rdev + i);
-               rc  = OBP(child, cleanup)(child);
-               *(rdev + i) = NULL;
-
-               if ( rc != 0 ) {
-                       /* XXX disconnect others */
-                       return -EINVAL;
-               }
-       }
-       gen_cleanup(obddev);
-       return 0;
-} /* sim_cleanup_obddev */
-
 
+#if 0
 int gen_multi_attach(struct obd_device *obddev, int len, void *data)
 {
        int i;
@@ -151,12 +179,12 @@ int gen_multi_attach(struct obd_device *obddev, int len, void *data)
        for (i=0 ; i<count ; i++) {
                rdev = &obd_dev[*((int *)data + i)];
                rdev = rdev + 1;
-               CDEBUG(D_IOCTL, "OBD RAID1: replicator %d is of type %s\n", i,
+               CDEBUG(D_INFO, "OBD RAID1: replicator %d is of type %s\n", i,
                       (rdev + i)->obd_type->typ_name);
        }
        return 0;
 }
-
+#endif
 
 
 /*
@@ -164,22 +192,20 @@ int gen_multi_attach(struct obd_device *obddev, int len, void *data)
  *    close all connections to lower devices
  *    needed for forced unloads of OBD client drivers
  */
-int gen_multi_cleanup_device(struct obd_device *obddev)
+int gen_multi_cleanup(struct obd_device *obddev)
 {
        int i;
-       struct obd_device **rdev;
 
-       rdev =  obddev->obd_multi_dev;
        for (i = 0 ; i < obddev->obd_multi_count ; i++ ) {
+               struct obd_conn *ch_conn = &obddev->obd_multi_conn[i];
                int rc;
-               struct obd_device *child = *(rdev + i);
-               rc  = OBP(child, disconnect)
-                       (obddev->obd_multi_conns[i].conn_id);
+               rc  = OBP(ch_conn->oc_dev, disconnect)(ch_conn);
 
                if ( rc != 0 ) {
-                       printk("OBD multi cleanup dev: disconnect failure %d\n", child->obd_minor);
+                       printk(KERN_WARNING __FUNCTION__
+                              ": disconnect failure %d\n",
+                              ch_conn->oc_dev->obd_minor);
                }
-               *(rdev + i) = NULL;
        }               
        return 0;
 } /* gen_multi_cleanup_device */
@@ -200,118 +226,99 @@ int gen_cleanup(struct obd_device * obddev)
        lh = tmp = &obddev->obd_gen_clients;
        while ((tmp = tmp->next) != lh) {
                cli = list_entry(tmp, struct obd_client, cli_chain);
-               CDEBUG(D_IOCTL, "Disconnecting obd_connection %d, at %p\n",
+               CDEBUG(D_INFO, "Disconnecting obd_connection %d, at %p\n",
                       cli->cli_id, cli);
-               OBP(obddev, disconnect)(cli->cli_id);
        }
-
-       return OBP(obddev, cleanup_device)(obddev);
+       return 0;
 } /* sim_cleanup_device */
 
-/* 
- * Wait for a page to get unlocked.
- *
- * This must be called with the caller "holding" the page,
- * ie with increased "page->count" so that the page won't
- * go away during the wait..
- */
-static void my__wait_on_page(struct page *page)
+void ___wait_on_page(struct page *page)
 {
-       struct task_struct *tsk = current;
-       DECLARE_WAITQUEUE(wait, tsk);
-
-       add_wait_queue(&page->wait, &wait);
-       do {
-               run_task_queue(&tq_disk);
-               set_task_state(tsk, TASK_UNINTERRUPTIBLE);
-               if (!PageLocked(page))
-                       break;
-               schedule();
-       } while (PageLocked(page));
-       tsk->state = TASK_RUNNING;
-       remove_wait_queue(&page->wait, &wait);
+        struct task_struct *tsk = current;
+        DECLARE_WAITQUEUE(wait, tsk);
+
+        add_wait_queue(&page->wait, &wait);
+        do {
+                run_task_queue(&tq_disk);
+                set_task_state(tsk, TASK_UNINTERRUPTIBLE);
+                if (!PageLocked(page))
+                        break;
+                schedule();
+        } while (PageLocked(page));
+        tsk->state = TASK_RUNNING;
+        remove_wait_queue(&page->wait, &wait);
 }
 
-/*
- * Get an exclusive lock on the page..
- */
-static void lck_page(struct page *page)
+void lck_page(struct page *page)
 {
-       while (TryLockPage(page))
-               my__wait_on_page(page);
+        while (TryLockPage(page))
+                ___wait_on_page(page);
 }
 
-/* obdo's must be correctly filled in by caller! */
-int gen_copy_data(struct obd_device *obddev, int conn_id, 
-                      obdattr *source, obdattr *target)
+int gen_copy_data(struct obd_conn *dst_conn, struct obdo *dst,
+                 struct obd_conn *src_conn, struct obdo *src,
+                 obd_size count, obd_off offset)
 {
        struct page *page;
-<<<<<<< genops.c
-       int res;
-       int err;
-       int i;
-=======
        unsigned long index = 0;
-       int rc;
->>>>>>> 1.5
+       int err = 0;
 
-<<<<<<< genops.c
-       page = __get_pages(GFP_USER, 0);
-       if (!page) 
-               return EIO;
-       lck_page(page);
-=======
+       ENTRY;
+       CDEBUG(D_INFO, "src: ino %Ld blocks %Ld, size %Ld, dst: ino %Ld\n", 
+              src->o_id, src->o_blocks, src->o_size, dst->o_id);
        page = alloc_page(GFP_USER);
-       if ( !page ) 
+       if ( !page ) {
+               EXIT;
                return -ENOMEM;
->>>>>>> 1.5
-
-       err = 0;
-       i = 0;
-       while (1) {
-               CDEBUG(D_IOCTL, "i %d, size %ld\n", i, source->i_size);
-               err = 0;
-               if ( i >= (source->i_size >> PAGE_SHIFT) ) 
-                       break;
+       }
        
-<<<<<<< genops.c
-               page->offset = i << PAGE_SHIFT;
-               err = -EIO;
-               CDEBUG(D_IOCTL, "i %d, offset %ld, size %ld\n", i, 
-                      page->offset, source->i_size);
-               res = OBP(obddev, brw)(READ, conn_id, source, page, 0);
-               CDEBUG(D_IOCTL, "Result reading %d\n", res);
-               if ( res < 0 ) 
-                       break;
-=======
        lck_page(page);
        
-       while (index < ((src->i_size + PAGE_SIZE - 1) >> PAGE_SHIFT)) {
+       /* XXX with brw vector I/O, we could batch up reads and writes here,
+        *     all we need to do is allocate multiple pages to handle the I/Os
+        *     and arrays to handle the request parameters.
+        */
+       while (index < ((src->o_size + PAGE_SIZE - 1) >> PAGE_SHIFT)) {
+               obd_count        num_oa = 1;
+               obd_count        num_buf = 1;
+               char            *buf;
+               obd_size         brw_count = PAGE_SIZE;
+               obd_off          brw_offset = (page->index) << PAGE_SHIFT;
+               obd_flag         flagr = 0;
+               obd_flag         flagw = OBD_BRW_CREATE;
                
                page->index = index;
-               rc = OBP(conn->oc_dev, brw)(READ, conn, src, page, 0);
->>>>>>> 1.5
+               buf = (char *)page_address(page); 
+               err = OBP(src_conn->oc_dev, brw)(READ, src_conn, num_oa, &src,
+                                                &num_buf, &buf, &brw_count,
+                                                &brw_offset, &flagr);
 
-               res = OBP(obddev, brw)(WRITE, conn_id, target, page, 1);
-               CDEBUG(D_IOCTL, "Result writing %d\n", res);
-               if ( res < 0 ) 
+               if ( err ) {
+                       EXIT;
                        break;
+               }
+               CDEBUG(D_INFO, "Read page %ld ...\n", page->index);
+
+               err = OBP(dst_conn->oc_dev, brw)(WRITE, dst_conn, num_oa, &dst,
+                                                &num_buf, &buf, &brw_count,
+                                                &brw_offset, &flagw);
 
-<<<<<<< genops.c
-               i++;
-=======
-               rc = OBP(conn->oc_dev,brw)(WRITE, conn, tgt, page, 1);
-               if ( rc != PAGE_SIZE)
+               /* XXX should handle dst->o_size, dst->o_blocks here */
+               if ( err ) {
+                       EXIT;
                        break;
+               }
+
+               CDEBUG(D_INFO, "Wrote page %ld ...\n", page->index);
                
-               index ++;
->>>>>>> 1.5
+               index++;
        }
+       dst->o_size = src->o_size;
+       dst->o_blocks = src->o_blocks;
+       dst->o_valid |= (OBD_MD_FLSIZE | OBD_MD_FLBLOCKS);
        UnlockPage(page);
        __free_page(page);
 
-       target->i_size = source->i_size;
-       OBP(obddev, setattr)(conn_id, target);
-
+       EXIT;
        return err;
 }