* GPL HEADER END
*/
/*
- * Copyright (c) 2012, Intel Corporation.
+ * Copyright (c) 2012, 2013, Intel Corporation.
* Use is subject to license terms.
* Copyright (c) 2011, 2012 Commissariat a l'energie atomique et aux energies
* alternatives
* Author: JC Lafoucriere <jacques-charles.lafoucriere@cea.fr>
*/
-#ifndef EXPORT_SYMTAB
-# define EXPORT_SYMTAB
-#endif
#define DEBUG_SUBSYSTEM S_MDS
#include "mdt_internal.h"
-/*
- * fake functions, will be replace by real one with HSM Coordinator patch
- */
-
-int mdt_hsm_copytool_send(struct obd_export *exp)
-{
- return 0;
-}
-
-static int mdt_hsm_coordinator_update(struct mdt_thread_info *info,
- struct hsm_progress_kernel *pgs)
-{
- return 0;
-}
-
-static int mdt_hsm_agent_register_mask(struct mdt_thread_info *info,
- struct obd_uuid *uuid,
- __u32 archive_mask)
-{
- return 0;
-}
+/* Max allocation to satisfy single HSM RPC. */
+#define MDT_HSM_ALLOC_MAX (1 << 20)
-static int mdt_hsm_agent_unregister(struct mdt_thread_info *info,
- struct obd_uuid *uuid)
-{
- return 0;
-}
+#define MDT_HSM_ALLOC(ptr, size) \
+ do { \
+ if ((size) <= MDT_HSM_ALLOC_MAX) \
+ OBD_ALLOC_LARGE((ptr), (size)); \
+ else \
+ (ptr) = NULL; \
+ } while (0)
-static int mdt_hsm_coordinator_get_actions(struct mdt_thread_info *mti,
- struct hsm_action_list *hal)
-{
- return 0;
-}
-
-static int mdt_hsm_coordinator_actions(struct mdt_thread_info *info,
- struct hsm_action_list *hal,
- __u64 *compound_id,
- int mti_attr_is_valid)
-{
- return 0;
-}
+#define MDT_HSM_FREE(ptr, size) OBD_FREE_LARGE((ptr), (size))
/**
* Update on-disk HSM attributes.
*/
int mdt_hsm_attr_set(struct mdt_thread_info *info, struct mdt_object *obj,
- struct md_hsm *mh)
+ const struct md_hsm *mh)
{
struct md_object *next = mdt_object_child(obj);
struct lu_buf *buf = &info->mti_buf;
*/
int mdt_hsm_progress(struct mdt_thread_info *info)
{
+ struct mdt_body *body;
struct hsm_progress_kernel *hpk;
int rc;
ENTRY;
+ body = req_capsule_client_get(info->mti_pill, &RMF_MDT_BODY);
+ if (body == NULL)
+ RETURN(-EPROTO);
+
hpk = req_capsule_client_get(info->mti_pill, &RMF_MDS_HSM_PROGRESS);
- LASSERT(hpk);
+ if (hpk == NULL)
+ RETURN(-EPROTO);
+
+ hpk->hpk_errval = lustre_errno_ntoh(hpk->hpk_errval);
CDEBUG(D_HSM, "Progress on "DFID": len="LPU64" err=%d\n",
PFID(&hpk->hpk_fid), hpk->hpk_extent.length, hpk->hpk_errval);
int mdt_hsm_ct_register(struct mdt_thread_info *info)
{
- struct ptlrpc_request *req = mdt_info_req(info);
- __u32 *archives;
- int rc;
+ struct mdt_body *body;
+ struct ptlrpc_request *req = mdt_info_req(info);
+ __u32 *archives;
+ int rc;
ENTRY;
+ body = req_capsule_client_get(info->mti_pill, &RMF_MDT_BODY);
+ if (body == NULL)
+ RETURN(-EPROTO);
+
archives = req_capsule_client_get(info->mti_pill, &RMF_MDS_HSM_ARCHIVE);
- LASSERT(archives);
+ if (archives == NULL)
+ RETURN(-EPROTO);
/* XXX: directly include this function here? */
rc = mdt_hsm_agent_register_mask(info, &req->rq_export->exp_client_uuid,
int mdt_hsm_ct_unregister(struct mdt_thread_info *info)
{
- struct ptlrpc_request *req = mdt_info_req(info);
- int rc;
+ struct mdt_body *body;
+ struct ptlrpc_request *req = mdt_info_req(info);
+ int rc;
ENTRY;
+ body = req_capsule_client_get(info->mti_pill, &RMF_MDT_BODY);
+ if (body == NULL)
+ RETURN(-EPROTO);
+
/* XXX: directly include this function here? */
rc = mdt_hsm_agent_unregister(info, &req->rq_export->exp_client_uuid);
RETURN(rc);
}
-
/**
* Retrieve the current HSM flags, archive id and undergoing HSM requests for
* the fid provided in RPC body.
req_capsule_client_get(info->mti_pill, &RMF_CAPA1));
hus = req_capsule_server_get(info->mti_pill, &RMF_HSM_USER_STATE);
- LASSERT(hus);
+ if (hus == NULL)
+ GOTO(out_ucred, rc = -EPROTO);
/* Current HSM flags */
hus->hus_states = ma->ma_hsm.mh_flags;
GOTO(out_ucred, rc);
hss = req_capsule_client_get(info->mti_pill, &RMF_HSM_STATE_SET);
- LASSERT(hss);
+ if (hss == NULL)
+ GOTO(out_ucred, rc = -EPROTO);
if (req_capsule_get_size(info->mti_pill, &RMF_CAPA1, RCL_CLIENT))
mdt_set_capainfo(info, 0, &info->mti_body->fid1,
* LOST without ARCHIVED: cannot lost a non-archived file.
*/
flags = ma->ma_hsm.mh_flags;
- if (((flags & HS_DIRTY) && !(flags & HS_EXISTS)) ||
- ((flags & HS_RELEASED) && (flags & HS_DIRTY)) ||
- ((flags & HS_RELEASED) && !(flags & HS_ARCHIVED)) ||
- ((flags & HS_LOST) && !(flags & HS_ARCHIVED))) {
+ if ((flags & HS_DIRTY && !(flags & HS_EXISTS)) ||
+ (flags & HS_RELEASED && flags & HS_DIRTY) ||
+ (flags & HS_RELEASED && !(flags & HS_ARCHIVED)) ||
+ (flags & HS_LOST && !(flags & HS_ARCHIVED))) {
CDEBUG(D_HSM, "Incompatible flag change on "DFID
"flags="LPX64"\n",
PFID(&info->mti_body->fid1), flags);
struct hsm_current_action *hca;
struct hsm_action_list *hal = NULL;
struct hsm_action_item *hai;
- int rc, len;
+ int hal_size;
+ int rc;
ENTRY;
/* Only valid if client is remote */
hca = req_capsule_server_get(info->mti_pill,
&RMF_MDS_HSM_CURRENT_ACTION);
- LASSERT(hca);
+ if (hca == NULL)
+ GOTO(out_ucred, rc = -EPROTO);
/* Coordinator information */
- len = sizeof(*hal) + MTI_NAME_MAXLEN /* fsname */ +
- cfs_size_round(sizeof(*hai));
+ hal_size = sizeof(*hal) +
+ cfs_size_round(MTI_NAME_MAXLEN) /* fsname */ +
+ cfs_size_round(sizeof(*hai));
- OBD_ALLOC(hal, len);
+ MDT_HSM_ALLOC(hal, hal_size);
if (hal == NULL)
- GOTO(out_ucred, -ENOMEM);
+ GOTO(out_ucred, rc = -ENOMEM);
hal->hal_version = HAL_VERSION;
hal->hal_archive_id = 0;
hal->hal_flags = 0;
- obd_uuid2fsname(hal->hal_fsname, mdt2obd_dev(info->mti_mdt)->obd_name,
+ obd_uuid2fsname(hal->hal_fsname, mdt_obd_name(info->mti_mdt),
MTI_NAME_MAXLEN);
hal->hal_count = 1;
- hai = hai_zero(hal);
+ hai = hai_first(hal);
hai->hai_action = HSMA_NONE;
hai->hai_cookie = 0;
hai->hai_gid = 0;
hai->hai_fid = info->mti_body->fid1;
hai->hai_len = sizeof(*hai);
- rc = mdt_hsm_coordinator_get_actions(info, hal);
+ rc = mdt_hsm_get_actions(info, hal);
if (rc)
GOTO(out_free, rc);
default:
hca->hca_action = HUA_NONE;
CERROR("%s: Unknown hsm action: %d on "DFID"\n",
- mdt2obd_dev(info->mti_mdt)->obd_name,
+ mdt_obd_name(info->mti_mdt),
hai->hai_action, PFID(&hai->hai_fid));
break;
}
EXIT;
out_free:
- OBD_FREE(hal, len);
+ MDT_HSM_FREE(hal, hal_size);
out_ucred:
mdt_exit_ucred(info);
return rc;
struct hsm_user_item *hui;
struct hsm_action_list *hal;
struct hsm_action_item *hai;
- char *opaque;
+ const void *data;
+ int hui_list_size;
+ int data_size;
enum hsm_copytool_action action = HSMA_NONE;
__u64 compound_id;
- int len, i, rc;
+ int hal_size, i, rc;
ENTRY;
body = req_capsule_client_get(pill, &RMF_MDT_BODY);
- LASSERT(body);
-
hr = req_capsule_client_get(pill, &RMF_MDS_HSM_REQUEST);
- LASSERT(hr);
-
hui = req_capsule_client_get(pill, &RMF_MDS_HSM_USER_ITEM);
- LASSERT(hui);
+ data = req_capsule_client_get(pill, &RMF_GENERIC_DATA);
- opaque = req_capsule_client_get(pill, &RMF_GENERIC_DATA);
- LASSERT(opaque);
+ if (body == NULL || hr == NULL || hui == NULL || data == NULL)
+ RETURN(-EPROTO);
/* Sanity check. Nothing to do with an empty list */
if (hr->hr_itemcount == 0)
RETURN(0);
+ hui_list_size = req_capsule_get_size(pill, &RMF_MDS_HSM_USER_ITEM,
+ RCL_CLIENT);
+ if (hui_list_size < hr->hr_itemcount * sizeof(*hui))
+ RETURN(-EPROTO);
+
+ data_size = req_capsule_get_size(pill, &RMF_GENERIC_DATA, RCL_CLIENT);
+ if (data_size != hr->hr_data_len)
+ RETURN(-EPROTO);
+
/* Only valid if client is remote */
rc = mdt_init_ucred(info, body);
if (rc)
GOTO(out_ucred, rc = -EINVAL);
}
- len = sizeof(*hal) + MTI_NAME_MAXLEN /* fsname */ +
- cfs_size_round(sizeof(*hai) * hr->hr_itemcount) +
- cfs_size_round(hr->hr_data_len * hr->hr_itemcount);
+ hal_size = sizeof(*hal) + cfs_size_round(MTI_NAME_MAXLEN) /* fsname */ +
+ (sizeof(*hai) + cfs_size_round(hr->hr_data_len)) *
+ hr->hr_itemcount;
- OBD_ALLOC(hal, len);
+ MDT_HSM_ALLOC(hal, hal_size);
if (hal == NULL)
GOTO(out_ucred, rc = -ENOMEM);
hal->hal_version = HAL_VERSION;
hal->hal_archive_id = hr->hr_archive_id;
hal->hal_flags = hr->hr_flags;
- obd_uuid2fsname(hal->hal_fsname, mdt2obd_dev(info->mti_mdt)->obd_name,
+ obd_uuid2fsname(hal->hal_fsname, mdt_obd_name(info->mti_mdt),
MTI_NAME_MAXLEN);
hal->hal_count = hr->hr_itemcount;
- hai = hai_zero(hal);
- for (i = 0; i < hr->hr_itemcount; i++) {
+ hai = hai_first(hal);
+ for (i = 0; i < hr->hr_itemcount; i++, hai = hai_next(hai)) {
hai->hai_action = action;
hai->hai_cookie = 0;
hai->hai_gid = 0;
hai->hai_fid = hui[i].hui_fid;
hai->hai_extent = hui[i].hui_extent;
- memcpy(hai->hai_data, opaque, hr->hr_data_len);
+ memcpy(hai->hai_data, data, hr->hr_data_len);
hai->hai_len = sizeof(*hai) + hr->hr_data_len;
- hai = hai_next(hai);
}
- rc = mdt_hsm_coordinator_actions(info, hal, &compound_id, 0);
- /* ENODATA error code is needed only for implicit requests */
- if (rc == -ENODATA)
- rc = 0;
+ rc = mdt_hsm_add_actions(info, hal, &compound_id);
+
+ MDT_HSM_FREE(hal, hal_size);
+
+ GOTO(out_ucred, rc);
- OBD_FREE(hal, len);
- EXIT;
out_ucred:
mdt_exit_ucred(info);
return rc;
}
-